Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable (non-orographic) precipitation #7

Open
benbovy opened this issue Oct 11, 2022 · 1 comment
Open

Variable (non-orographic) precipitation #7

benbovy opened this issue Oct 11, 2022 · 1 comment

Comments

@benbovy
Copy link
Member

benbovy commented Oct 11, 2022

We've discussed with @hannahsophiadavies the possibility to use a field of spatially variable precipitation rate as input. Technically, I think it should just work using the compute_orographic_precip function. However, this is currently not supported in the fastscape extension as OrographicPrecipitation.precip_base only accepts a scalar value:

precip_base = xs.variable(description="background, non-orographic precipitation rate",
attrs={"units": "mm/h"})

All it needs is the precip_base variable to accept both a scalar and a 2D field using dims=[(), ('y', 'x')].

Other variables might be concerned too:

  • rainfall_frequency could also accept a 2D field? (note: it should be moved to the OrographicDrainageDischarge process - Scaling precipitation to FastScape #4 (comment))
  • What about wind_speed and wind_dir? It looks like it would work with 2d arrays instead of scalars just like for precip_base. I've no idea whether or not this makes any sense regarding the theory (model assumptions), though.

Someone interested in putting together a pull-request?

cc @EstebanAce

@benbovy
Copy link
Member Author

benbovy commented Oct 11, 2022

Note to @hannahsophiadavies: @EstebanAce's pull-request #6 fixes another issue (precip rates < 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant