Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #3

Open
3 tasks
benbovy opened this issue Jun 4, 2020 · 0 comments
Open
3 tasks

Update tests #3

benbovy opened this issue Jun 4, 2020 · 0 comments

Comments

@benbovy
Copy link
Member

benbovy commented Jun 4, 2020

TODO:

  • simplify the structure (no need of fixtures if it's just for the input parameters of a single test).
  • test the actual logic implemented in compute_orographic_precip. Is there any ideal topography where we can compare the result against an analytical solution (e.g., with a gaussian pulse like shown in README)? Probably worth checking the paper.
  • add tests for the two process classes in fastscape_ext. Testing OrographicPrecipitation could be very similar than the test for compute_orographic_precip. No need to test the whole logic of OrographicDrainageDischarge (its base class will be tested upstream in fastscape), just ensure that values are converted as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant