Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_path param does not expect trailing slash for files/folders #75

Open
jacobtabak opened this issue Jun 13, 2019 · 0 comments
Open

s3_path param does not expect trailing slash for files/folders #75

jacobtabak opened this issue Jun 13, 2019 · 0 comments

Comments

@jacobtabak
Copy link

jacobtabak commented Jun 13, 2019

The default value of s3_path for APKs and IPAs is "#{version_code}_#{version_name}/" unless s3_path

The default value of s3_path for files is "files" unless s3_path

You can see that for APKs, a trailing slash is expected, and for files, it is not. This means that files get uploaded to subdirectory (with a 0-length title) of the directory that the APKs/IPAs get uploaded to.

image

For reference, this is what our invocation looks like -

    aws_s3(
      access_key: ENV['AWS_ACCESS_KEY_ID'],
      secret_access_key: ENV['AWS_SECRET_ACCESS_KEY'],
      bucket: ENV['ARTIFACTS_S3_BUCKET'],
      region: "eu-west-1",
      files: [ 
        "#{lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH]}" 
      ],
      path: "#{ENV["CIRCLE_BUILD_NUM"]}",
      app_directory: artifacts_root + "prod/android",
      upload_metadata: true
    )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant