Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to upload additional files (per-version) #32

Open
davibe opened this issue Jun 18, 2017 · 4 comments
Open

How to upload additional files (per-version) #32

davibe opened this issue Jun 18, 2017 · 4 comments

Comments

@davibe
Copy link

davibe commented Jun 18, 2017

For example i would like to upload CHANGELOG.md which i will then read with ajax in my html template. The goal is to show the user what changed in this version right before / during download

@davibe davibe changed the title upload additional files How to upload additional files (per-version) Jun 18, 2017
@joshdholtz
Copy link
Member

@davibe I have not thought about this before but I do like this idea. I will work on this when I have some free time or if anybody wants to create a PR for this that would be super appreciated 😊

@davibe
Copy link
Author

davibe commented Nov 28, 2017

Further working on things.. i think this is not just about changelog. It's more about being able to upload additional artifacts. For example you may want to release a framework + sample app + resources + other artifacts that are specifically related to the build.

I wonder wether this should be a feature of this plugin or maybe it makes sense to have a separate and generic plugin for uploading files to s3. I also think it's important to have the ability to upload entire folders.

@joshdholtz
Copy link
Member

@davibe Sorry, I totally dropped the ball on this issue! Something like this was added in #45 so I can totes just reuse this same logic for adding an array of files. Thoughts?

@davibe
Copy link
Author

davibe commented Nov 29, 2017

I think uploading a folder (recursive) would be better than an array of file. Something like artifacts: "path/to/folder" which uploads everything to [buildname]/[platform]/artifacts with public acl etc... Think for example of automation test results. Those are generated dynamically during tests and you can't write the array in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants