Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types for SessionStore Promise based API support #237

Open
2 tasks done
jonaskello opened this issue Mar 21, 2024 · 1 comment
Open
2 tasks done

Typescript types for SessionStore Promise based API support #237

jonaskello opened this issue Mar 21, 2024 · 1 comment

Comments

@jonaskello
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

In #78 the SessionStore was upgraded to support both callback and Promise based API. However this is not reflected in the current typescript types. I propose that the typescript types are updated to reflect the changes in #78.

Motivation

Typescript users could use Promise.

Example

No response

@mcollina
Copy link
Member

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests. We use tsd for types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants