Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention mysql2 pooling option in the docs #100

Open
2 tasks done
songpr opened this issue Jul 11, 2022 · 1 comment
Open
2 tasks done

Mention mysql2 pooling option in the docs #100

songpr opened this issue Jul 11, 2022 · 1 comment

Comments

@songpr
Copy link

songpr commented Jul 11, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

Mysql2 pooling is good for performance https://www.npmjs.com/package/mysql2#using-connection-pools also it have promise pool

Motivation

To improve performance when it have a lot of connection to mysql

Example

No response

@Eomm
Copy link
Member

Eomm commented Jul 11, 2022

It is already doable and the default setting as well

from docs:

If you don't use the connectionString option, the options that you pass to register will be passed to the MySQL pool builder.

client = mysql.createPool(options.connectionString || options)

Would you mind improving our docs?

@gurgunday gurgunday changed the title Mysql2 pooling Mention mysql2 pooling option in the docs Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants