Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuthAccount.expires_at should be BigInteger #1296

Open
holtgrewe opened this issue Oct 2, 2023 · 1 comment
Open

OAuthAccount.expires_at should be BigInteger #1296

holtgrewe opened this issue Oct 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@holtgrewe
Copy link

Describe the bug

The OAuthAccount.expires_at field is an Integer. If your OAuth2 provider decides to give you a value in 2043 (as ORCID sandbox does) then this cannot be inserted into the database any more.

To Reproduce

Steps to reproduce the behavior:

  1. Setup fastapi-users with OAuth2.
  2. Authenticate with a provider who returns a sufficiently large expires_at value.
  3. Database insert will fail.

Expected behavior

Dates in 2043 should work.

Configuration

  • Python version : 3.11
  • FastAPI version : 0.103.1
  • FastAPI Users version : 12.1.2

FastAPI Users configuration

N/A

Additional context

N/A

@holtgrewe holtgrewe added the bug Something isn't working label Oct 2, 2023
@frankie567
Copy link
Member

Good catch, indeed! PR welcome on fastapi-users-db-sqlalchemy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants