Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force_console_behavior does not modify behavior #103

Open
codewithcheese opened this issue Feb 25, 2023 · 0 comments
Open

force_console_behavior does not modify behavior #103

codewithcheese opened this issue Feb 25, 2023 · 0 comments

Comments

@codewithcheese
Copy link

codewithcheese commented Feb 25, 2023

Hi there, I am confused about the force_console_behavior function, it does not force any behavior itself, it simply returns the console master and progress bars. I can't tell if it is misnamed or this is a regression.

fastai ProgressCallback uses the master_bar imported from fastprogress, so to force console the master_bar and progress_bar variables should be updated.

The current implementation is:

#export
def force_console_behavior():
    "Return the console progress bars"
    return ConsoleMasterBar, ConsoleProgressBar

I would expect this instead:

#export
def force_console_behavior():
    master_bar = ConsoleMasterBar
    progress_bar = ConsoleProgressBar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant