Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: add ability to have *args in @call_parse #488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhancement: add ability to have *args in @call_parse #488

wants to merge 1 commit into from
+126 −36

Conversation

Salehbigdeli
Copy link
Contributor

Fixes: #487

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@deven367
Copy link

deven367 commented Feb 4, 2023

@jph00 can you please take a look at this?

@jph00 jph00 closed this Feb 4, 2023
@jph00 jph00 reopened this Feb 4, 2023
@jph00
Copy link
Member

jph00 commented Feb 4, 2023

@deven367 @Salehbigdeli are either of you interested in taking a look at the failing test in nbdev that this PR seems to have caused?

@deven367
Copy link

deven367 commented Feb 6, 2023

@jph00 I'll look at it this week. But I might need some hand holding. 😅

@jph00
Copy link
Member

jph00 commented Feb 6, 2023 via email

@Salehbigdeli Salehbigdeli force-pushed the Enhance-variable-arguments-arg-parse branch from 64f49c9 to 31325b7 Compare March 2, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using *args with @call_parse
3 participants
@Salehbigdeli @deven367 @jph00