Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks should be passed the User instance #163

Open
tchaumeny opened this issue Jun 28, 2021 · 0 comments
Open

Hooks should be passed the User instance #163

tchaumeny opened this issue Jun 28, 2021 · 0 comments

Comments

@tchaumeny
Copy link

tchaumeny commented Jun 28, 2021 •
edited

Currently, the hooks CREATE_USER and BEFORE_LOGIN are passed the user_identity from SAML.

They should also be passed a the matching target_user — it is available at that point. That would help implement features like checking for specific flags on User to authorize SAML login or saving information related to user when created or logged in.
tchaumeny added a commit to foodles-tech/django-saml2-auth that referenced this issue Jun 28, 2021
@tchaumeny
Pass the user object to hooks methods — See fangli#163
720dfcc
@tchaumeny tchaumeny mentioned this issue Jun 28, 2021
Closed
@tchaumeny tchaumeny changed the title Hooks should be passed the User object Hooks should be passed the User instance Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tchaumeny