Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit location drawer #364

Open
ezwelty opened this issue Jul 2, 2023 · 0 comments
Open

Revisit location drawer #364

ezwelty opened this issue Jul 2, 2023 · 0 comments
Labels
mobile Specific to mobile layout refactoring Internal changes to code aesthetic or structure

Comments

@ezwelty
Copy link
Collaborator

ezwelty commented Jul 2, 2023

The location drawer is one of the most complex and fragile parts of the code and may be worth redesigning with a goal of simplifying the layout and underlying logic. For example:

  • Move photos to within the drawer (below location types)
  • Use a common fullscreen layout for map and list view that allows scrolling (e.g. https://jsfiddle.net/ofg89bna/1/)
  • Only display location types when drawer is in middle position (avoiding an extra API call), then clicking an expand button for a full view
@ezwelty ezwelty added refactoring Internal changes to code aesthetic or structure mobile Specific to mobile layout labels Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Specific to mobile layout refactoring Internal changes to code aesthetic or structure
Projects
None yet
Development

No branches or pull requests

1 participant