Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parent types with themselves as their only child not expandable #311

Open
ezwelty opened this issue May 23, 2022 · 1 comment · May be fixed by #376
Open

Make parent types with themselves as their only child not expandable #311

ezwelty opened this issue May 23, 2022 · 1 comment · May be fixed by #376
Labels
help wanted Extra attention is needed performance Related to interface speed and responsiveness

Comments

@ezwelty
Copy link
Collaborator

ezwelty commented May 23, 2022

Under each parent type, the type filter lists the type associated with that parent as well as any children types. Often, when the tree is showing limited results (e.g. "Only on map"), many parent types are shown with themselves as their only child. For example, in the screenshot below, Juglans regia is the only child of Juglans regia. In these cases, the parent does not need to be expandable and could stand in for its associated type. However, it is not clear then if (de)selecting a parent should select/deselect the parent and all of its children (the current behavior) or the parent and only the children currently shown.

image

@ezwelty ezwelty added performance Related to interface speed and responsiveness P1 help wanted Extra attention is needed and removed P1 labels May 23, 2022
@ezwelty ezwelty removed the P2 label Feb 3, 2023
@wbazant
Copy link
Contributor

wbazant commented May 23, 2024

I think this can be implemented through the behaviour of culling parents of single children in the tree, for example here, "Wild garlic" being under "Onion" was confusing.

Screen Shot 2024-05-23 at 13 41 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed performance Related to interface speed and responsiveness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants