Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kernel check for modern-bpf #1723

Closed
wants to merge 1 commit into from
Closed

update kernel check for modern-bpf #1723

wants to merge 1 commit into from

Conversation

yzewei
Copy link
Contributor

@yzewei yzewei commented Mar 2, 2024 •
edited

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1719

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kernel version used 6.8.0 -rc5

@yzewei
update kernel check for modern-bpf
c55db4c 
Signed-off-by: yzewei <yangzewei@loongson.cn>
@poiana
Copy link
Contributor

poiana commented Mar 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yzewei
Once this PR has been reviewed and has the lgtm label, please assign hbrueckner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from hbrueckner and mstemm March 2, 2024 03:06
@yzewei
Copy link
Contributor Author

yzewei commented Mar 2, 2024

Or is there a better solution?

@FedeDP
Copy link
Contributor

FedeDP commented Mar 2, 2024

/hold
Since our modern probe is CO-RE, it should not spot any ifdef inside on the kernel release: it is built just once and then distributed to all supported systems.
"bpf_core_" APIs are made exactly for this reason: dynamically ask the running kernel to check for something and then react accordingly.

So, in the end, this is not a viable solution.
I will check the issue and try to understand what's happening next week!

@FedeDP
Copy link
Contributor

FedeDP commented Mar 7, 2024

Closing this one since it uses a wrong approach.
/close

@poiana poiana closed this Mar 7, 2024
@poiana
Copy link
Contributor

poiana commented Mar 7, 2024

@FedeDP: Closed this PR.

In response to this:

Closing this one since it uses a wrong approach.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Contributor

FedeDP commented Mar 7, 2024

/milestone TBD

@poiana poiana added this to the TBD milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees
No one assigned
Labels
dco-signoff: yes do-not-merge/hold release-note size/L
Projects
None yet
Milestone
TBD
Development

Successfully merging this pull request may close these issues.

[BUG] Compile modern_bpf error
3 participants
@yzewei @poiana @FedeDP