Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING] Technical debt cleanup wrt edge case segfaults or memleaks 馃Ч #1468

Open
1 task done
incertum opened this issue Nov 2, 2023 · 8 comments
Open
1 task done
Labels
kind/feature New feature or request
Milestone

Comments

@incertum
Copy link
Contributor

incertum commented Nov 2, 2023

We can use this ticket to collectively discuss steps we can take to more programmatically attempt to reduce issues related to more corner case segfaults or memory leaks. It's a challenging task for everyone reading this, and we are not planning to rewrite the libraries in Rust at this time.

@falcosecurity/libs-maintainers

Tasks

  1. kind/feature
@incertum incertum added the kind/feature New feature or request label Nov 2, 2023
@incertum
Copy link
Contributor Author

incertum commented Nov 2, 2023

Raw notes from the 2023-11-02 core maintainers meeting:

  • Reject raw pointers? We should still replace them with smart pointers whenever possible. This will make ownership more clear and transparent in libsinsp.
  • Pass by parameter or by reference when possible.
  • Remove things that are not needed from the core code base first. Removing udig and mesos is more difficult because they are more tangled than removing the old k8s client code base. @jasondellaluce volunteered to tackle this (mesos + k8s client removal after we have the new k8s client implementation -> coordinate with @Andreagit97).
  • Consider prioritizing removing the respective code lines in sinsp next first. (@gnosek comment)

@incertum incertum added this to the TBD milestone Nov 2, 2023
@LucaGuerra
Copy link
Contributor

From the meeting, as a practical item we mentioned the work we started to support UndefinedBehaviorSanitizer (and we can continue with more sanitizer/safeguards), I have created an issue for it: #1470

@poiana
Copy link
Contributor

poiana commented Feb 22, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Feb 23, 2024

What are the next steps here?

@incertum
Copy link
Contributor Author

I think we have 5+ folks currently cleaning the code base like crazy in many corners, which is amazing 馃殌

@poiana
Copy link
Contributor

poiana commented Mar 24, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@FedeDP
Copy link
Contributor

FedeDP commented Mar 25, 2024

remove-lifecycle rotten

@FedeDP
Copy link
Contributor

FedeDP commented Mar 25, 2024

/remove-lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants