Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAM type enum is incomplete #47

Open
JustAMan opened this issue Aug 10, 2021 · 3 comments
Open

RAM type enum is incomplete #47

JustAMan opened this issue Aug 10, 2021 · 3 comments
Assignees

Comments

@JustAMan
Copy link

JustAMan commented Aug 10, 2021

RAM type enum is missing HBM2/GDDR6/GDDR6X entries at

public enum GPUMemoryType : uint

You can look at the ones I took from GPU-Z here: https://github.com/JustAMan/pynvraw/blob/498591713adcfbdf7aae1a348c1af76513ef9a43/src/pynvraw/nvapi_api.py#L735-L749
(copied down below for easier reading)

class RamType(enum.IntEnum):
    Unknown = 0
    SDRAM = 1
    DDR1 = 2
    DDR2 = 3
    GDDR2 = 4
    GDDR3 = 5
    GDDR4 = 6
    DDR3 = 7
    GDDR5 = 8
    DDR2_alt = 9
    GDDR5X = 10
    HBM2 = 12
    GDDR6 = 14
    GDDR6X = 15
@JustAMan JustAMan changed the title RAM type enum is incorrect RAM type enum is incomplete Aug 10, 2021
@falahati
Copy link
Owner

falahati commented Aug 10, 2021

Well, it is correct, it is just that the HBM2, GDDR6, GDDR6X are missing probably due to the fact that at the time of porting this library these values were not in use.

If it is about the DDR2_alt, I suppose 9 is not actually DDR2 but rather LPDDR2 which is a low power memory module with DDR2 speeds.

@falahati falahati self-assigned this Aug 10, 2021
@falahati
Copy link
Owner

Thanks for reporting this, I will keep this issue open till I add these new values to the enum. 👍

@JustAMan
Copy link
Author

If it is about the DDR2_alt, I suppose 9 is not actually DDR2 but rather LPDDR2 which is a low power memory module with DDR2 speeds.

I've already fixed that in my code to your version 🙃 it's just GPU-Z reports both as just DDR2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants