Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construction from hex strings #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waegemans
Copy link

@waegemans waegemans commented Jul 7, 2019

Closes: #37
Changes:

  • Allows construction from hex string (e.g. BigInt("0xaf123e"), BigInt("-0xff")). Hex string is converted to decimal during construction.
  • Tests for construction from hex
  • Remove unused bool is_valid_number(const std::string& num) in file include/functions/utility.hpp

@touatily
Copy link

touatily commented Jan 3, 2024

Handling any other base would have been better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for hexadecimal string in constructor
2 participants