Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide js assets in the source tarball #334

Open
landryb opened this issue Sep 24, 2017 · 3 comments
Open

provide js assets in the source tarball #334

landryb opened this issue Sep 24, 2017 · 3 comments
Labels
Enhancement Release and Packaging Release process and OS distribution packaging related

Comments

@landryb
Copy link
Contributor

landryb commented Sep 24, 2017

just discussed this with @falzm, for 'distro' packagers itwould be super nice to provide js assets in the source tarball we grab from github so that we dont have npm/bower reaching out to internet during build - otherwise we need to repackage ourself the source tarball, manually adding the assets that were locally fetched.

@vbatoufflet
Copy link
Member

I'm fine with this idea but I'll to take a look at it to see how I can automate this as the current source tarballs available are automatically generated by Github.

@vbatoufflet vbatoufflet added Enhancement Release and Packaging Release process and OS distribution packaging related labels Sep 25, 2017
@landryb
Copy link
Contributor Author

landryb commented Sep 25, 2017

Yeah, and our build infra is able to fetch a tarball from the github tag, but that doesnt have the assets - i fully understand if you dont want to commit the assets to the repository, so maybe it's only a matter of providing a 'tarball' target in the Makefile that builds the assets and creates the source tarball. - after that, either the distributors use this target to create and host the tarball themselves, or upstream provides it, but that's more work for you :/

@vbatoufflet
Copy link
Member

It's ok for me having such tarball target or similar as, indeed, I don't want to commit the assets in the repository 😄

I'll try to add this on the master branch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Release and Packaging Release process and OS distribution packaging related
Projects
None yet
Development

No branches or pull requests

2 participants