Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

generation_args["stop"] doesn't work for stop sequence "\n\n" #642

Open
frankxu2004 opened this issue Feb 7, 2023 · 0 comments
Open

generation_args["stop"] doesn't work for stop sequence "\n\n" #642

frankxu2004 opened this issue Feb 7, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@frankxu2004
Copy link

馃悰 Bug

The stop parameter provided to the API is not working as expected when stop = "\n\n"

To Reproduce

Steps to reproduce the behavior (always include the command you ran):

  1. Run cmd 'metaseq-api-local'
  2. Send HTTP request to /completions with parameter {"stop": "\n\n"}.
  3. Still generate until max number of tokens reached.

Expected behavior

Stop after generating two consecutive newlines

Environment

  • metaseq Version (master):

Additional context

When trying with other stop sequences, e.g. {"stop": "Question:"}, it works as expected.

@frankxu2004 frankxu2004 added the bug Something isn't working label Feb 7, 2023
@punitkoura punitkoura self-assigned this Mar 21, 2023
@punitkoura punitkoura removed their assignment Apr 4, 2023
@andrewPoulton andrewPoulton self-assigned this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants