Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add batch support to ModelEnv.evaluate_action_sequences #132

Open
luisenp opened this issue Oct 1, 2021 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@luisenp
Copy link
Contributor

luisenp commented Oct 1, 2021

馃殌 Feature Request

Add a batch dimension to all operations in ModelEnv.evaluate_action_sequences so that it can find rewards for several trajectories in parallel, each starting at a different observation.

This issue depends on #131, so if that one is open, it'd be better to start with that one first.

Motivation

The current implementation of ModelEnv.evaluate_action_sequences only supports one observation at a time, which means that it's not possible to evaluate several environments in parallel, wasting GPU parallelization of the model rollouts.

Pitch

Add batch support (in term of possible initial states) to all operations involved in ModelEnv.evaluate_action_sequences, and aggregate particles correctly, so that the return is a set of total rewards batched for each initial observation.

@luisenp luisenp added enhancement New feature or request good first issue Good for newcomers labels Oct 1, 2021
@luisenp luisenp added this to the v0.2.0 milestone Oct 1, 2021
@luisenp luisenp pinned this issue Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant