{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":392055467,"defaultBranch":"main","name":"fbpcs","ownerLogin":"facebookresearch","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-08-02T18:32:46.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/16943930?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716639432.0","currentOid":""},"activityList":{"items":[{"before":"d09c043c178b197eb653b1653a7fc4f6245eb5ec","after":"5e2476d483f2980ec8b8ca6b26cd0780ee581730","ref":"refs/heads/main","pushedAt":"2024-05-22T00:29:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"suppress errors in `fbpcs`\n\nDifferential Revision: D57543268\n\nfbshipit-source-id: 0f641064fdd0fd4469f4855f9e93b47fa0bca72d","shortMessageHtmlLink":"suppress errors in <code>fbpcs</code>"}},{"before":"d538899ecc8c5a8ab95fa23f2b251af79befcef3","after":"d09c043c178b197eb653b1653a7fc4f6245eb5ec","ref":"refs/heads/main","pushedAt":"2024-05-17T23:13:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in fbmeshd/rnl/tests/NetlinkSocketTest.cpp (#2405)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2405\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D57344008\n\nfbshipit-source-id: b5f906e2d4c922590286ab5ecd4df12a3e070075","shortMessageHtmlLink":"Remove unused variables in fbmeshd/rnl/tests/NetlinkSocketTest.cpp (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2301500570\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2405\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2405/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2405\">#…</a>"}},{"before":"5b83e912f8f856d583388a1e95056899694c3888","after":"d538899ecc8c5a8ab95fa23f2b251af79befcef3","ref":"refs/heads/main","pushedAt":"2024-05-17T17:42:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/fbpcs` - batch 1 (#2403)\n\nSummary: Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2403\n\nReviewed By: joe1234wu\n\nDifferential Revision: D57183290\n\nfbshipit-source-id: b00995058e1e232086b15ab7d1aa9d4872442c0d","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/fbpcs</code> - batch 1 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2293876698\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2403\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2403/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2403\">#2403</a>)"}},{"before":"d4bd068bab0a577fc85b61b8bf47e221579a4945","after":"5b83e912f8f856d583388a1e95056899694c3888","ref":"refs/heads/main","pushedAt":"2024-05-16T23:45:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix vulnerability in tqdm dependency (#2404)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2404\n\nAutomated checkup noticed that this repo is using a version of tqdm with a known security vulnerability:  P1230616905. Moreover, D57063468 changes to the new version in fbpcp and comments indicate that these versions should be kept in sync.\n\nReviewed By: ankushksingh, joe1234wu\n\nDifferential Revision: D57464049\n\nfbshipit-source-id: e8c25efb490a66a4404571c909db6164b994fdd8","shortMessageHtmlLink":"Fix vulnerability in tqdm dependency (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2301495637\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2404\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2404/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2404\">#2404</a>)"}},{"before":"b73508e699f268d43f715608070a1f3bbe2e1228","after":"d4bd068bab0a577fc85b61b8bf47e221579a4945","ref":"refs/heads/main","pushedAt":"2024-05-15T22:02:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix minor grammar error and link LICENSE file. (#2352)\n\nSummary:\nNoticed a minor grammatical error and also linked the LICENSE file.\n\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2352\n\nReviewed By: Pradeepnitw, joe1234wu, wenhaizhu, jinxinl22\n\nDifferential Revision: D57394126\n\nPulled By: wuman\n\nfbshipit-source-id: 143bbc466f7833a575bc8da226e0c37a59973261","shortMessageHtmlLink":"Fix minor grammar error and link LICENSE file. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1948577723\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2352\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2352/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2352\">#2352</a>)"}},{"before":"78f629e7612aa7cd64767309e1fd6e3e38babb5a","after":"b73508e699f268d43f715608070a1f3bbe2e1228","ref":"refs/heads/main","pushedAt":"2024-05-08T20:35:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Delete Smart agent server skeleton in fbpcs (#2402)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2402\n\nSmart agent was't release to production but we changed to tee-pl solution.\nthus this MPC solution is safe to delete and smart agent is never productionized and used in production code.\nCleaning up Smart agent from build onedocker\n\nDifferential Revision: D57120508\n\nfbshipit-source-id: 32ba9983913642edc9637e46a358d5e56ba92400","shortMessageHtmlLink":"Delete Smart agent server skeleton in fbpcs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286259169\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2402\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2402/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2402\">#2402</a>)"}},{"before":"59b31ebea9aee8072775ab06777a479053bf9651","after":"78f629e7612aa7cd64767309e1fd6e3e38babb5a","ref":"refs/heads/main","pushedAt":"2024-05-08T03:50:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix typos (#2354)\n\nSummary: Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2354\n\nReviewed By: joe1234wu\n\nDifferential Revision: D57087950\n\nPulled By: wuman\n\nfbshipit-source-id: 5b95800ae8d32943adfdf0fcd397e34dfa25ed62","shortMessageHtmlLink":"Fix typos (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1961385247\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2354\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2354/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2354\">#2354</a>)"}},{"before":"e5e9876ca44c7ae6953819653ab886255d68fd6d","after":"59b31ebea9aee8072775ab06777a479053bf9651","ref":"refs/heads/main","pushedAt":"2024-05-07T23:59:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Delete Smart agent from build onedocker (#2401)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2401\n\nSmart agent was't release to production but we changed to tee-pl solution.\nthus this MPC solution is safe to delete and smart agent is never productionized and used in production code.\n\nCleaning up Smart agent from build onedocker\n\nReviewed By: wenhaizhu\n\nDifferential Revision: D57077666\n\nfbshipit-source-id: c616fb7b08351d7972088902d44829d8983eae66","shortMessageHtmlLink":"Delete Smart agent from build onedocker (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2284339171\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2401\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2401/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2401\">#2401</a>)"}},{"before":"4bd49527e643d839e69bfed79c8fce89a92ec4eb","after":"e5e9876ca44c7ae6953819653ab886255d68fd6d","ref":"refs/heads/main","pushedAt":"2024-05-07T23:47:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"ci: Use GITHUB_OUTPUT envvar instead of set-output command (#2368)\n\nSummary:\n`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).\n\nThis PR updates the usage of `set-output` to `$GITHUB_OUTPUT`\n\nInstructions for envvar usage from GitHub docs:\n\nhttps://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter\n\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2368\n\nReviewed By: wenhaizhu\n\nDifferential Revision: D57079874\n\nPulled By: joe1234wu\n\nfbshipit-source-id: 5800df3da7d9e5c3dd4c3d738141656d8f45b59b","shortMessageHtmlLink":"ci: Use GITHUB_OUTPUT envvar instead of set-output command (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2089059731\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2368\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2368/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2368\">#2368</a>)"}},{"before":"ff6b1483992ba0587f0e85c845b034d26cecd878","after":"4bd49527e643d839e69bfed79c8fce89a92ec4eb","ref":"refs/heads/main","pushedAt":"2024-05-07T23:39:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Delete Smart agent package in B&R extract/upload script\n\nSummary:\nSmart agent was't release to production but we changed to tee-pl solution.\nthus this MPC solution is safe to delete and smart agent is never productionized and used in production code.\n\nCleaning up the unused code in MPC B&R extract/upload script\n\nReviewed By: wenhaizhu\n\nDifferential Revision: D57076695\n\nfbshipit-source-id: 2bbd745fc5cc05d07fab6e46760a89005b4e799a","shortMessageHtmlLink":"Delete Smart agent package in B&amp;R extract/upload script"}},{"before":"84b91cee2d8091799caedae66e8eb922111d7c2d","after":"ff6b1483992ba0587f0e85c845b034d26cecd878","ref":"refs/heads/main","pushedAt":"2024-05-04T14:30:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in fbpcs/emp_games/lift/pcf2_calculator/test/common/LiftCalculator.cpp +1 (#2399)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2399\n\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nRemoving this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje, dmm-fb\n\nDifferential Revision: D56887378\n\nfbshipit-source-id: d7a35af4488adb13efb8b9bf4fab74b78a1ae977","shortMessageHtmlLink":"Remove unused-but-set variables in fbpcs/emp_games/lift/pcf2_calculat…"}},{"before":"a035f09903c711761b3a07d95d6d834eca76ea6d","after":"84b91cee2d8091799caedae66e8eb922111d7c2d","ref":"refs/heads/main","pushedAt":"2024-04-14T18:34:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Apply clang-format 18\n\nSummary: Previously this code conformed from clang-format 12.\n\nReviewed By: igorsugak\n\nDifferential Revision: D56065247\n\nfbshipit-source-id: f5a985dd8f8b84f2f9e1818b3719b43c5a1b05b3","shortMessageHtmlLink":"Apply clang-format 18"}},{"before":"2368e5dec2942faa4f98375bdde692358632e002","after":"a035f09903c711761b3a07d95d6d834eca76ea6d","ref":"refs/heads/main","pushedAt":"2024-04-12T05:35:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in fbpcs/emp_games/lift/pcf2_calculator/test/common/LiftCalculator.cpp (#2398)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2398\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D56022428\n\nfbshipit-source-id: 56074bd3d9cbfcc91c97072bbe50b8e306ff3afe","shortMessageHtmlLink":"Remove unused variables in fbpcs/emp_games/lift/pcf2_calculator/test/…"}},{"before":"d190aa6ca565631d014a03414d5afa2f1aa9f3cd","after":"2368e5dec2942faa4f98375bdde692358632e002","ref":"refs/heads/main","pushedAt":"2024-04-12T05:30:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in fbit/itstorage/data_crawler/thread/ThreadedCrawler.cpp (#2397)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2397\n\nX-link: https://github.com/facebookresearch/fbpcf/pull/538\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D56022415\n\nfbshipit-source-id: 65aa2b310e39ff134bf6dd8a82e3a539c3033660","shortMessageHtmlLink":"Remove unused variables in fbit/itstorage/data_crawler/thread/Threade…"}},{"before":"7a3e8985b1f0f580f2bfc57f0d2f204d9ab28196","after":"d190aa6ca565631d014a03414d5afa2f1aa9f3cd","ref":"refs/heads/main","pushedAt":"2024-03-23T23:13:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Migrate google java format from 1.7 -> 1.21.0\n\nSummary:\nX-link: https://github.com/facebookexternal/OculusManufacturing/pull/524\n\nX-link: https://github.com/facebookexternal/fbpay/pull/3\n\nX-link: https://github.com/facebook/screenshot-tests-for-android/pull/324\n\nX-link: https://github.com/pytorch/executorch/pull/1771\n\nX-link: https://github.com/facebook/igl/pull/68\n\nX-link: https://github.com/facebook/mariana-trench/pull/153\n\nX-link: https://github.com/facebook/fresco/pull/2757\n\nX-link: https://github.com/facebook/litho/pull/974\n\nX-link: https://github.com/facebook/react-native/pull/42754\n\nX-link: https://github.com/facebook/hhvm/pull/9431\n\nX-link: https://github.com/WhatsApp/eqwalizer/pull/52\n\nX-link: https://github.com/facebookincubator/spectrum/pull/1858\n\nX-link: https://github.com/fbsamples/metapay/pull/1\n\nX-link: https://github.com/facebookincubator/fbjni/pull/95\n\nX-link: https://github.com/facebookincubator/Battery-Metrics/pull/30\n\nX-link: https://github.com/facebook/ktfmt/pull/440\n\nX-link: https://github.com/facebook/flipper/pull/5456\n\nX-link: https://github.com/facebook/hermes/pull/1290\n\nX-link: https://github.com/facebook/TextLayoutBuilder/pull/35\n\nX-link: https://github.com/facebook/SoLoader/pull/122\n\nallow-large-files\n\nThis diff migrates google java format form 1.7 to 1.21.0. This update will allow for new language features from java 17 and 21. This diff also formats all necessary files.\n\n Changelog:\n    [Internal][Changed] - Updated format from google-java-format 1.7 -> 1.21.0\n\nReviewed By: IanChilds\n\nDifferential Revision: D52786052\n\nfbshipit-source-id: b675ae215084f340b93dfe628e329e696ca0616e","shortMessageHtmlLink":"Migrate google java format from 1.7 -&gt; 1.21.0"}},{"before":"c8e3049d3801881d15781267038a1a83ae7f479a","after":"7a3e8985b1f0f580f2bfc57f0d2f204d9ab28196","ref":"refs/heads/main","pushedAt":"2024-03-20T19:37:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in fboss/agent/state/Interface.cpp\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: peygar\n\nDifferential Revision: D55099975\n\nfbshipit-source-id: c4c4d45c215f0bf401a9795121fd75bca9bad6d2","shortMessageHtmlLink":"Remove unused variables in fboss/agent/state/Interface.cpp"}},{"before":null,"after":"9d563a26320a474c3cdd11fa2343e6e28f3ca917","ref":"refs/heads/export-D55099975","pushedAt":"2024-03-20T16:59:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in fboss/agent/state/Interface.cpp\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: peygar\n\nDifferential Revision: D55099975","shortMessageHtmlLink":"Remove unused variables in fboss/agent/state/Interface.cpp"}},{"before":"654b508a078eef1dc95a11042eba4ec188891095","after":"c8e3049d3801881d15781267038a1a83ae7f479a","ref":"refs/heads/main","pushedAt":"2024-03-11T20:52:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Final big migration push [7/22] (#2394)\n\nSummary: Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2394\n\nReviewed By: kinto0\n\nDifferential Revision: D54731232\n\nfbshipit-source-id: 2cf2afd0037c164c530531a453152d3d1747eb09","shortMessageHtmlLink":"Final big migration push [7/22] (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2179942439\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2394\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2394/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2394\">#2394</a>)"}},{"before":"ffdca9ddd311fc968e68907a3ba311be9ac9b46d","after":"654b508a078eef1dc95a11042eba4ec188891095","ref":"refs/heads/main","pushedAt":"2024-03-03T01:43:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"apply Black 2024 style in fbcode (8/16)\n\nSummary:\nFormats the covered files with pyfmt.\n\npaintitblack\n\nReviewed By: aleivag\n\nDifferential Revision: D54447737\n\nfbshipit-source-id: 6c05d7941c6b4f1787b8da6cf810693f48a96c4e","shortMessageHtmlLink":"apply Black 2024 style in fbcode (8/16)"}},{"before":"bd00e80a27445e4f5b1ec49910523d78656dd60a","after":"ffdca9ddd311fc968e68907a3ba311be9ac9b46d","ref":"refs/heads/main","pushedAt":"2024-02-09T17:09:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fbcode//fbpcs (#2393)\n\nSummary: Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2393\n\nDifferential Revision: D53602708\n\nfbshipit-source-id: dfc67efa6e05b57d531f11c32dfa656e8d3fc020","shortMessageHtmlLink":"fbcode//fbpcs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2127056651\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2393\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2393/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2393\">#2393</a>)"}},{"before":"784772c7e21d9b166329a3e2c9f3e33ba964c8bc","after":"bd00e80a27445e4f5b1ec49910523d78656dd60a","ref":"refs/heads/main","pushedAt":"2024-02-06T21:40:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Upgrading fast api version (#2392)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2392\n\n# Context\nAs PC oncall, received an alert that github has detected security vulnerability in fast api dependency.\n\n# Changes\nIn this diff, upgrading fast api version to one recommended by github.\n\nReviewed By: joe1234wu\n\nDifferential Revision: D53487969\n\nfbshipit-source-id: 071637b09c7ad73b2bcd1bb1dd508acf47860ceb","shortMessageHtmlLink":"Upgrading fast api version (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2121658735\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2392\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2392/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2392\">#2392</a>)"}},{"before":"299a80ca49f0d13f5323291ff42896fddf2fe87a","after":"0594d69f237ff5932be1e34d8cf1e249edb89f98","ref":"refs/heads/export-D53487969","pushedAt":"2024-02-06T21:10:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ajinkya-ghonge","name":null,"path":"/ajinkya-ghonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15918953?s=80&v=4"},"commit":{"message":"Upgrading fast api version (#2392)\n\nSummary:\n\n# Context\nAs PC oncall, received an alert that github has detected security vulnerability in fast api dependency.\n\n# Changes\nIn this diff, upgrading fast api version to one recommended by github.\n\nReviewed By: joe1234wu\n\nDifferential Revision: D53487969","shortMessageHtmlLink":"Upgrading fast api version (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2121658735\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2392\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2392/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2392\">#2392</a>)"}},{"before":null,"after":"299a80ca49f0d13f5323291ff42896fddf2fe87a","ref":"refs/heads/export-D53487969","pushedAt":"2024-02-06T21:01:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Upgrading fast api version\n\nSummary:\n# Context\nAs PC oncall, received an alert that github has detected security vulnerability in fast api dependency.\n\n# Changes\nIn this diff, upgrading fast api version to one recommended by github.\n\nDifferential Revision: D53487969","shortMessageHtmlLink":"Upgrading fast api version"}},{"before":"23ee45b8bc0057007f0d3363e84ff3e2b8d73d61","after":"784772c7e21d9b166329a3e2c9f3e33ba964c8bc","ref":"refs/heads/main","pushedAt":"2024-02-05T19:15:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Bump GRAPHAPI_DEFAULT_VERSION to v19.0 (#2391)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2391\n\nCurrently we use v17.0 which will be deprecated in May 2024: https://developers.facebook.com/docs/graph-api/changelog/, It would be nice to bump the api version by the next cb release in March\n\nReviewed By: chennyc\n\nDifferential Revision: D53434390\n\nfbshipit-source-id: 16eba1e9fbf22e5b9d13c660b73adf60a67e0d59","shortMessageHtmlLink":"Bump GRAPHAPI_DEFAULT_VERSION to v19.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2119248378\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2391\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2391/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2391\">#2391</a>)"}},{"before":"b79df0979f80fdb756a73a8752ca63fa34957e67","after":"23ee45b8bc0057007f0d3363e84ff3e2b8d73d61","ref":"refs/heads/main","pushedAt":"2024-02-05T19:07:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Adding lambda get function for PC prevalidation KIA lambda check (#2390)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2390\n\nCurrently, our cb instance is not supporting kia_service status checking, and it'll display the error as below when we fetch the kia_service from our smart platform:\n\"Failed to fetch Lambda status during resource check.\nError: User: arn:aws:sts::046312032962:assumed-role/vg-onebox-111-feb2-ConversionsApiGatewayIamRole-toCtIrRgJBMz/i-0de4416bd949ed716 is not authorized to perform: lambda:GetFunction on resource: arn:aws:lambda:us-west-2:046312032962:function:cb-kia-5ujbtee-t0ug because no identity-based policy allows the lambda:GetFunction action (Service: AWSLambda; Status Code: 403; Error Code: AccessDeniedException; Request ID: 2199e72e-a5c4-4dc0-bef1-47fb848a9e04; Proxy: null)\"\nTo resolve this issue, we can add lambda:GetFunction to the existing I AM policy.\n\nReviewed By: jinxinl22, chennyc\n\nDifferential Revision: D53434002\n\nfbshipit-source-id: 02e472e1cb4e672b072d0356d59292f61ea6a7c5","shortMessageHtmlLink":"Adding lambda get function for PC prevalidation KIA lambda check (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2119225491\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2390\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2390/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2390\">#2390</a>)"}},{"before":"060698709c8356ce25931c24253c48829d874fc7","after":"b79df0979f80fdb756a73a8752ca63fa34957e67","ref":"refs/heads/main","pushedAt":"2024-02-05T19:00:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"enable pyre-strict lint rule in test_update_generic_hook.py (#2389)\n\nSummary:\nPull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2389\n\nenable pyre-strict lint rule and silence the type errors that arise from doing so\n\nReviewed By: joe1234wu\n\nDifferential Revision: D53432969\n\nfbshipit-source-id: a419d9632b2fc171d91dba2d5909fca796429e2c","shortMessageHtmlLink":"enable pyre-strict lint rule in test_update_generic_hook.py (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2119179125\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2389\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2389/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2389\">#2389</a>)"}},{"before":"6c857dc8747c3abb5cb940714752ff46589d1091","after":"b17df232c03fbdac11806bb7af9c56ae4043e0f6","ref":"refs/heads/export-D53434390","pushedAt":"2024-02-05T18:53:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ztlbells","name":null,"path":"/ztlbells","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17512760?s=80&v=4"},"commit":{"message":"Bump GRAPHAPI_DEFAULT_VERSION to v19.0 (#2391)\n\nSummary:\n\nCurrently we use v17.0 which will be deprecated in May 2024: https://developers.facebook.com/docs/graph-api/changelog/, It would be nice to bump the api version by the next cb release in March\n\nDifferential Revision: D53434390","shortMessageHtmlLink":"Bump GRAPHAPI_DEFAULT_VERSION to v19.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2119248378\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookresearch/fbpcs/issues/2391\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookresearch/fbpcs/pull/2391/hovercard\" href=\"https://github.com/facebookresearch/fbpcs/pull/2391\">#2391</a>)"}},{"before":null,"after":"6c857dc8747c3abb5cb940714752ff46589d1091","ref":"refs/heads/export-D53434390","pushedAt":"2024-02-05T18:52:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Bump GRAPHAPI_DEFAULT_VERSION to v19.0\n\nSummary: Currently we use v17.0 which will be deprecated in May 2024: https://developers.facebook.com/docs/graph-api/changelog/, It would be nice to bump the api version by the next cb release in March\n\nDifferential Revision: D53434390","shortMessageHtmlLink":"Bump GRAPHAPI_DEFAULT_VERSION to v19.0"}},{"before":"118cbce6838fec83ecb788e63d9457fec7ae0690","after":"2a91bd4340cf786bcf02ba98dc07b3efb0113de6","ref":"refs/heads/export-D53434002","pushedAt":"2024-02-05T18:40:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ankushksingh","name":null,"path":"/ankushksingh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/94140580?s=80&v=4"},"commit":{"message":"Adding lambda get function for PC prevalidation KIA lambda check\n\nSummary:\nCurrently, our cb instance is not supporting kia_service status checking, and it'll display the error as below when we fetch the kia_service from our smart platform:\n\"Failed to fetch Lambda status during resource check.\nError: User: arn:aws:sts::046312032962:assumed-role/vg-onebox-111-feb2-ConversionsApiGatewayIamRole-toCtIrRgJBMz/i-0de4416bd949ed716 is not authorized to perform: lambda:GetFunction on resource: arn:aws:lambda:us-west-2:046312032962:function:cb-kia-5ujbtee-t0ug because no identity-based policy allows the lambda:GetFunction action (Service: AWSLambda; Status Code: 403; Error Code: AccessDeniedException; Request ID: 2199e72e-a5c4-4dc0-bef1-47fb848a9e04; Proxy: null)\"\nTo resolve this issue, we can add lambda:GetFunction to the existing I AM policy.\n\nDifferential Revision: D53434002","shortMessageHtmlLink":"Adding lambda get function for PC prevalidation KIA lambda check"}},{"before":null,"after":"118cbce6838fec83ecb788e63d9457fec7ae0690","ref":"refs/heads/export-D53434002","pushedAt":"2024-02-05T18:39:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Adding lambda get function for PC prevalidation KIA lambda check\n\nSummary:\nCurrently, our cb instance is not supporting kia_service status checking, and it'll display the error as below when we fetch the kia_service from our smart platform:\n\"Failed to fetch Lambda status during resource check.\nError: User: arn:aws:sts::046312032962:assumed-role/vg-onebox-111-feb2-ConversionsApiGatewayIamRole-toCtIrRgJBMz/i-0de4416bd949ed716 is not authorized to perform: lambda:GetFunction on resource: arn:aws:lambda:us-west-2:046312032962:function:cb-kia-5ujbtee-t0ug because no identity-based policy allows the lambda:GetFunction action (Service: AWSLambda; Status Code: 403; Error Code: AccessDeniedException; Request ID: 2199e72e-a5c4-4dc0-bef1-47fb848a9e04; Proxy: null)\"\nTo resolve this issue, we can add lambda:GetFunction to the existing I AM policy.\n\nDifferential Revision: D53434002","shortMessageHtmlLink":"Adding lambda get function for PC prevalidation KIA lambda check"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUGQ8XAA","startCursor":null,"endCursor":null}},"title":"Activity · facebookresearch/fbpcs"}