Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

display_examples doesn't work with dynamic_batching #3218

Open
wyshi opened this issue Oct 22, 2020 · 2 comments
Open

display_examples doesn't work with dynamic_batching #3218

wyshi opened this issue Oct 22, 2020 · 2 comments

Comments

@wyshi
Copy link
Contributor

wyshi commented Oct 22, 2020

when having both --display_examples True and --dynamic-batching full,

line 547, in display_messages
    agent_id = msg.get("id", "[no id field]")
AttributeError: 'list' object has no attribute 'get'

I pdbed, it's because msg is a list of dictionaries instead of a dictionary in here
https://github.com/facebookresearch/ParlAI/blob/master/parlai/utils/misc.py#L554

Describe the solution you'd like
I think it should be an easy fix? just check if it's dynamic batching, and add another full loop? so that we could have both both --display_examples True and --dynamic-batching full

@github-actions
Copy link

This issue has not had activity in 30 days. Please feel free to reopen if you have more issues. You may apply the "never-stale" tag to prevent this from happening.

@stephenroller
Copy link
Contributor

This is on the roadmap for H1 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants