Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables with zero-value should include unit #274

Open
fflaten opened this issue Sep 3, 2022 · 1 comment
Open

Variables with zero-value should include unit #274

fflaten opened this issue Sep 3, 2022 · 1 comment

Comments

@fflaten
Copy link

fflaten commented Sep 3, 2022

Zero-valued variables should always include a unit to be compatible with min/max/calc functions.
Ex. --ifm-footer-padding-horizontal: 0 set in a default media-query will not work atm. Overriding to 0px fixes it.

@fflaten fflaten changed the title Variables with zero should include unit Variables with zero-value should include unit Sep 3, 2022
@slorber
Copy link
Collaborator

slorber commented Sep 7, 2022

seems correct: no unit seems to make it hard to use in CSS functions.

We could always include a unit for consistency.

Also worth taking a look at the direction of CSS, maybe this will be easier in the future?

For example https://www.bram.us/2022/07/08/the-future-of-css-variable-units-powered-by-custom-properties/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants