Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent design and incorrect colors in dark mode #192

Open
armano2 opened this issue Dec 5, 2021 · 2 comments
Open

Inconsistent design and incorrect colors in dark mode #192

armano2 opened this issue Dec 5, 2021 · 2 comments

Comments

@armano2
Copy link

armano2 commented Dec 5, 2021

there seem to be an inconstancy in use of borders / background colors between dark and light mode

most elements in dark mode use background color
most elements in light mode use border

"most" as there is no consistency,


search icon in dark mode doesn't adapt to dark mode

image
image


header has no borders (shadow) in dark mode, but uses different background color from content

eg, side panel has --ifm-toc-border-color: var(--ifm-color-emphasis-300); for both dark and light mode

image image


badges do not adapt text color between dark and light mode

image image


shadows are close to invisible in dark mode #187

image


cards use background color in dark mode and border in light

image image

@Async10
Copy link

Async10 commented Dec 16, 2021

I'm not a maintainer here nor a designer but pretty much everything you crititque seems fine to me. You can't work with shadows in dark mode that is why they use different color variations for contrast to achieve the separation of different areas or elements. Why would the text color on a badge change in dark mode need to change? The background color of the badge stays the same, so the text color has to for contrast and readability.

@armano2
Copy link
Author

armano2 commented Dec 16, 2021

Why would the text color on a badge change in dark mode need to change?

to make it consistent with other elements, eg, buttons adjust font color when in dark mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants