Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Question: does this work Sapling? #150

Open
hacker-DOM opened this issue Nov 16, 2022 · 3 comments
Open

Question: does this work Sapling? #150

hacker-DOM opened this issue Nov 16, 2022 · 3 comments

Comments

@hacker-DOM
Copy link

So I'm playing around with Sapling and while I really like the interface, there are times when having tools like lazygit or gitui is a plus. So I found this tool. I was wondering if it has support for .sl :-)

@bigfootjon
Copy link
Contributor

Are you asking if Sapling can be a source or destination repo with FBShipIt? It could but it doesn't right now. We detect the repo type based on the presence of a .git or .hg in the root. Since Sapling repos have .sl instead ShipIt will crash as it can't determine the type of repo.

I'll follow up with @bolinfest and figure out how complex it would be to support this. AIUI we're already using Sapling internally but for legacy reasons it continues to use the .hg folder name and hg binary name so our detection method and executing shell commands still works.

@bolinfest
Copy link
Contributor

[open source] Sapling does not acknowledge an .hg folder. We did a considerable amount of work to ensure users can have Mercurial and Sapling installed side-by-side such that they don't interfere with one another.

Currently, the presence of an .sl folder means it is a Sapling working copy, but you have to peek inside the .sl/config folder to see what "type" of repository it is. In practice, the repository is inevitably a Git repository because we haven't made the Sapling server "available" (well, the code is on GitHub, but it's a lot of work to set one up...).

If you want to do Git things "sometimes" when using Sapling, you likely have to git clone the repo and do the work over there. Not great, but that's the situation.

Meanwhile, I know evolving Sapling's existing UI into a TUI is something folks on the team are interested in. In general, I think we're more interested in improving the UX of Sapling rather than try to support more and more Git tools within Sapling.

@bigfootjon
Copy link
Contributor

Thanks!

Ok since OSS Sapling is still just a way to clone an existing git repo I think I'm going to say we're not going to support Sapling repos, yet. When the day comes that Sapling Server is ready for OSS we can re-evaluate then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants