From fcad36b06f5394375afe0d85f717004e448607db Mon Sep 17 00:00:00 2001 From: Konstantin Raev Date: Wed, 12 Oct 2016 04:36:06 -0700 Subject: [PATCH] Integrated generic install-node-modules for React Native Summary: Wacky nodeModules.js is replaced with install-node-modules.js. A few concerns to address: - I did not make it a `hg mv nodeModules.js ..../install-node-modules.js` because I want to start with clean-ish slate and have a good peer review to the script - I did not want to use external dependencies for install-node-modules.js because I want this script to startup as fast as possible and don't want to either check in its dependencies or use yarn to install them. Otherwise I would use shell.js, node-fetch and optimist, still an option if this script proves to be a hassle to support Things to come: - hook up jsbuddy and flow on install-node-modules.js - https://github.com/yarnpkg/yarn/issues/576 - https://github.com/yarnpkg/yarn/issues/569 - https://github.com/yarnpkg/yarn/issues/570 Usage for fbsource projects: ``` fbcode/react_native/kpm/wrapper/install-node-modules.sh fbsource/.../js-project ``` Reviewed By: yungsters Differential Revision: D3996416 fbshipit-source-id: 078b2ca5c076c2c6e2e7209945e59aaa31ebc4aa --- fb-examples/bin/shipit_react-native.php-example | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fb-examples/bin/shipit_react-native.php-example b/fb-examples/bin/shipit_react-native.php-example index eeb00f43..b0c6acd1 100644 --- a/fb-examples/bin/shipit_react-native.php-example +++ b/fb-examples/bin/shipit_react-native.php-example @@ -36,7 +36,7 @@ final class ShipItReactNative extends FBShipItCLI { ImmVector { '@(^|/)node_modules/@', '@(^|/)npm-shrinkwrap.json@', - '@(^|/)fbkpm.lock@', + '@(^|/)yarn.lock@', '@(^|/)packager/react-packager/src/packager_experimental/@', }, )