Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't create ZSTDMT_CCtx if number of cores > 128 #760

Closed
rgdoliveira opened this issue Jul 13, 2017 · 3 comments
Closed

can't create ZSTDMT_CCtx if number of cores > 128 #760

rgdoliveira opened this issue Jul 13, 2017 · 3 comments

Comments

@rgdoliveira
Copy link

I'm compiling zstd in a Powerpc machine (ppc64le) and it builds fine, but when I try to run the test suite it fails with the following error:
"zstd: error 30 : allocation error : can't create ZSTDMT_CCtx"

zstd defines the max number of cores as 128 (ZSTDMT_NBTHREADS_MAX 128) but the Power machine I'm using has 160 cores and the test break.

In this case I guess the execution should continue and use the max number of cores instead of breaking it.
rgdoliveira added a commit to rgdoliveira/aports that referenced this issue Jul 13, 2017
@rgdoliveira
community/zstd: fix tests in ppc64le
a3d5bba 
some zstd tests are breaking in ppc64le because it defines the max
number of supported cores as 128 (ZSTDMT_NBTHREADS_MAX 128) but the
Alpine ppc64le machine has 160 cores.

I am increasing the max core value to 256 for now and opened a bug[1]
in zstd project.

[1] facebook/zstd#760
rgdoliveira added a commit to rgdoliveira/aports that referenced this issue Jul 13, 2017
@rgdoliveira
community/zstd: fix tests in ppc64le
eee0dfb 
some zstd tests are breaking in ppc64le because it defines the max
number of supported cores as 128 (ZSTDMT_NBTHREADS_MAX 128) but the
Alpine ppc64le machine has 160 cores.

I am increasing the max core value to 256 for now and opened a bug[1]
in zstd project.

[1] facebook/zstd#760
@rgdoliveira rgdoliveira mentioned this issue Jul 13, 2017
Closed
@Cyan4973
Copy link
Contributor

That's a good point @rgdoliveira !

Cyan4973 added a commit that referenced this issue Jul 13, 2017
@Cyan4973
policy change : ZSTDMT automatically caps nbThreads to ZSTDMT_NBTHREA…
3a60efd 
…DS_MAX (#760)

Previously, ZSTDMT would refuse to create the compressor.
Also : increased ZSTDMT_NBTHREADS_MAX to 256,
updated doc,
and added relevant test
@Cyan4973
Copy link
Contributor

I modified the version in dev branch to accept up to 256 threads.
It will also automatically cap to this new limit when requested more than this value, instead of triggering an error as you experienced.

algitbot pushed a commit to alpinelinux/aports that referenced this issue Jul 13, 2017
@rgdoliveira @ncopa
community/zstd: fix tests in ppc64le
f9f234d 
some zstd tests are breaking in ppc64le because it defines the max
number of supported cores as 128 (ZSTDMT_NBTHREADS_MAX 128) but the
Alpine ppc64le machine has 160 cores.

I am increasing the max core value to 256 for now and opened a bug[1]
in zstd project.

[1] facebook/zstd#760
Cyan4973 added a commit that referenced this issue Jul 13, 2017
@Cyan4973
updated NEWS regarding #760
6733c07
@rgdoliveira
Copy link
Author

thanks @Cyan4973, As this issue is fixed in dev branch and I guess it will be part of a future zstd release, I'm closing this issue.

@Cyan4973 Cyan4973 mentioned this issue Aug 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cyan4973 @rgdoliveira