Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to support vertical writing modes in modern browsers #512

Open
nmn opened this issue Mar 31, 2024 Discussed in #510 · 0 comments
Open

Add option to support vertical writing modes in modern browsers #512

nmn opened this issue Mar 31, 2024 Discussed in #510 · 0 comments

Comments

@nmn
Copy link
Contributor

nmn commented Mar 31, 2024

logical properties like inlineSize and blockSize to width and height in the final bundled CSS file

Discussed in #510

Originally posted by mobalti March 29, 2024
I noticed that Stylex converts certain logical properties like inlineSize and blockSize to width and height in the final bundled CSS file. I'm curious about the rationale behind this behavior. Is there a way to prevent this while retaining the logical properties?

Although I'm aware of Stylex's capability to efficiently manage variables through tokens.stylex, in this particular case, I've opted to use Open Props V2. My main objective here is to become acquainted with Stylex's API. Would there be any performance implications if I import variables from a global.css file, as I've done in this example, instead of using stylex.token.ts?"

Overall, I find the library to be solid, just as I expected. Thanks to the entire team for their work!

https://stackblitz.com/~/github.com/mobalti/open-props-v2-stylex-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant