chore: Add cjs to rollup-plugin #538
Conversation
|
Hi @VojGin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Needing |
What changed / motivation ?
I had came to a need of stylex rollup-plugin in the cjs flavor. See this issue for relevant context. #451
So I added it. My PR is very much inspired by the current implementation in
packages/styles/package.jsonLinked PR/Issues
Fixes #451
Additional Context
The rollup-plugin now generates
lib/*andlib/es/*folders. See screenshot:I had run all the tests and lints. But as I'm unfamiliar with the repository. I'd gladly ask for a double check that I didn't break anything vital. 馃檹
What I have manually tested:
lib/es/index.mjsis identical with the oldlib/index.jsTagging @nmn as a follow-up to our discussion
Pre-flight checklist
Contribution Guidelines