Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: build stylex on rollup watch mode #363

Open
shaxutang opened this issue Jan 19, 2024 · 3 comments · May be fixed by #365
Open

[bug]: build stylex on rollup watch mode #363

shaxutang opened this issue Jan 19, 2024 · 3 comments · May be fixed by #365
Labels
bug Something isn't working

Comments

@shaxutang
Copy link

Describe the issue

I defined a set of variables via stylex
image
Then I build via rollup, below is my configuration
image
dev scripts:
image
When in rollup development mode, the style packaging is normal when building for the first time, and the defined variables can be output correctly.
image
But when I modify the file, the variable disappears
image

Expected behavior

The style output in rollup watch mode contains defined variables

Steps to reproduce

  1. clone https://github.com/shaxutang/sx-theme.git
  2. pnpm install
  3. pnpm dev
  4. check the dist/esm/index.css file, the variable exists at this time
  5. Modify the style content in the src/button.ts file
  6. check the dist/esm/index.css file again. At this time, the variable has no output.

Test case

No response

Additional comments

No response

@shaxutang shaxutang added the bug Something isn't working label Jan 19, 2024
@nonzzz
Copy link
Contributor

nonzzz commented Jan 19, 2024

Can this task be assigned to me?

@nonzzz nonzzz linked a pull request Jan 19, 2024 that will close this issue
2 tasks
@jonnitto
Copy link

jonnitto commented Mar 14, 2024

There is a similar issue with the esbuild plugin. Sometimes, the variables, just don't get writting

@nmn
Copy link
Contributor

nmn commented Mar 16, 2024

Do you have treeshakeCompensation: true set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants