Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add units to css custom properties #9963

Closed
TrySound opened this issue Jun 14, 2017 · 6 comments
Closed

Do not add units to css custom properties #9963

TrySound opened this issue Jun 14, 2017 · 6 comments

Comments

@TrySound
Copy link
Contributor

Do you want to request a feature or report a bug?

bug

What is the current behavior?

<div style={{ '--value': 5 }}></div>

becomes

<div style="--value: 5px;"></div>

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).

https://codepen.io/TrySound/pen/MojVOp

What is the expected behavior?

Leave values same as they are passed.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

React 15.6.0

@TrySound TrySound changed the title Do not add units to custom properties Do not add units to css custom properties Jun 14, 2017
@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

Would you like to send a fix? We still have some time before cutting 15.6.1.

@TrySound
Copy link
Contributor Author

Sure.

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

We're looking to cut it at most tomorrow so please let us know if you can't finish it today, and we'll try to fix it.

@TrySound
Copy link
Contributor Author

I'm working on it right now. Will fix today.

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jun 15, 2017

Should be fixed in 15.6.1. Please verify.

@gaearon gaearon closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants