Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to update DOM style attribute #8362

Closed
testerez opened this issue Nov 20, 2016 · 3 comments
Closed

Fail to update DOM style attribute #8362

testerez opened this issue Nov 20, 2016 · 3 comments

Comments

@testerez
Copy link

Do you want to request a feature or report a bug?
bug
What is the current behavior?
style attribute is not updated correctly when we set padding and paddingTop at the same time and then re-render with only padding. Same issue with border. I suppose that it would be the same with margin (not tested)

Example: http://codepen.io/testerez/pen/pNRQjW?editors=0010

What is the expected behavior?
The DOM element style should be the last rendered one and should not be affected by the previous style value.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Tested on chrome 54 with React 15.4 and 15.3.2

@linmic
Copy link

linmic commented Nov 21, 2016

This issue has been reported several times, and currently there's no perfect solution. The latest discussion.

@testerez
Copy link
Author

Ok, thanks for the reply.

@aweary
Copy link
Contributor

aweary commented Nov 21, 2016

Thanks @linmic! Closing as a duplicate of #6348, try and direct any future discussion there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants