Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize build process / tooling #6656

Closed
zpao opened this issue Apr 29, 2016 · 3 comments
Closed

Modernize build process / tooling #6656

zpao opened this issue Apr 29, 2016 · 3 comments

Comments

@zpao
Copy link
Member

zpao commented Apr 29, 2016

This is mostly a prereq of #6655.

Goals:

  • align build tooling (right now mixing grunt & gulp - commit, probably to gulp Switch entirely to gulp #4927)
  • add watching, should be fast to rebuild and test changes in browser
    • could be something like webpack hot reloading
  • move shared tooling back into fbjs (babel plugin, custom lint rule)

Non-goals but things to keep in mind:

  • alternate build approaches, in particular flat bundling - it needs to be easy to swap this in
  • releasing from master - we may want to have development happen such that feature flags are used to turn on/off features. we may want the build result to be a static flag set (no runtime checks) but would need to be possible to target any flag combination easily
@trueadm
Copy link
Contributor

trueadm commented Apr 5, 2017

The work for this has been merged in PR: #9327

@trueadm trueadm closed this as completed Apr 5, 2017
@gaearon
Copy link
Collaborator

gaearon commented Apr 5, 2017

Not sure, I think these are open areas:

  • add watching, should be fast to rebuild and test changes in browser
  • move shared tooling back into fbjs (babel plugin, custom lint rule)

@gaearon
Copy link
Collaborator

gaearon commented Aug 15, 2018

We got rid of fbjs and actually seem to prefer to own our scripts.
As for watching.. seems like it might be complicated with our pipeline. Maybe not worth it.

@gaearon gaearon closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants