Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the right document in iframe selection events #427

Closed
zpao opened this issue Oct 15, 2013 · 3 comments
Closed

Use the right document in iframe selection events #427

zpao opened this issue Oct 15, 2013 · 3 comments
Labels
Component: DOM HTML Type: Bug

Comments

@zpao
Copy link
Member

zpao commented Oct 15, 2013

We use document directly a bunch where that might not be the right thing if the event is occurring in an iframe. We should do it right. (split from #373)
@syranide syranide mentioned this issue Aug 15, 2014
Closed
1 task
@gaearon gaearon added the HTML label Mar 26, 2016
@acusti acusti mentioned this issue Sep 28, 2016
Merged
acusti added a commit to brandcast/react that referenced this issue Oct 4, 2016
@acusti
Avoid global document and window objects, facebook#427
2c2b5ad
This was referenced Oct 4, 2016
Closed
Closed
@acusti acusti mentioned this issue Nov 5, 2016
Closed
acusti added a commit to brandcast/react that referenced this issue Nov 10, 2016
@acusti
Avoid global document and window objects, facebook#427
175ba00
acusti added a commit to brandcast/react that referenced this issue Nov 21, 2016
@acusti
Avoid global document and window objects, facebook#427
b8fcd96
acusti added a commit to brandcast/react that referenced this issue Dec 2, 2016
@acusti
Avoid global document and window objects, facebook#427
36dbf71
acusti added a commit to brandcast/react that referenced this issue Dec 2, 2016
@acusti
Avoid global document and window objects, facebook#427
bd5cb57
acusti added a commit to brandcast/react that referenced this issue Dec 2, 2016
@acusti
Avoid global document and window objects, facebook#427
3fdb1e7
acusti added a commit to brandcast/react that referenced this issue Mar 15, 2017
@acusti
Avoid global document and window objects, facebook#427
d43d532
@acusti acusti mentioned this issue Oct 31, 2017
Closed
@nhunzaker
Copy link
Contributor

@acusti is it possible that this is is now resolved with the merger of #12037?

@acusti
Copy link
Contributor

acusti commented Aug 4, 2018 •
edited

Yes indeed! This issues refers to the previous uses of the global document and window objects in ReactDOMSelection and the SelectEventPlugin.

@nhunzaker
Copy link
Contributor

Woooooo! Cheers to closing a 5 year old issue!!! 🎉🎉🎉🎉

@ryan-ally ryan-ally mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DOM HTML Type: Bug
Projects
None yet
Milestone
No milestone
5 participants
@zpao @acusti @nhunzaker @gaearon @syranide