fix(react-compiler-healthcheck): detect strict mode when using <React.StrictMode/>
#29077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.StrictMode/>` Update the regex to match both `<StrictMode>` and `<React.StrictMode>`. Closes facebook#29075
|
Comparing: 71565a9...25a2b8d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Thanks! Fixed in #29076 |
|
Ah, you beat me to it! Thanks for fixing that @gsathya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the regex to match both
<StrictMode>and<React.StrictMode>.Closes #29075
How did you test this change?
Building and running the check locally against the repo in the issue:
❯ node /home/bat/Documents/Code/react/compiler/packages/react-compiler-healthcheck/dist/index.js Successfully compiled 1 out of 1 components. StrictMode usage found. # <-- successful strictmode detection Found no usage of incompatible libraries.