Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: eslint-plugin-react-hooks optional chaining in deps #19661

Closed
rteixeirax opened this issue Aug 20, 2020 · 5 comments · Fixed by #19680
Closed

Bug: eslint-plugin-react-hooks optional chaining in deps #19661

rteixeirax opened this issue Aug 20, 2020 · 5 comments · Fixed by #19680
Labels
Component: ESLint Rules Type: Bug

Comments

@rteixeirax
Copy link

Packages

  • "react": "^16.13.1"
  • "eslint-plugin-react-hooks": "^4.0.8"

The issue #18819 still happens with eslint-plugin-react-hooks@4.0.8.

Using the example code from the other issue gives the following errors:

image

image
@rteixeirax rteixeirax added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Aug 20, 2020
@gaearon gaearon added Component: ESLint Rules Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Aug 20, 2020
@gaearon
Copy link
Collaborator

gaearon commented Aug 20, 2020

Thanks, would you like to look into a fix?

@pfongkye
Copy link
Contributor

Hi,
I can look into this if no one else is working on it.

@gaearon
Copy link
Collaborator

gaearon commented Aug 20, 2020

Sounds good.

@rteixeirax
Copy link
Author

Thanks @pfongkye.

@pfongkye pfongkye mentioned this issue Aug 24, 2020
Merged
pfongkye pushed a commit to pfongkye/react that referenced this issue Aug 29, 2020
Merge branch 'master' of https://github.com/facebook/react into issue/f…
7174219 
…acebook#19661
@gaearon
Copy link
Collaborator

gaearon commented Sep 10, 2020

eslint-plugin-react-hooks@4.1.1 should have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: ESLint Rules Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes eslint warning when node type is ChainExpression pfongkye/react
3 participants
@gaearon @pfongkye @rteixeirax