Confusion about rowHasChanged
and ListView rendering
#5754
Labels
Resolution: Locked
This issue was locked by the bot.
rowHasChanged
and ListView rendering
#5754
Hey all,
While working on some performance improvements I found out that
rowHasChanged
was not called in any of our lists. These lists are infinite-scrolling lists, meaning that when you reach the end, it will fetch more items to display and then dump them into the list.It seems like all entries in the list are updated whenever we change the DataSource's content. We do have a
shouldComponentUpdate
in place for all rows, but from how I understoodrowHasChanged
, these rows would not needed to be rendered again.I created a simple example that shows how we are appending items to the list: https://gist.github.com/janmonschke/c9c84b6050683da0c64f
What we basically do is:
But
rowHasChanged
is never logged.Am I using it somehow in a wrong way? Are there better ways to append to a ListView?
Same behaviour in
0.18.0
and0.19.0
The text was updated successfully, but these errors were encountered: