Fix SurfaceMountingManager leaking activity from stopped surfaces #44584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57367419 |
Base commit: 044aadb |
…cebook#44584) Summary: The issue is very similar to D46840717. MountingManager will keep a reference to the last 15 stopped surfaces: https://fburl.com/code/kbjw0a3x Each stopped surface still holds a `mRemoveDeleteTreeUIFrameCallback` which references activity: {F1638417601} Reviewed By: javache Differential Revision: D57367419
|
This pull request was exported from Phabricator. Differential Revision: D57367419 |
|
This pull request has been merged in af72108. |
|
This pull request was successfully merged by Oleh Malanchuk in af72108. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The issue is very similar to D46840717.
MountingManager will keep a reference to the last 15 stopped surfaces: https://fburl.com/code/kbjw0a3x
Each stopped surface still holds a
mRemoveDeleteTreeUIFrameCallbackwhich references activity:{F1638417601}
Differential Revision: D57367419