Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change made for react native breaks all webpack Moment.js users #16274

Closed
maggiepint opened this issue Oct 10, 2017 · 2 comments
Closed

Change made for react native breaks all webpack Moment.js users #16274

maggiepint opened this issue Oct 10, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@maggiepint
Copy link

Hi,

I'm Maggie from the moment core team. We merged + released a change that react native users requested to rename all dynamic requires because they apparently do not work with this library: moment/moment#4207

The net result is that all webpack2 users are now broken: moment/moment#4216

We're working on getting a small sample app that replicates pushed to a branch. In the interim, can you give me any insights on whether there is a different acceptable solution than the one here? I'm happy to ship any kind of bug fix release that makes sense.

Thanks,
Maggie

@maggiepint
Copy link
Author

@hramos
Copy link
Contributor

hramos commented Oct 10, 2017

Hey @maggiepint, I believe this is being discussed already in facebook/metro#65.

@hramos hramos closed this as completed Oct 10, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Oct 10, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants