Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Podspec directions to use use_react_native! #2962

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mhjacobson
Copy link

@mhjacobson mhjacobson commented Feb 9, 2022

Also, merge the Objective-C and Swift versions, which, apart from their accidental divergences (which I fixed first), are nearly identical.

Fixes #2958.

@facebook-github-bot
Copy link

Hi @mhjacobson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 2a3659e

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/620348f737f1f800071b4d99

😎 Browse the preview: https://deploy-preview-2962--react-native.netlify.app

Also, increase consistency between the Objective-C and Swift versions.

Fixes facebook#2958.
@mhjacobson mhjacobson force-pushed the improve-integration-with-existing-apps branch from a11fb75 to 3817751 Compare February 9, 2022 04:18
Use `<Tabs>` to display the appropriate-language content.
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with Existing Apps: Podfile example does not use use_react_native!, is incomplete
2 participants