Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail of util/Utils.h #135

Open
guodong opened this issue Jul 17, 2022 · 1 comment
Open

Build fail of util/Utils.h #135

guodong opened this issue Jul 17, 2022 · 1 comment

Comments

@guodong
Copy link

guodong commented Jul 17, 2022

Issue Description

  • tag or commit hash on which this occured
    15f1cef

  • OS version: <e.g. ubuntu-16.04>
    ubuntu-2004

Minimal test code / Steps to reproduce the issue

Build openr by build/build_openr.sh

What's the actual result?

/home/vagrant/openr/openr/tests/utils/Utils.h:122:14: error: ‘Task’ in namespace ‘folly::coro’ does not name a template type
  122 | folly::coro::Task<void> co_validateNodeKey(
      |              ^~~~
/home/vagrant/openr/openr/tests/utils/Utils.h:130:14: error: ‘Task’ in namespace ‘folly::coro’ does not name a template type
  130 | folly::coro::Task<void> co_waitForConvergence(
      |              ^~~~
[93/150] Building CXX object CMakeFiles/openrlib.dir/openr/ctrl-server/OpenrCtrlHandler.cpp.o
ninja: build stopped: subcommand failed.
Command '['/opt/facebook/cmake-lV-JXVDUReICVkOgVITpaIg5qFbZoy6F3HTQk_VSkeg/bin/cmake', '--build', '/usr/local/src/build/openr', '--target', 'install', '--config', 'Release', '-j', '2']' returned non-zero exit status 1.
!! Failed
[ERROR]: Failed to build openr
@guodong
Copy link
Author

guodong commented Jul 18, 2022

The reason is that -fcoroutines is not injected to folly and openr to enable the experimental features of folly. I'm trying to use g++-10 and inject fcoroutines to complition args. Hope this can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant