{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":41870517,"defaultBranch":"main","name":"idb","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-09-03T16:25:17.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1681668318.0","currentOid":""},"activityList":{"items":[{"before":"a89170027fb4647266e7e50b3d74a1a2e1609a2c","after":"dc169fa7c7f3623a12551ffb2ea063465e09ec84","ref":"refs/heads/gh-pages","pushedAt":"2024-04-26T09:12:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploy website - based on d5bb2967bf1e884133b994c7dd65f81fbcf0913a","shortMessageHtmlLink":"Deploy website - based on <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/idb/commit/d5bb2967bf1e884133b994c7dd65f81fbcf0913a/hovercard\" href=\"https://github.com/facebook/idb/commit/d5bb2967bf1e884133b994c7dd65f81fbcf0913a\"><tt>d5bb296</tt></a>"}},{"before":"69a2f58c9115f3e79e14c500b3f3843f87af14fd","after":"d5bb2967bf1e884133b994c7dd65f81fbcf0913a","ref":"refs/heads/main","pushedAt":"2024-04-26T09:10:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Convert the CircleCI workflow to a GitHub Actions workflow (#861)\n\nSummary:\nThis pull request converts the CircleCI workflows to GitHub actions workflows. [Github Actions Importer](https://github.com/github/gh-actions-importer) was used to convert the workflows initially, then I edited them manually to correct errors in translation.\n\n**Issues**\n\n1. _facebook/idb/build_and_deploy -> deploy-website_\n\n```\nError: Running \"git push\" command failed. Does the GitHub user account you are using have push access to the repository?\n```\n\nThis is due to the fact that `${{ secrets.GITHUB_TOKEN }}` is either undefined or doesn't have the appropriate permissions or scopes enabled to access the repository.\n\n## How did you test this change?\n\nI tested these changes in a [forked repo](https://github.com/robandpdx-org/idb/actions/runs/7717454971).\n\nhttps://fburl.com/workplace/f6mz6tmw\n\nPull Request resolved: https://github.com/facebook/idb/pull/861\n\nReviewed By: Nekitosss\n\nDifferential Revision: D56620612\n\nPulled By: jbardini\n\nfbshipit-source-id: 00b543d0019df4b59324d96582cce321a82c331a","shortMessageHtmlLink":"Convert the CircleCI workflow to a GitHub Actions workflow (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2123634039\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/idb/issues/861\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/idb/pull/861/hovercard\" href=\"https://github.com/facebook/idb/pull/861\">#861</a>)"}},{"before":"81af61d605bca9af8394b5cca4b01bdf348baf47","after":"69a2f58c9115f3e79e14c500b3f3843f87af14fd","ref":"refs/heads/main","pushedAt":"2024-04-24T10:31:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use symlink to persistence xctest bundle instead of copying to speed up the test running time\n\nSummary:\n## Hypothesis of slow running tests\n\n1. Some test bundles are fat: `//xplat/arfx/skylight/app/ui/simulator_preferences:SkylightSimulatorPreferencesTestsAppleMac` is 2.4GB\n2. The copying probably triggers some macOS security check that dyld then spend a quite long time to verify the binary (D55436652)\n\n## Fixing approaching\n\n- After discussing with jbardini, We use symlinks to buck-out folder instead of copying from buck-out folder\n- After discussing with Nekitosss We were thinking to just use the buck-out folder in place, however some lines like these would still rely on the behavior of locating xctest bundles in the \"basePath\" - so we have to refactor that part in order to just use buck-out folder in place.\nhttps://www.internalfb.com/code/fbsource/[9f3a206a2380]/fbobjc/EndToEndTests/FBSimulatorControl/src/CompanionLib/Utility/FBIDBStorageManager.m?lines=389-415\n\n## Outcome\n\n- Big-size mac tests now run faster (check the test plan - from around 70 secs to less than 2 secs)\n- Disk usage of running tests is now half than before - very helpful when batch running big-size tests on Sandcastle diff-time and continuous jobs.\n\nReviewed By: Nekitosss\n\nDifferential Revision: D56303593\n\nfbshipit-source-id: 1ab0f251991a0e2e2abc47060302cf71a30b62a5","shortMessageHtmlLink":"Use symlink to persistence xctest bundle instead of copying to speed …"}},{"before":"f77cff74777f93487a8ceb7c66231d949d2fafe0","after":"81af61d605bca9af8394b5cca4b01bdf348baf47","ref":"refs/heads/main","pushedAt":"2024-04-18T19:58:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not install app bundle into Application folder for macOS\n\nSummary: We should not install anything into global Application folder. That is security risk and unnecessary.\n\nReviewed By: jbardini\n\nDifferential Revision: D56300527\n\nfbshipit-source-id: 845ab601848807e91a3e3707b540bda9d255c859","shortMessageHtmlLink":"Do not install app bundle into Application folder for macOS"}},{"before":"069f0af61525abb8fb81ba1a22c59c7e26a05d44","after":"f77cff74777f93487a8ceb7c66231d949d2fafe0","ref":"refs/heads/main","pushedAt":"2024-04-10T19:42:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"sed died -> exited\n\nReviewed By: jbardini\n\nDifferential Revision: D55980816\n\nfbshipit-source-id: d9e16e337e0ce3016c524c45028f7edd82659b77","shortMessageHtmlLink":"sed died -&gt; exited"}},{"before":"5842d43d826e14cf1c6f4d3e42be7a175be9a566","after":"069f0af61525abb8fb81ba1a22c59c7e26a05d44","ref":"refs/heads/main","pushedAt":"2024-04-04T12:03:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixed file creation on RI\n\nSummary: For reason unknown to me old API doesn't work with permission error. But with newer apis from `NSData` everything works.\n\nReviewed By: jbardini\n\nDifferential Revision: D55738651\n\nfbshipit-source-id: 585a19908f18cbc45e47b05a094be7c755c5956f","shortMessageHtmlLink":"Fixed file creation on RI"}},{"before":"269c025b84e21685d5c611126cf330c0a01ab9de","after":"5842d43d826e14cf1c6f4d3e42be7a175be9a566","ref":"refs/heads/main","pushedAt":"2024-03-27T20:32:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Extend the timeout of test listing\n\nSummary:\nRecently we found many of our tests are failed with \"Failed to list tests.\" error message.\nhttps://www.internalfb.com/sandcastle/workflow/1292533093057807088/insights?selectedLines=420-463-1-1\nhttps://www.internalfb.com/intern/testinfra/testconsole/testrun/1407375244792239\n\nWith one of the affected test `//xplat/arfx/skylight/app/ui/simulator_preferences:SkylightSimulatorPreferencesTestsAppleMac`\n\nAfter comparing the log output and investigations, early findings are\n- this only happens to x86_64 Mac tests, but not to arm64 Mac tests\n- affected tests are quite big in binary size (the `xctest` bundle can be 2GB and more)\n- the timeout happens at this line\nhttps://www.internalfb.com/code/fbsource/[b10994f3b0de]/fbobjc/EndToEndTests/FBSimulatorControl/src/CompanionLib/FBIDBCommandExecutor.m?lines=291\n- the log when the timeout happens are\n{P1200928392}\n```\nlist_tests_in_bundle failed with: Waited 60.000000 seconds for process 20037 to terminate, but the xctest process stalled:\n```\n\nFrom the above log, we can see the \"Querying Bundle\" started but not yet to reach the Principle class line\nhttps://www.internalfb.com/code/fbsource/[5ff9cd430747]/fbobjc/EndToEndTests/FBSimulatorControl/src/Shims/Shimulator/TestReporterShim/XCTestReporterShim.m?lines=546-547,593,705-706,717-718\n\nTo repro, a simple executable is made as\n{P1201284452}\nand then with Instrument to profile - we can see the x86_64 version of the xctest takes much longer to load at the `dlopen` line.\n {F1474118714}\n {F1474118862}\n\nWe need more time to investigate why the test bundle is so big and affecting the dlopen loading performance. But to unblock these dying tests, a quick workaround is to extend this timeout.\n\nReviewed By: jbardini\n\nDifferential Revision: D55436652\n\nfbshipit-source-id: ec2f7af29b05f3ffedec958801d456a34920446e","shortMessageHtmlLink":"Extend the timeout of test listing"}},{"before":"6ef43e68c156baf7cad2e5c30e3ae2b191c15038","after":"269c025b84e21685d5c611126cf330c0a01ab9de","ref":"refs/heads/main","pushedAt":"2024-03-27T17:13:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating link for PIP installation (#855)\n\nSummary:\n<!--\nThank you for sending the PR! We appreciate you spending the time to work on these changes.\n\nHelp us understand your motivation by explaining why you decided to make this change.\n\nYou can learn more about contributing to `idb` here: https://github.com/facebook/idb/blob/main/.github/CONTRIBUTING.md\n\nHappy contributing!\n\n-->\n\n## Motivation\n\nJust updating a link on the documentation.\n\nPull Request resolved: https://github.com/facebook/idb/pull/855\n\nReviewed By: fgasperij\n\nDifferential Revision: D55406962\n\nfbshipit-source-id: f04d7fb3f0ede823b337677ce005960257aacda6","shortMessageHtmlLink":"Updating link for PIP installation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2044591225\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/idb/issues/855\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/idb/pull/855/hovercard\" href=\"https://github.com/facebook/idb/pull/855\">#855</a>)"}},{"before":"fb37e2077c8e60c356f58d539b13fb3a9a19a1b2","after":"6ef43e68c156baf7cad2e5c30e3ae2b191c15038","ref":"refs/heads/main","pushedAt":"2024-03-27T17:08:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix: typo in readme (#833)\n\nSummary:\n## Motivation\n\nBoy scout rule :)\n\nPull Request resolved: https://github.com/facebook/idb/pull/833\n\nTest Plan: Does not apply\n\nReviewed By: fgasperij\n\nDifferential Revision: D55407027\n\nfbshipit-source-id: fa232f917eaf25619cc19194eb92da5e4ebfa0cd","shortMessageHtmlLink":"fix: typo in readme (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1693705001\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/idb/issues/833\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/idb/pull/833/hovercard\" href=\"https://github.com/facebook/idb/pull/833\">#833</a>)"}},{"before":"10de9e5e565336634a84e796cf58c21910a7ccb8","after":"fb37e2077c8e60c356f58d539b13fb3a9a19a1b2","ref":"refs/heads/main","pushedAt":"2024-03-27T08:33:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix typo (#854)\n\nSummary: Pull Request resolved: https://github.com/facebook/idb/pull/854\n\nReviewed By: fgasperij\n\nDifferential Revision: D55406965\n\nfbshipit-source-id: bd4473d41c1b6fc02976c15bb8f7cbca2c5b9f2a","shortMessageHtmlLink":"Fix typo (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2044501298\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/idb/issues/854\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/idb/pull/854/hovercard\" href=\"https://github.com/facebook/idb/pull/854\">#854</a>)"}},{"before":"a2015dd42497e29ce34895c613200aef423bf142","after":"10de9e5e565336634a84e796cf58c21910a7ccb8","ref":"refs/heads/main","pushedAt":"2024-03-22T19:13:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix usages of archivedDataWithRootObject: in tests (1/2)\n\nSummary: Migrating off of the deprecated method `archivedDataWithRootObject:`, as well as its counterpart, `unarchiveObjectWithData:` if it appears in the same file.\n\nReviewed By: yannickl\n\nDifferential Revision: D55248376\n\nfbshipit-source-id: e1d5699bb452694f7ffb998adeed3f028c5e5035","shortMessageHtmlLink":"Fix usages of archivedDataWithRootObject: in tests (1/2)"}},{"before":"10c4638d538ae1507246d90576b3945640e789a0","after":"a2015dd42497e29ce34895c613200aef423bf142","ref":"refs/heads/main","pushedAt":"2024-03-04T22:35:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"apply Black 2024 style in fbcode (16/17)\n\nSummary:\nFormats the covered files with pyfmt.\n\npaintitblack\n\nReviewed By: zertosh, abesto\n\nDifferential Revision: D54470824\n\nfbshipit-source-id: 06c8f96f17045dcd46a23398274cc5b741c6e846","shortMessageHtmlLink":"apply Black 2024 style in fbcode (16/17)"}},{"before":"f608ea3d86469b8d6b7a7770db9dd117d0cb50a1","after":"10c4638d538ae1507246d90576b3945640e789a0","ref":"refs/heads/main","pushedAt":"2024-03-02T19:09:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pyre Configurationless migration for] [batch:21/112] [shard:6/N]\n\nReviewed By: connernilsen\n\nDifferential Revision: D54433906\n\nfbshipit-source-id: d29cdd8c86350057452e81e6015353f1b308770c","shortMessageHtmlLink":"Pyre Configurationless migration for] [batch:21/112] [shard:6/N]"}},{"before":"ddfc3b997d64698e379a58463bd8a1f073f3e97a","after":"f608ea3d86469b8d6b7a7770db9dd117d0cb50a1","ref":"refs/heads/main","pushedAt":"2024-02-29T16:00:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Add support for idb-targets to iOS RM\"\n\nSummary:\nOriginal commit changeset: f8080c5d20ba\n\nOriginal Phabricator Diff: D52659078\n\nDifferential Revision: D54359346\n\nfbshipit-source-id: 72fe6fdde646f89209b35d5ab16c9eecc61352b1","shortMessageHtmlLink":"Back out \"Add support for idb-targets to iOS RM\""}},{"before":"2dfb5c8bd9a19d55b290101945334702e54b8ceb","after":"ddfc3b997d64698e379a58463bd8a1f073f3e97a","ref":"refs/heads/main","pushedAt":"2024-02-23T21:23:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add support for idb-targets to iOS RM\n\nSummary:\nBoot the iOS Simulator using `idb-targets` instead of `idb companion` as requested by Nekitosss.\n\nNOTE: The cogwheels for this test would not pass till the first 2 diffs in the stack have landed.\n\nReviewed By: Nekitosss\n\nDifferential Revision: D52659078\n\nfbshipit-source-id: f8080c5d20ba44c6473f59467db288ac8981149f","shortMessageHtmlLink":"Add support for idb-targets to iOS RM"}},{"before":"e85ad77ba8c4ce08c9ca2c3bef50c963667032a9","after":"2dfb5c8bd9a19d55b290101945334702e54b8ceb","ref":"refs/heads/main","pushedAt":"2024-02-16T22:02:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove prefix_headers\n\nSummary: Remove explicit `prefix_header`s from fbobjc. These will slow down builds and are not compatible with explicit modules.\n\nReviewed By: d16r\n\nDifferential Revision: D53788248\n\nfbshipit-source-id: d9496cb1d576c09341e76b74a7d8a3d74ad69f6a","shortMessageHtmlLink":"remove prefix_headers"}},{"before":"f843669a66c7b6b9acca7b3356e1a25130f24e1b","after":"e85ad77ba8c4ce08c9ca2c3bef50c963667032a9","ref":"refs/heads/main","pushedAt":"2024-02-15T18:40:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix crasher on describe-point\n\nSummary:\nI've found another crasher that occurs, this is when using `describe-point` when there are no elements that match. The best way of reproing this is hitting a point with a fullscreen dialog\n\n{F1456920875}\n\nIn this case I am hitting 100, 100. Which is somewhere near the top left of the screen. A full modal will prevent any accessibility requests to anything other than the dialog.\n\ndescribe-point does not remediate on zero rect. This is because empty/no information is a valid state for this call, but not for describe-all.\n\nReviewed By: jamescoggan\n\nDifferential Revision: D53807689\n\nfbshipit-source-id: 8d92f6d9a2d4481382a521b601615321d7d467c3","shortMessageHtmlLink":"Fix crasher on describe-point"}},{"before":"29c744e0e695d49f06bed770bda22dea0d6b6254","after":"f843669a66c7b6b9acca7b3356e1a25130f24e1b","ref":"refs/heads/main","pushedAt":"2024-02-15T15:41:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Inline translationCallbackForToken\n\nSummary: There's no need for a separate function here, needless indirection\n\nReviewed By: jamescoggan\n\nDifferential Revision: D53807251\n\nfbshipit-source-id: 0149adcc88e8693011dc2c2824afc9c08f28744c","shortMessageHtmlLink":"Inline translationCallbackForToken"}},{"before":"05ecd00b45f992de46cf42c29764b5854649740e","after":"29c744e0e695d49f06bed770bda22dea0d6b6254","ref":"refs/heads/main","pushedAt":"2024-02-15T15:08:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Extract FBSimulatorAccessibilitySerializer\n\nSummary: I wanted to separate some of the responsibilities as elements of the implementation will become more complex.\n\nReviewed By: ronmrdechai\n\nDifferential Revision: D53767138\n\nfbshipit-source-id: 65c8c4fa534236f703d9d64c28ed953b28f84f0e","shortMessageHtmlLink":"Extract FBSimulatorAccessibilitySerializer"}},{"before":"e44d0f0e219e6aa84ce5f6cf3e2f5037b160ba54","after":"05ecd00b45f992de46cf42c29764b5854649740e","ref":"refs/heads/main","pushedAt":"2024-02-15T14:28:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Return PID of element in ui describe output\n\nSummary: This was helpful when identifying whether `SpringBoard` has crashed. I'm going to include it in the output as it will be helpful for confirming success later on\n\nReviewed By: jamescoggan\n\nDifferential Revision: D53807518\n\nfbshipit-source-id: 4e3c7dfa20ca03077b769a72163dee734751cc87","shortMessageHtmlLink":"Return PID of element in ui describe output"}},{"before":"4a9277d0c22672d041ec666680667a7583d0f3f0","after":"e44d0f0e219e6aa84ce5f6cf3e2f5037b160ba54","ref":"refs/heads/main","pushedAt":"2024-02-02T18:45:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace \"assign\" annotation with \"weak\" for id properties\n\nSummary:\n# Context\n`id` is defined by ARC to be a retainable object pointer type (https://clang.llvm.org/docs/AutomaticReferenceCounting.html#retainable-object-pointers). For these types, an `assign` property has the same behavior as `unsafe_unretained`. In other words: the referenced object may go out of scope and be deallocated at any time, at which point the property may point to garbage (or even a newly allocated object). In most cases, this will likely cause a crash that will take time to debug. In extremely unlucky cases, code execution could perform something completely unexpected.\n\nAs object lifetimes may change due to retention patterns in completely different areas of the code base each of these lines may be perfectly fine one day only to start causing crashes the next. See S383866 as an example.\n\n# This diff\nReplaces all uses of the `assign` property annotation with `weak` if the value is an id type.\n\n## Rationale\n`weak` has the same object lifetime implications as `assign` while providing an easier to debug experience if the object deallocates.\n\n## Codemod command\n```\nTools/fastmod/fastmod --extensions h,m,mm --accept-all '(\\s*property\\s*\\([\\w\\s,]*)assign([\\w\\s,]*\\)\\s*id[\\s<].*)' '${1}weak${2}'\n```\n\n# How to review this diff\nPlease review your owned files. In most cases, they should be fairly straightforward. If not, and you don't fall into one of the special cases below, please let me know.\n\n## Special Case 1 - My file is not using ARC\n\nI would be surprised at this as ARC has been demonstrably more efficient than manual reference counting for years now. However, if this is the case please let me know and I'll revert this change for your file\n\n## Special Case 2 - I need `strong` instead of `weak`\n\nFor these cases, please accept this change as is and file yourself a task to change the annotation from `weak` to `strong` after this diff lands. The intention is for this diff to not introduce any object lifetime changes.\n\nReviewed By: xavierjurado\n\nDifferential Revision: D53328730\n\nfbshipit-source-id: 7567d20b7179aa4e017b2b066fb398f0a149ad68","shortMessageHtmlLink":"Replace \"assign\" annotation with \"weak\" for id properties"}},{"before":"f07afee8230707c23ea34e8dc8c9c1c26eca1305","after":"4a9277d0c22672d041ec666680667a7583d0f3f0","ref":"refs/heads/main","pushedAt":"2024-01-25T19:48:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"`XCTAssertTrue(NO);` -> `XCTFail();`\n\nSummary: Cleanup\n\nReviewed By: andrewtenno\n\nDifferential Revision: D53071504\n\nfbshipit-source-id: d453d52199fdfedd61c8c213c7c11317088624e4","shortMessageHtmlLink":"<code>XCTAssertTrue(NO);</code> -&gt; <code>XCTFail();</code>"}},{"before":"fdce027b2ca1a6de81aeda7a529ef8200845c26d","after":"f07afee8230707c23ea34e8dc8c9c1c26eca1305","ref":"refs/heads/main","pushedAt":"2024-01-24T22:21:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Always create temp dir for coverage data\n\nSummary: Similarly to `logs` folder, always create the coverage folder when coverage is requested, instead of relying on the test process to create the folder.\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D52841325\n\nfbshipit-source-id: c92afa5738cb54e778a06e9571340164775eac6b","shortMessageHtmlLink":"Always create temp dir for coverage data"}},{"before":"6855b376fb3dc0ed7a25d5305c9afcfa56458cbb","after":"fdce027b2ca1a6de81aeda7a529ef8200845c26d","ref":"refs/heads/main","pushedAt":"2024-01-24T13:52:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/idb` - batch 1\n\nDifferential Revision: D53014334\n\nfbshipit-source-id: 7b70f74e3e68b432c9d5f915050366e6e5bada81","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/idb</code> - batch 1"}},{"before":"eeb409de89400dcd818fd3cf8695f35a196ad62b","after":"6855b376fb3dc0ed7a25d5305c9afcfa56458cbb","ref":"refs/heads/main","pushedAt":"2024-01-16T10:44:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Implement continuous coverage for logic tests\n\nSummary: Add [LLVM's `%c`](https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program) to logic tests when `--enable-continuous-coverage` is specified\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D52797255\n\nfbshipit-source-id: 53f8e6f7d900ebf7c2e6c819a36e75a2567f1f1d","shortMessageHtmlLink":"Implement continuous coverage for logic tests"}},{"before":"0d4446648ad4e1b8f4e462304fbb5a20c1608e8d","after":"eeb409de89400dcd818fd3cf8695f35a196ad62b","ref":"refs/heads/main","pushedAt":"2024-01-16T10:15:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Signal process under test termination uppon crashes\n\nSummary:\nMost of test results reporting assume that the test under process is terminated when a crash happens, except coverage collection.\n\nidb only reads coverage collection after `processUnderTestExitedMutable` is resolved to ensure that we get complete coverage data when the tests run successfully. However, the Reporter callback that resolves `processUnderTestExitedMutable` was never called when the test process crashed and the test ran request would hang.\n\nChange `FBLogicReporterAdapter` to `[self.reporter processUnderTestDidExit]` like it does when the test process finishes cleanly. This is safe because `didCrashDuringTest:` is only called when the test process IO is closed, which happen when the process terminates.\n\nReviewed By: Nekitosss\n\nDifferential Revision: D52796488\n\nfbshipit-source-id: a0b249defe9c133e6cf8567304cb8818d068eedc","shortMessageHtmlLink":"Signal process under test termination uppon crashes"}},{"before":"da0ff38669dc5e6ffda584463ed14378f6432d0d","after":"0d4446648ad4e1b8f4e462304fbb5a20c1608e8d","ref":"refs/heads/main","pushedAt":"2023-12-14T00:01:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use devicectl to launch apps on iOS 17 devices.\n\nSummary: With the introduction of CoreDevice with Xcode 15 and iOS 17, `idb` can no longer launch apps on physical devices. Apple has provided `devicectl` which can be used to launch apps on physical devices. This diff restores `idb`'s ability to launch apps on iOS 17 devices by using `devicectl`.\n\nReviewed By: ChrisRicca\n\nDifferential Revision: D51122573\n\nfbshipit-source-id: a3a2392178941d21b36255dcb9a82246f0871b9b","shortMessageHtmlLink":"use devicectl to launch apps on iOS 17 devices."}},{"before":"fc89a00fe933d113dd6920f3006ba406cdb33af7","after":"da0ff38669dc5e6ffda584463ed14378f6432d0d","ref":"refs/heads/main","pushedAt":"2023-12-12T09:51:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Declare unsafe FBSimulator initializer\n\nReviewed By: fgasperij\n\nDifferential Revision: D51809057\n\nfbshipit-source-id: a12ae0f513aa597a8ad34d4179d78ecce0de8e43","shortMessageHtmlLink":"Declare unsafe FBSimulator initializer"}},{"before":"41cdacbe515976db4ed6bfbdc448d2cb42fed919","after":"fc89a00fe933d113dd6920f3006ba406cdb33af7","ref":"refs/heads/main","pushedAt":"2023-12-11T14:39:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move BridgeFuture to Companion Lib\n\nReviewed By: fgasperij\n\nDifferential Revision: D51978751\n\nfbshipit-source-id: a449171ef29a9f1ac1b577dd8a80fe0609d1fa39","shortMessageHtmlLink":"Move BridgeFuture to Companion Lib"}},{"before":"5340a1301bb2542c0ee0c2e11ea347833170995b","after":"41cdacbe515976db4ed6bfbdc448d2cb42fed919","ref":"refs/heads/main","pushedAt":"2023-12-01T09:33:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reporting Crashed Thread on Unhosted Tests\n\nSummary: Modifying the error returned when a unhosted test crashes to include crashed thread's trace, instead of just the hard to read raw crash file json.\n\nReviewed By: mkoshtenko\n\nDifferential Revision: D51590912\n\nfbshipit-source-id: ebf420d66c8ea15fbaf671ef5f79a1a1121a03e5","shortMessageHtmlLink":"Reporting Crashed Thread on Unhosted Tests"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEOvoiLwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/idb"}