{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":455600,"defaultBranch":"master","name":"hhvm","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-01-02T01:17:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708115215.0","currentOid":""},"activityList":{"items":[{"before":"5a45649444c6c3a548d3a677e582879112a39937","after":"6be9b1e906365e14885926e6dc3d37ef637fc1cd","ref":"refs/heads/master","pushedAt":"2024-05-17T18:11:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not set the request context in ViaCoroutinePromiseBase::scheduleContinuation()\n\nSummary:\nSetting the `RequestContext` is expensive, especially if the context has registered hooks. If we do it both before submitting work to the executor, and in the scheduled callback, we're essentially paying double the cost for the cases where the request context is not already set.\n\nAlso, we're not doing it consistently across our async frameworks (`Future` doesn't do this), and adding it to `Future` would likely be prohibitively expensive, so it is better to remove this for now and explore a different solution if we need the executor to be always aware of the request context.\n\nDifferential Revision: D57275308\n\nfbshipit-source-id: 5aa2bec88e468223dc12d615dd9e28d8c04f6faa","shortMessageHtmlLink":"Do not set the request context in ViaCoroutinePromiseBase::scheduleCo…"}},{"before":"cba8993c7cb91b3cd4a068e61650edc4e03ec1d9","after":"5a45649444c6c3a548d3a677e582879112a39937","ref":"refs/heads/master","pushedAt":"2024-05-17T16:37:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/9ce200ebdaecf0a5906adaa8aa8cbf128c57c3a3\nhttps://github.com/facebook/fb303/commit/22a65bd65ec4b7c4588073c51b41ae81d34e69c3\nhttps://github.com/facebook/fbthrift/commit/0e618aa4c5cbca39c28d031fda2fcb2f16495fa7\nhttps://github.com/facebook/folly/commit/e55924b002d78d834c85d84016f54f9a7a057346\nhttps://github.com/facebook/mvfst/commit/cee162311b0fa2e52141a9d3e810a34edf7a73ff\nhttps://github.com/facebook/proxygen/commit/cc1f604a7bf73464b66950c8a5c4902a77b0e647\nhttps://github.com/facebook/wangle/commit/cf7349f22b8327117a6ed37272333442daadf5fd\nhttps://github.com/facebookexperimental/edencommon/commit/ffc6ee750a9753c6cbe26d2d56e912913b38425c\nhttps://github.com/facebookexperimental/rust-shed/commit/312da5079f2aab5d62691093767338d7072bcea4\nhttps://github.com/facebookincubator/fizz/commit/2f394662b22438cf41796daf6682a3ecf366e31c\n\nReviewed By: ajb85\n\nfbshipit-source-id: e57c59276ed29f93af2018c10efb262975a93aa8","shortMessageHtmlLink":"Updating submodules"}},{"before":"080efb33510fee5088d21063d948457e46e460e1","after":"cba8993c7cb91b3cd4a068e61650edc4e03ec1d9","ref":"refs/heads/master","pushedAt":"2024-05-17T16:04:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix continue in finally typehole\n\nSummary:\nThe emitter pushes a fatal when there's a top level `break;` or `continue;` in a finally block\n\nhttps://www.internalfb.com/code/fbsource/[14c99a6aff392a85bbccdc0f79e582f334c1a103]/fbcode/hphp/hack/src/hackc/emitter/try_finally_rewriter.rs?lines=205-215\n\n(seemingly in part to maintain compatibility with PHP) but Hack doesn't raise an error, so there was a typehole task to fix this.\n\nReviewed By: patriciamckenzie\n\nDifferential Revision: D57331245\n\nfbshipit-source-id: c62f430b39b25423b0abd6447220d372fb3ff704","shortMessageHtmlLink":"Fix continue in finally typehole"}},{"before":"a152f72cafd4d2cac84735196270d74869449506","after":"080efb33510fee5088d21063d948457e46e460e1","ref":"refs/heads/master","pushedAt":"2024-05-17T14:54:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not allow function pointer to UNSAFE_CAST magic function\n\nSummary: Most pseudofunctions like hh_show are not valid to be called in WWW, but UNSAFE_CAST is special because we use it and erase it, so we had a hole where it can be referenced as `UNSAFE_CAST<>`.\n\nReviewed By: francesco-zappa-nardelli\n\nDifferential Revision: D57487941\n\nfbshipit-source-id: 79e1e96c840d938bc50099dc2d969d1bdab39b19","shortMessageHtmlLink":"Do not allow function pointer to UNSAFE_CAST magic function"}},{"before":"56bdc56fbbce7d1af413864be35f868642456676","after":"a152f72cafd4d2cac84735196270d74869449506","ref":"refs/heads/master","pushedAt":"2024-05-17T13:03:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove call to add_subtype_prop\n\nSummary: The `subtype_prop` field of the inference environment isn't used for anything, so we can remove the call to populate it ahead of removing it.\n\nReviewed By: vassilmladenov\n\nDifferential Revision: D57487982\n\nfbshipit-source-id: 173197a5fdbad32f801b010e4d32bb08fcf32078","shortMessageHtmlLink":"Remove call to add_subtype_prop"}},{"before":"688dee28fa233b0e9bf48e17dc6e644387ad3fc4","after":"56bdc56fbbce7d1af413864be35f868642456676","ref":"refs/heads/master","pushedAt":"2024-05-17T12:49:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove is_null special handling\n\nSummary: Treat it just like any other function (e.g. like the existing, non-refining `is_string`)\n\nReviewed By: madgen\n\nDifferential Revision: D57400365\n\nfbshipit-source-id: 2a4b6bb1562c974655640bacd21c52930619c26d","shortMessageHtmlLink":"Remove is_null special handling"}},{"before":"ff118122c07e666ad0cdde33fa99b95b420cd96c","after":"688dee28fa233b0e9bf48e17dc6e644387ad3fc4","ref":"refs/heads/master","pushedAt":"2024-05-17T09:14:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Inject fallthrough in not-last label in multi-label switch case\n\nSummary:\nWhen we lower sections w/ multiple labels, they are converted into individual sections -- one for each label. But the sections of the non-last labels are empty blocks. While these are implicitly FALLTHROUGH at runtime, typing was interpreting them incorrectly as empty blocks that exit the switch.\n\nConsequently, FALLTHROUGHs didn't work if the next section had multiple labels b/c we'd fall through to the next label's empty section and exit the swtich.\n\nI solved this by making these previously empty sections have a FALLTHROUGH. This allows the previous FALLTHROUGH to cascade through these non-last labels.\n\nReviewed By: CatherineGasnier\n\nDifferential Revision: D57378856\n\nfbshipit-source-id: db8bb7fbefa94d2ca8fc4ef79c54fbdd3a2fb859","shortMessageHtmlLink":"Inject fallthrough in not-last label in multi-label switch case"}},{"before":"01a942128326040d352e7f6139e38c0b3c4b4d0b","after":"ff118122c07e666ad0cdde33fa99b95b420cd96c","ref":"refs/heads/master","pushedAt":"2024-05-17T03:20:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Switch logging to ServerInit instead of ProcessInit\n\nSummary:\nLogging to the hhvm_runtime_options scuba table relies on `StructuredLog::*`,\nwhich in turn relies on the scribe extension being initialized\n(`StructuredLog::enabled()` needs to return `true).\n\nThe ext_scribe in turn initializes using `ProcessInitConcurrent`, which races\nwith `ProcessInit`. This means there's not guarantee that all we log\nhhvm_runtime_options for all machines that we intend to.\n\nMove the logging hook to ServerInit, which runs after ProcessInitConcurrent\ncompletes to fix the race condition.\n\nReviewed By: ricklavoie, binliu19\n\nDifferential Revision: D57308778\n\nfbshipit-source-id: e7ab8525e5f749f978f1058627b043066d2d48fe","shortMessageHtmlLink":"Switch logging to ServerInit instead of ProcessInit"}},{"before":"e7b2ae7469c830ba50e40fc545f7329e95f7634c","after":"01a942128326040d352e7f6139e38c0b3c4b4d0b","ref":"refs/heads/master","pushedAt":"2024-05-17T01:12:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add explicit DEV_BUILD mode\n\nSummary:\nSee comment thread in https://fb.workplace.com/groups/hhvm.prod/posts/1437526143803748/?comment_id=1438715463684816 for more context.\n\nThis achieves two things:\n* Introduces explicit DEV_BUILD flag, so we don't have to piggy back off of low_ptr to distinguish between dev and prod builds.\n* Changes BOLT settings to dev builds to avoid running into problems with some external libraries that put data in text sessions.\n\nThe latter will be reverted once we make upstream changes to said library (Ring, https://www.internalfb.com/code/fbsource/[57d15a784b189e5af853e52ff113b1cfa844cc6f]/third-party/rust/vendor/ring-0.16.20/pregenerated/aesni-x86-elf.S?lines=676-678%2C680-681%2C687).\n\nReviewed By: paulbiss\n\nDifferential Revision: D57355789\n\nfbshipit-source-id: 40272e8013163170d836d163d825ffbbbefb30c2","shortMessageHtmlLink":"add explicit DEV_BUILD mode"}},{"before":"2532170f72f868e74bfb08bc2d343a48fbee4969","after":"e7b2ae7469c830ba50e40fc545f7329e95f7634c","ref":"refs/heads/master","pushedAt":"2024-05-17T00:26:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use built-in prelude\n\nSummary:\nNow that OSS buck2 supports this, let's use it!\n\nX-link: https://github.com/facebook/folly/pull/2205\n\nReviewed By: yfeldblum\n\nDifferential Revision: D57439142\n\nPulled By: bigfootjon\n\nfbshipit-source-id: 576cd0b83d4b4a2a5f833f7c03f53bd1267c6b62","shortMessageHtmlLink":"Use built-in prelude"}},{"before":"8d4d82fa134946fd2eddee008b489cc5c12dbc67","after":"2532170f72f868e74bfb08bc2d343a48fbee4969","ref":"refs/heads/master","pushedAt":"2024-05-16T23:46:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Warn that `AtomicHashMap` benchmark is buggy; reduce UB\n\nSummary:\n- Add a warning inline saying that these measurements are probably wrong, plus an explanation of why.\n- Note also that `st_baseline_modulus_and_random` prints a zero timing regardless of the number of iterations. **shrug**\n- Signed integer overflow is common in this code, and is technically UB, so let's make this more technically correct. Note that practically, it doesn't seem to change the benchmark behavior.\n\nDifferential Revision: D57396928\n\nfbshipit-source-id: 5e5699278878822c2f63fa70f3b0a5c85ee6c61d","shortMessageHtmlLink":"Warn that <code>AtomicHashMap</code> benchmark is buggy; reduce UB"}},{"before":"de6ce09e797385a0985232f8caad2176fa7c73eb","after":"8d4d82fa134946fd2eddee008b489cc5c12dbc67","ref":"refs/heads/master","pushedAt":"2024-05-16T23:21:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Save memory in intern builds the better way\n\nSummary:\nReduce the amount of memory needed for trace scheduling with intern\nbuilds. Instead of disabling trace scheduling above an arbitrary limit\n(which was a quick fix), rework some of the data structures to be\nsmaller. Use vectors instead of maps in a few places. Instead of using\nmultiple maps, have a single map mapping a name to a set of\nproperties. Also add some missing moves. Use a latch to avoid the\nco-routines queueing up while holding a lot of memory.\n\nThis all can be improved even further by re-designing the algorithm\nand data-structures to take advange of common dependency sequences,\nbut this is fine for now.\n\nReviewed By: mdko\n\nDifferential Revision: D57455724\n\nfbshipit-source-id: a7fa3b897a73ceddc8f170c9efe3cf55ab0c8b1a","shortMessageHtmlLink":"Save memory in intern builds the better way"}},{"before":"a580a62ef7d7da5992eaa9eeb0b68c69730487bd","after":"de6ce09e797385a0985232f8caad2176fa7c73eb","ref":"refs/heads/master","pushedAt":"2024-05-16T23:14:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"depend on fbthrift_conformance if 'any' is in rust codegen flags\n\nSummary: if a thrift library's `thrift_rust_options` contains `any` then add a `use fbthrift_conformance` directive to `types.rs` to enable support for `AnyRegistry` interactions.\n\nReviewed By: dtolnay\n\nDifferential Revision: D57440177\n\nfbshipit-source-id: cb2f8ab4fd38c22a4df74eaee6f54e20c5ed1fcf","shortMessageHtmlLink":"depend on fbthrift_conformance if 'any' is in rust codegen flags"}},{"before":"b16fb9ea6c18fa476049dd08e8a5679939baa2ae","after":"a580a62ef7d7da5992eaa9eeb0b68c69730487bd","ref":"refs/heads/master","pushedAt":"2024-05-16T23:08:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix CodeQL C++ issues\n\nSummary:\nCodeQL found some issues via static analysis. See microsoft/react-native-windows#12703\n\nX-link: https://github.com/facebook/folly/pull/2178\n\nReviewed By: ilvokhin\n\nDifferential Revision: D56591460\n\nPulled By: Orvid\n\nfbshipit-source-id: a0af3171a4076ff1131baf6ee53a40ade55667d3","shortMessageHtmlLink":"Fix CodeQL C++ issues"}},{"before":"2388b1d0843465218c46ac041c0892975c82b109","after":"b16fb9ea6c18fa476049dd08e8a5679939baa2ae","ref":"refs/heads/master","pushedAt":"2024-05-16T20:56:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim ProgramOptions in folly\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental:program_options -> //folly/cli:program_options\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/NestedCommandLineApp.h -> folly/cli/NestedCommandLineApp.h\nfolly/experimental/ProgramOptions.h -> folly/cli/ProgramOptions.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: Orvid\n\nDifferential Revision: D57395676\n\nfbshipit-source-id: 92e1504a85766e097ca2731356efd5e08ced8ec1","shortMessageHtmlLink":"Deshim ProgramOptions in folly"}},{"before":"2b4800008cb8f0d4b99d8eb818375c46eedc5a58","after":"2388b1d0843465218c46ac041c0892975c82b109","ref":"refs/heads/master","pushedAt":"2024-05-16T20:07:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update test fixtures\n\nSummary:\n```\nbuck2 run fbcode//thrift/compiler/test:build_fixtures -- --fixture-root=fbcode/\n```\n\nReviewed By: yoney, praihan\n\nDifferential Revision: D57455236\n\nfbshipit-source-id: 406ab84e6b512535e749e2b50a2fe72fc96bbc67","shortMessageHtmlLink":"Update test fixtures"}},{"before":"43e84fb4b191d9c05f2b2583b56afb94b2ce1297","after":"2b4800008cb8f0d4b99d8eb818375c46eedc5a58","ref":"refs/heads/master","pushedAt":"2024-05-16T19:45:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix some dead links in contributions/adapters.md\n\nSummary: Stuff got moved around recently and broke some links.\n\nReviewed By: Mizuchi\n\nDifferential Revision: D57448140\n\nfbshipit-source-id: fb8b4547b45fdcd786fedad7c814d76e1329a772","shortMessageHtmlLink":"Fix some dead links in contributions/adapters.md"}},{"before":"bf22c0cfa08ef1e7a66e5651dd924cecd75089c6","after":"43e84fb4b191d9c05f2b2583b56afb94b2ce1297","ref":"refs/heads/master","pushedAt":"2024-05-16T19:40:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add folly::doNotOptimizeAway to ProtocolBenchmark\n\nReviewed By: vitaut\n\nDifferential Revision: D57394998\n\nfbshipit-source-id: 6a912da7a1153d0668f1606bcffc93f0af10dc9f","shortMessageHtmlLink":"Add folly::doNotOptimizeAway to ProtocolBenchmark"}},{"before":"cd5a276aa79992d9b586cbc041883e20369246ce","after":"bf22c0cfa08ef1e7a66e5651dd924cecd75089c6","ref":"refs/heads/master","pushedAt":"2024-05-16T19:35:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Log Effective Ticket Seeds Policy\n\nSummary:\n- Adding a new field effective_ticket_seed_strategy to Server Event Logging to log what was the ticket seeds strategy used for the server.\n- Adding a new enum EffectiveTicketSeedStrategy to differentiate between 3 different types of ticket seeds strategies: FILE, IN_MEMORY, and IN_MEMORY_WITH_ROTATION, and changing `shouldScheduleInMemoryTicketSeeds` to `getEffectiveTicketSeedStrategy`\n\nReviewed By: frqiu\n\nDifferential Revision: D57361329\n\nfbshipit-source-id: 52002421c721c1bd0269f90ff7b6738f4618cc55","shortMessageHtmlLink":"Log Effective Ticket Seeds Policy"}},{"before":"f791873cdddde21544fb83bbe1ced21da8772a48","after":"cd5a276aa79992d9b586cbc041883e20369246ce","ref":"refs/heads/master","pushedAt":"2024-05-16T19:23:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"clean up the old files moved to backend/openssl\n\nReviewed By: AjanthanAsogamoorthy\n\nDifferential Revision: D56614720\n\nfbshipit-source-id: dd981bee5f1efc0b43d063f8ce9e5b33836abd46","shortMessageHtmlLink":"clean up the old files moved to backend/openssl"}},{"before":"b2732cf44c7471e94e74e28d9c9109cbbed0a9a9","after":"f791873cdddde21544fb83bbe1ced21da8772a48","ref":"refs/heads/master","pushedAt":"2024-05-16T18:25:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reuse parsing support for allow_directories for include_paths\n\nSummary: `allow_directories` was a feature proposed for package v1 that we won't have immediate use for in light of package's redesign, but its spec is very similar to that of `include_paths` in package v2, so we can re-use the parsing implementation.\n\nReviewed By: DavidSnider\n\nDifferential Revision: D56270703\n\nfbshipit-source-id: f6c6b21f52b1de8eb640790d6129f4bff90751e0","shortMessageHtmlLink":"Reuse parsing support for allow_directories for include_paths"}},{"before":"fc45a4478abb6612d24932538d5766685613286b","after":"b2732cf44c7471e94e74e28d9c9109cbbed0a9a9","ref":"refs/heads/master","pushedAt":"2024-05-16T18:07:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Soft-inline Thrift (de)serialization functions\n\nSummary:\n**TL;DR Inlining Thrift (de)serialization functions significantly improves observed wall clock latencies for almost all workloads with only minimal impact to binary size but a measurable impact to build times.**\n\nIf this proposal sounds familiar, it's because it's an updated version of [this one](https://fb.workplace.com/groups/rust.libraries.wg/posts/2267253036959522/) and this diff D57312501 :)\n\nFull RFC and discussion in [this post](https://fb.workplace.com/groups/rust.libraries.wg/permalink/2268674973483995/).\n\nIn local tests, using the Thrift loadgen framework to attempt a consistent QPS for reproducibility, results were overall positive in reducing observed latency.\n\nOverall, in numbers:\n* 49.63% improvement for P50\n* 49.95% improvement for AVG\n* 62.41% improvement for P99\n\nAutomated build time regression analysis found that there was a 30%-40% increase in build times for the NodeAPI compiler (P1364121390 - wall clock, 1m-4m regression). This is actually an improvement over the previous regression of 400%-500% (P1364124026) for the `#[inline(always)]` version.\n\nReviewed By: jsgf, shayne-fletcher\n\nDifferential Revision: D57419887\n\nfbshipit-source-id: 5ed0b3056c2a3dc5c17cb95b4982aa9d862fbcf2","shortMessageHtmlLink":"Soft-inline Thrift (de)serialization functions"}},{"before":"b4e8467df4eb2d3ba3993919bacc9935f90c21bb","after":"fc45a4478abb6612d24932538d5766685613286b","ref":"refs/heads/master","pushedAt":"2024-05-16T17:47:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move EventCount to fbcode/folly/synchronization\n\nSummary:\nThe following targets were moved to folly/synchronization:\n```\n//folly/experimental:event_count\n//folly/experimental/test:event_count_test\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: Orvid\n\nDifferential Revision: D57282995\n\nfbshipit-source-id: dfc797a37098b9a672606b817ba6b3b693bf31d9","shortMessageHtmlLink":"Move EventCount to fbcode/folly/synchronization"}},{"before":"8bd22d74db5843c4d53d2570f95a08d507164fde","after":"b4e8467df4eb2d3ba3993919bacc9935f90c21bb","ref":"refs/heads/master","pushedAt":"2024-05-16T17:38:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make proxygen http server header samples available (installed)\n\nSummary:\nMake proxygen http server header samples available (installed).\nThis diff enables to copy the header files from `fbcode/proxygen/httpserver/samples/*.h` to includes installed directory. Then dependencies of this lib can use them\n\nMOQ (Media Over QUIC) depends on HQServer\n\nReviewed By: lnicco\n\nDifferential Revision: D57014991\n\nfbshipit-source-id: 8a0c6210dc2512fc4b6ce3b5bf0f084366fb2047","shortMessageHtmlLink":"Make proxygen http server header samples available (installed)"}},{"before":"ac690c64f68d08a60d8dbe5cf7a0f1fd1fb4c125","after":"8bd22d74db5843c4d53d2570f95a08d507164fde","ref":"refs/heads/master","pushedAt":"2024-05-16T17:26:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add the experimental __PackageOverride file flag\n\nSummary: Add the experimental `__PackageOverride` file flag and make it an unstable experimental feature.\n\nDifferential Revision: D57210370\n\nfbshipit-source-id: b62fe2117b625b01fd5273a9b490b5d1059d7fb3","shortMessageHtmlLink":"add the experimental __PackageOverride file flag"}},{"before":"2079c13802fd0c8478b2d5d99096e9c0c00d759f","after":"ac690c64f68d08a60d8dbe5cf7a0f1fd1fb4c125","ref":"refs/heads/master","pushedAt":"2024-05-16T16:38:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/2753451d68b7ffcdbd5bcb8f6ff6719e705e303a\nhttps://github.com/facebook/fb303/commit/e54973885c3b543b41f2167a0cf0325363c36421\nhttps://github.com/facebook/fbthrift/commit/8ebb3a56d93b3fb884cc1a87c5cb884c65a93e5b\nhttps://github.com/facebook/folly/commit/021cb16f2231355126f665b6bb2d65ad4487ae6d\nhttps://github.com/facebook/mvfst/commit/9d16a6ebea6a6b03ebeff9db4355c840bf19104d\nhttps://github.com/facebook/proxygen/commit/98d508843a6aadf42237d381f6d468d0de6b2920\nhttps://github.com/facebook/wangle/commit/8935b00b4b09ed709d360de847a7c55dd133fa21\nhttps://github.com/facebookexperimental/edencommon/commit/ec32ad7108b48c9541186a010bcdb86516a72e50\nhttps://github.com/facebookexperimental/rust-shed/commit/e9517e776ecbe0065ed808f367846ccf3afafd8e\nhttps://github.com/facebookexternal/plc-code/commit/12e9c56e378f3ae1e2617887b7b92a1b4caeb2a8\nhttps://github.com/facebookincubator/fizz/commit/3b3c3f043f811abcb50f7579ffdac1269f85e8e2\n\nReviewed By: ajb85\n\nfbshipit-source-id: f5f8c926ed497e5dd24ca56b1564926dfb495d51","shortMessageHtmlLink":"Updating submodules"}},{"before":"d3251d8b6695fbfffec666f771863beaa16e239c","after":"2079c13802fd0c8478b2d5d99096e9c0c00d759f","ref":"refs/heads/master","pushedAt":"2024-05-16T16:25:58.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Provide dynamic dst type for LdPtrIterKey and LdPtrIterVal\n\nSummary:\nThese two instructions are used at the loop header, which has to clear frame\nstate for locals using clearForUnprocessedPred(), as there might be a different\nversion of them coming via IterNext.\n\nThat means we lose track of the array specialization except of the part that we\nguarded for. Constant arrays are quite common, but we don't guard them, so at\nthe time LdPtrIterKey/LdPtrIterVal is gen'd, we don't know the type. Same for\nrepo auth types coming from hhbbc.\n\nOnce irgen is done, we reflow these types and that's when more precise array\ntype information gets known to the loop body.\n\nMake these instructions define destination type based on the iterated array, so\nthat the type gets improved during reflowTypes().\n\nAlso fix a bug in keysetPosType(). Without this, it doesn't do much for keysets.\n\nReviewed By: mdko\n\nDifferential Revision: D57426369\n\nfbshipit-source-id: d765c06ee42ee4edd9b0fa06cf175d7965f4ae26","shortMessageHtmlLink":"Provide dynamic dst type for LdPtrIterKey and LdPtrIterVal"}},{"before":"405a8e27b8d29e56cf31701c96c257090e3ac3f6","after":"d3251d8b6695fbfffec666f771863beaa16e239c","ref":"refs/heads/master","pushedAt":"2024-05-16T15:49:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Standardize when we trust a Class* 3/n\n\nSummary:\n- Unify logic that checks whether a Class* is known\n- Renamed `lookupUnique()` helpers to be `lookupKnown` since we no longer use the `AttrUnique`, and we don't just test uniqueness, since we run this in sandbox mode when we can guarantee the translation will be re-jitted when things change.\n\nReviewed By: ricklavoie\n\nDifferential Revision: D57010553\n\nfbshipit-source-id: 252d20cf7ccd65684c6191cecc7883c74bd960ad","shortMessageHtmlLink":"Standardize when we trust a Class* 3/n"}},{"before":"d45b3df95f8e908b412e3269d970f7865a2b6d0f","after":"405a8e27b8d29e56cf31701c96c257090e3ac3f6","ref":"refs/heads/master","pushedAt":"2024-05-16T15:23:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add option for package v2\n\nSummary: As titled\n\nReviewed By: DavidSnider\n\nDifferential Revision: D56267634\n\nfbshipit-source-id: f244706851fa9227b1230750223c80a23691a6c6","shortMessageHtmlLink":"Add option for package v2"}},{"before":"666a301271261929dc285cad45a5e11b7d532822","after":"d45b3df95f8e908b412e3269d970f7865a2b6d0f","ref":"refs/heads/master","pushedAt":"2024-05-16T14:31:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"reduce unsoundness in comparison binop typechecking\n\nSummary: Checking of comparisons doesn't do anything, when one of the types is a type variable that we don't know anything about yet. This is unsound, since the variable might not turn out to be the right type. Here we insist that each operand must be a subtype of int, string, datetime, or datetimeimmutable no matter what. This still leaves open the possibility of comparing int and string, but not ?int and int.\n\nReviewed By: vassilmladenov\n\nDifferential Revision: D57379513\n\nfbshipit-source-id: 6e811897204e31818cc137075c1e0b8becd2d258","shortMessageHtmlLink":"reduce unsoundness in comparison binop typechecking"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETS8CkwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/hhvm"}