placeholder cause memory leak

[bigfreeZhou]

my code in xml is

        <com.facebook.drawee.view.SimpleDraweeView
            android:layout_width="0dp"
            fresco:placeholderImage="@drawable/thisone_placeholder"
            fresco:actualImageScaleType="fitCenter"
            android:layout_height="wrap_content"
            fresco:viewAspectRatio="0.5625"
            android:layout_weight="1" />

thisone_placeholder_left is a jpg, when i use this, the memory increase fast.
and after i move it, it become normal.

[michalgr]

Fresco does not do anything fancy about placeholder images - whatever you specify, it will be obtained via Resources.getDrawable (

fresco/drawee/src/main/java/com/facebook/drawee/view/GenericDraweeView.java

Line 246 in 94ce1de

builder.setPlaceholderImage(resources.getDrawable(placeholderId), placeholderScaleType);

).

Could you check whether the memory grows because the thisone_placeholder image is that big or because multiples instances of bitmaps are created (one per drawable) ? You can check that in heapdump.

[romulof]

I confirm this.

I had a grid view with several images using a big JPEG as placeholder (for testing), and the app was crashing by memory shortage. I removed the placeholder and did the old way, checking if there's an image, else loading the placeholder as an actual image, and the leak stopped.

Here's Android Studio memory allocation analysis: 2016.02.10_21.04.zip

[tyronen]

Placeholders are meant to be small, quickly-loaded images. If you need to use a large image there, you should use a low-res request instead.

[romulof]

Small or not, a leak is a leak.