Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder roundCorner to do work #2069

Closed
zhangxu1005 opened this issue Mar 15, 2018 · 4 comments
Closed

placeholder roundCorner to do work #2069

zhangxu1005 opened this issue Mar 15, 2018 · 4 comments

Comments

@zhangxu1005
Copy link

app:placeholderImage="@drawable/smart_video_default_cover" app:placeholderImageScaleType="fitXY" app:roundBottomLeft="false" app:roundBottomRight="false" app:roundTopLeft="true" app:roundTopRight="true" app:roundedCornerRadius="10dp"

Here is my source code , the placeholderImage is a nine-patch drawable, then the roundedCorner to not work when show placeholder. If set a normal drawable to placeholderImage, the roundedCorner works well.

@oprisnik
Copy link
Contributor

I think we might not properly handle 9patch images with rounded corners. You can manually create a rounded corner version in code and set it.

We'd appreciate help with implementing this if you or somebody else wants to add this feature.

@jnawaz
Copy link
Contributor

jnawaz commented Mar 19, 2018

@zhangxu1005 if you're able to share the nine-patch image you're using, I'll take a look at reproducing this and have a go at implementing a fix.

@zhangxu1005
Copy link
Author

zhangxu1005 commented Mar 23, 2018

oscar_default_image 9

@jnawaz Thanks~

@defHLT
Copy link
Contributor

defHLT commented Jun 19, 2018

Fixed in e1aa81f

@defHLT defHLT closed this as completed Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants