-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to OkHTTP 3.6 ? #1648
Comments
If you'd like to give it a try and send a PR that would be fantastic. We don't generally use OkHttp ourselves so aren't always that quick to upgrade. Another option would be to do what we've done with the support library and make it a "provided" dependency so that we never block anyone using Fresco from upgrading to the latest OkHttp. Do you think that would make sense? |
Here's an example of what I mean by making the support library a provided dependency, which requires client apps to specifically depend on it too. I think it made perfect sense for the support lib which almost all apps pull in anyway. I'm curious what others think about doing the same here. |
OK, I will have a look and come back. |
Hello,
Is it planned to switch to last OkHttp3 release ?
Has someone tested it with HTTP2 and Fresco?
square/okhttp@parent-3.0.1...master
square/okhttp@parent-3.0.1...master#files_bucket
https://github.com/facebook/fresco/blob/master/gradle.properties#L36
Thanks,
Eric
The text was updated successfully, but these errors were encountered: