Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OkHTTP 3.6 ? #1648

Closed
eldk opened this issue Feb 1, 2017 · 3 comments
Closed

Switch to OkHTTP 3.6 ? #1648

eldk opened this issue Feb 1, 2017 · 3 comments

Comments

@eldk
Copy link
Contributor

eldk commented Feb 1, 2017

Hello,

Is it planned to switch to last OkHttp3 release ?

Has someone tested it with HTTP2 and Fresco?

square/okhttp@parent-3.0.1...master

square/okhttp@parent-3.0.1...master#files_bucket

https://github.com/facebook/fresco/blob/master/gradle.properties#L36

Thanks,

Eric

@eldk eldk changed the title Switch to OkHTTP 3.6 Switch to OkHTTP 3.6 ? Feb 1, 2017
@kirwan
Copy link
Contributor

kirwan commented Feb 1, 2017

If you'd like to give it a try and send a PR that would be fantastic. We don't generally use OkHttp ourselves so aren't always that quick to upgrade.

Another option would be to do what we've done with the support library and make it a "provided" dependency so that we never block anyone using Fresco from upgrading to the latest OkHttp. Do you think that would make sense?

@kirwan
Copy link
Contributor

kirwan commented Feb 1, 2017

Here's an example of what I mean by making the support library a provided dependency, which requires client apps to specifically depend on it too.

I think it made perfect sense for the support lib which almost all apps pull in anyway. I'm curious what others think about doing the same here.

@eldk
Copy link
Contributor Author

eldk commented Feb 1, 2017

OK, I will have a look and come back.
Thanks.

facebook-github-bot pushed a commit that referenced this issue Feb 22, 2017
Summary:
Hello,

Switch to OkHttp 3.6

Related to this : #1648

In check and tests for the moment.

Thanks,

Eric
Closes #1668

Reviewed By: oprisnik

Differential Revision: D4590782

Pulled By: kirwan

fbshipit-source-id: c92557e9db61ea95ac5dca232238313781368829
@eldk eldk closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants