{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":4524181,"defaultBranch":"main","name":"folly","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-06-01T20:49:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714693538.0","currentOid":""},"activityList":{"items":[{"before":"4a726e5bd328aae5a5305ba5b0c3d20e671d1276","after":"fb093bbba142a301debf85fec852c5117c79666e","ref":"refs/heads/main","pushedAt":"2024-05-03T02:46:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Test that startInlineImpl() preserves the request context\n\nSummary: The `RequestContextScopeGuard` in `startInlineImpl()` has a non-obvious role, explain it in a comment and add a test that fails if the line is removed.\n\nReviewed By: iahs\n\nDifferential Revision: D56901147\n\nfbshipit-source-id: d12ff1272059f18170e357cc1cdb71560fd4a5e0","shortMessageHtmlLink":"Test that startInlineImpl() preserves the request context"}},{"before":"508edb50105b1b06d5272c39dd14f8702e801cb9","after":"4a726e5bd328aae5a5305ba5b0c3d20e671d1276","ref":"refs/heads/main","pushedAt":"2024-05-03T00:48:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"a helper function to count items marked as leaked\n\nSummary:\nA helper function `annotate_object_count_leaked_uncollected` to count items marked as leaked with `annotate_object_leaked` but not yet marked as collected with `annotate_object_collected`.\n\nCould be useful for various library facilities which might want to mark their internals as leaked and collected. This case arises when libraries hold owning pointers to allocated regions in encoded form.\n\nReviewed By: tophyr\n\nDifferential Revision: D56890896\n\nfbshipit-source-id: b56becbce39548afccec858efe82f56c368958aa","shortMessageHtmlLink":"a helper function to count items marked as leaked"}},{"before":"8df6a20f8c5f1d67c027be1eddd1ee69a35d41f1","after":"508edb50105b1b06d5272c39dd14f8702e801cb9","ref":"refs/heads/main","pushedAt":"2024-05-02T20:52:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"change python3 to fbpython\n\nSummary:\nthere is a bunch of scripts that uses python3 to run, this means that they are at the mercy of whoever controll their path, in linux, this can be system python3, but can also be platform python (and probably it is both), and in windows in particular it abuses c:\\tools\\fb-python\\python3.exe. fbpython is the universal way to run python at the company that chooses the right platform python, but also provides monitoring and observability.\n\nthis scripts generates jobs like\n\nhttps://www.internalfb.com/sandcastle/job/18014399781484898/\n\nthat will stop working once we remove c:\\tools\\fb-python\\python3*.exe\n\nReviewed By: fried\n\nDifferential Revision: D56896564\n\nfbshipit-source-id: d911fdaf6750635adb05b096f0522603baf47bcc","shortMessageHtmlLink":"change python3 to fbpython"}},{"before":"a9a82be8fa8e4312835de7e21cd87646495e418d","after":"8df6a20f8c5f1d67c027be1eddd1ee69a35d41f1","ref":"refs/heads/main","pushedAt":"2024-05-02T05:39:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove time.h include from folly-config.h\n\nSummary:\n`folly-config.h` included `time.h` in order to test for the `CLOCK_REALTIME` macro, which was a proxy to test for the `clock_gettime` function. This was for Apple platforms, which ages ago did not all export `clock_gettime`. But current and recent Apple platforms should all export it.\n\nAlso cut `glibc-rt` and `liburing` deps from `folly:config`.\n\nThe rule owning this header should depend on nothing.\n\n`autodeps` and `arc lint` breakage involving these deps originally reported by DenisYaroshevskiy in: https://fb.workplace.com/groups/560979627394613/posts/2913288488830370/.\n\n#buildall\n\nReviewed By: spikeh\n\nDifferential Revision: D56805126\n\nfbshipit-source-id: 7894de40c6de234ef05e8754ae6a733987a15477","shortMessageHtmlLink":"remove time.h include from folly-config.h"}},{"before":"502314157acb7fdff41d95487f3492064051feba","after":"a9a82be8fa8e4312835de7e21cd87646495e418d","ref":"refs/heads/main","pushedAt":"2024-05-02T01:17:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"in coro retry algorithm, allow max lower than min\n\nSummary: When max is lower than min, such as when max is 0, simply take min instead.\n\nReviewed By: darxsys\n\nDifferential Revision: D56846771\n\nfbshipit-source-id: cb6dc1e71547bca11b0d85fe57d0699a0cd0a7a0","shortMessageHtmlLink":"in coro retry algorithm, allow max lower than min"}},{"before":"b5f1bebf460276deaf7e5f21e12485d644e85715","after":"502314157acb7fdff41d95487f3492064051feba","ref":"refs/heads/main","pushedAt":"2024-05-02T00:18:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Add check for minBackoff > maxBackoff in coro/Retry.h ExponentialBackoffWithJitter ctor\"\n\nSummary: Back out of D56646281. This caused too many failures in tests that do not initialize min and max correctly.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56847182\n\nfbshipit-source-id: 0f565cedafff9ef53d37c83df61e806b7584bfa0","shortMessageHtmlLink":"Back out \"Add check for minBackoff &gt; maxBackoff in coro/Retry.h Expon…"}},{"before":"89d633e8c893bc818335d181cdf8127703a05094","after":"b5f1bebf460276deaf7e5f21e12485d644e85715","ref":"refs/heads/main","pushedAt":"2024-05-01T23:54:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix for a compiler issue\n\nSummary:\nFix for a compiler issue\nUsing gcc, the folly/test:fbvector_test fails with a SIGSEGV\nIn folly/FBVector.h: S_uninitialized_fill_n, the following code leaves ```e``` unchanged (nullptr) after checked_add:\n\n```\n      T* e = nullptr;\n      if (!folly::checked_add(&e, dest, n)) {\n        throw_exception<std::length_error>(\"FBVector exceeded max size.\");\n      }\n```\n\nReviewed By: ahornby\n\nDifferential Revision: D56642541\n\nfbshipit-source-id: bf2258b17cf1ed32080932bc34d473a7d00cc969","shortMessageHtmlLink":"Fix for a compiler issue"}},{"before":"183187a2bc5add025c9b20b39261c61ac84747ad","after":"89d633e8c893bc818335d181cdf8127703a05094","ref":"refs/heads/main","pushedAt":"2024-05-01T23:47:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Propagate request context in StrandExecutor\n\nSummary: `StrandExecutor` should propagate the request context, consistently with all the other executors, otherwise tasks may run in the context of the task that scheduled the worker, which is incorrect.\n\nReviewed By: iahs\n\nDifferential Revision: D56828250\n\nfbshipit-source-id: 08d5b0fc5f7f9cb30b65472b1cc1b1a0fcee4935","shortMessageHtmlLink":"Propagate request context in StrandExecutor"}},{"before":"1f1028fee13c14f133b384afc5f014dbd00d4ab8","after":"183187a2bc5add025c9b20b39261c61ac84747ad","ref":"refs/heads/main","pushedAt":"2024-05-01T23:03:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"loosen type-info comparison under libc++\n\nSummary:\nWith libc++, we may get address-comparison for RTTI objects. If the linker does not fully merge all such symbols across all loaded .so's / dylibs, we get false mismatches. It is better in the case of UniqueInstance to err on the side of false matches than to err on the side of false mismatches.\n\nhttps://github.com/llvm/llvm-project/blob/llvmorg-18.1.4/libcxx/include/typeinfo#L117-L166\n\nReviewed By: bcardosolopes\n\nDifferential Revision: D56808919\n\nfbshipit-source-id: 453cac1f5f1e48c62394fa272b00d89f10675f54","shortMessageHtmlLink":"loosen type-info comparison under libc++"}},{"before":"16b65b36b553c3351217f81ea8cab84e1b76c1d8","after":"1f1028fee13c14f133b384afc5f014dbd00d4ab8","ref":"refs/heads/main","pushedAt":"2024-05-01T21:48:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ensure that drained tasks in SerialExecutor run destructor under RequestContext\n\nSummary: In the (unlikely) case where the parent executor discards the worker task and we drain the queue, we should still honor the contract that the task's destructor is ran under in the request context of the submitter.\n\nReviewed By: iahs\n\nDifferential Revision: D56765678\n\nfbshipit-source-id: c70051ea73dc21dc321d61442251ee9dc32ee4d5","shortMessageHtmlLink":"Ensure that drained tasks in SerialExecutor run destructor under Requ…"}},{"before":"3259a180239edb7d8422baa9bf267f7d55aa11d2","after":"16b65b36b553c3351217f81ea8cab84e1b76c1d8","ref":"refs/heads/main","pushedAt":"2024-05-01T18:04:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Test allocations, not copies, in bulk heap_vector insert\n\nSummary:\nheap_vector's bulk-insert performs a sort, which performs some number of copies on the contained data. This is an implementation detail outside of the scope of heap_vector's testing. Instead of relying on this detail in tests, check what actually matters: that bulk insertion does not perform iterative insertion, and instead performs only one allocation.\n\nAccomplish this by using a custom allocator which tracks the number of allocate calls.\n\nDifferential Revision: D56823024\n\nfbshipit-source-id: 82fc7e488574400fd76b320eedd02ba6284637db","shortMessageHtmlLink":"Test allocations, not copies, in bulk heap_vector insert"}},{"before":"916938195455afbfa5d9f6fda8cdcf2f5fad741d","after":"3259a180239edb7d8422baa9bf267f7d55aa11d2","ref":"refs/heads/main","pushedAt":"2024-05-01T17:56:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix third-party/rust/Cargo.toml\n\nSummary:\nIt looks like D56546196 was incomplete. D56546196 added a new\ndependency, but didn't account for the case where the outside world\ntries to build buck2.\n\nThis diff fixes that.\n\nReviewed By: JakobDegen\n\nDifferential Revision: D56766826\n\nfbshipit-source-id: 3590056f3c5032bdc81d40855b1bf939a4686659","shortMessageHtmlLink":"Fix third-party/rust/Cargo.toml"}},{"before":"3ae49910af03aff55c8c12261c2bbe8143a7babc","after":"916938195455afbfa5d9f6fda8cdcf2f5fad741d","ref":"refs/heads/main","pushedAt":"2024-05-01T16:36:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary: GitHub commits:\n\nReviewed By: jurajh-fb\n\nfbshipit-source-id: 9e0e61af6e2138bb27d18f15dca179b697383738","shortMessageHtmlLink":"Updating submodules"}},{"before":"dcdbd4c8d5f6511086b219dacb3e7aeb7889c662","after":"3ae49910af03aff55c8c12261c2bbe8143a7babc","ref":"refs/heads/main","pushedAt":"2024-04-30T22:25:32.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add check for minBackoff > maxBackoff in coro/Retry.h ExponentialBackoffWithJitter ctor\n\nSummary:\nEnsure that ExponentialBackoffWithJitter is constructed with a minBackoff <= maxBackoff otherwise throw an exception.\n\nThere are some tests failing because minBackoff > maxBackoff (See T186982572).\n\nThrow at construction with a helpful message that contains the values of min and max, rather than waiting until later when ExponentialBackoffWithJitter is used.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56646281\n\nfbshipit-source-id: c2b3b7d3435a68b5df2c4d7d647357504fdaf82c","shortMessageHtmlLink":"Add check for minBackoff &gt; maxBackoff in coro/Retry.h ExponentialBack…"}},{"before":"ebeafaeb2c482d69958cf2d0e1e3959b139d219c","after":"dcdbd4c8d5f6511086b219dacb3e7aeb7889c662","ref":"refs/heads/main","pushedAt":"2024-04-29T19:16:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix flaky test failures in ThreadPoolExecutorTest.AddPerf\n\nSummary:\nThe test was intermittently failing because the inner `add` was executing after `stop` stopped the Executor. The fix is to hold a `KeepAlive` while the inner `add` is called, so the `stop` call blocks its shutdown process until all the `add` calls finish.\n\nIn more detail, the failure happened because of an assert failure of `DCHECK(DefaultKeepAliveExecutor->controlBlock_->keepAliveCount_ > 0)` in `DefaultKeepAliveExecutor::keepAliveAcquire`. The `stop` would decrement `DefaultKeepAliveExecutor->controlBlock_->keepAliveCount_` to `0` in `DefaultKeepAliveExecutor::keepAliveRelease`, before the `add` finished acquiring a keep alive token. Holding a keep alive in the tests ensures that `DefaultKeepAliveExecutor->controlBlock_->keepAliveCount_ > 0` while any `add` is takening place.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56654922\n\nfbshipit-source-id: 92f5317a32c7d15feb06b6182fda35e9f23964c5","shortMessageHtmlLink":"Fix flaky test failures in ThreadPoolExecutorTest.AddPerf"}},{"before":"2f1e04807617974c21c5ad7933130569e03e1ba9","after":"ebeafaeb2c482d69958cf2d0e1e3959b139d219c","ref":"refs/heads/main","pushedAt":"2024-04-29T17:55:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"airstore next: bundle V4: thrift working in OSS build\n\nSummary: this diff adds support for thrift in the OSS client build. it changes the `getdeps` airstore manifest to gain access to the thrift cpp2 compiler, then uses a rule similar to other projects to generate the cpp type headers. It changes the OSS `libbundle` library to depend on the thrift types introduced in D56578073 (and, through a lot of pain, get generated in the OSS build stack) which will then be used to ser/de bundles in the OSS build later in the stack!\n\nReviewed By: ASchneidman\n\nDifferential Revision: D56578071\n\nfbshipit-source-id: 1a8d906d0f7a24da21fe7f225fe68644c6bc49d7","shortMessageHtmlLink":"airstore next: bundle V4: thrift working in OSS build"}},{"before":"42ce936ff0abdf994bad7ceec8d7acb63b3d00d8","after":"2f1e04807617974c21c5ad7933130569e03e1ba9","ref":"refs/heads/main","pushedAt":"2024-04-28T17:12:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add libiberty manifest for folly to use\n\nSummary: Add a manifest for libiberty so that folly open source builds pick it up and use the demangler when showing stack traces\n\nReviewed By: dmm-fb\n\nDifferential Revision: D56679872\n\nfbshipit-source-id: 622090112e19a5dd0d2b58a36dead0ea81e89026","shortMessageHtmlLink":"add libiberty manifest for folly to use"}},{"before":"94182f8495c7b153a2341b2503d6536149da108b","after":"42ce936ff0abdf994bad7ceec8d7acb63b3d00d8","ref":"refs/heads/main","pushedAt":"2024-04-28T16:44:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Inherit iterator_category from base iterator.\n\nSummary:\nSingletonThreadLocal and StaticContextAccessor both derive their\nIterators from the accessAllThreads() implementation. They should inherit the\ncategory tag too instead of assuming it is bidirectional.\n\nReviewed By: yfeldblum, ppanchalia\n\nDifferential Revision: D56675899\n\nfbshipit-source-id: 1304c7c8ca691e5de1da5e001312b32c3404fbc8","shortMessageHtmlLink":"Inherit iterator_category from base iterator."}},{"before":"58e8d1a88d6c75547cd7221027ca3d4c78eb08ca","after":"94182f8495c7b153a2341b2503d6536149da108b","ref":"refs/heads/main","pushedAt":"2024-04-28T07:49:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor iterator walk for accessAllThreads\n\nSummary:\nChange the ThreadEntrySet as suggested in D55115468 comments to be a\nvector plus a map of pointers into the vector.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56665857\n\nfbshipit-source-id: 81ba1161b3c388aec05598fa26fecdd7d84b7b33","shortMessageHtmlLink":"Refactor iterator walk for accessAllThreads"}},{"before":"83cad68ea9bc51835926658b8816c5bde7043eab","after":"58e8d1a88d6c75547cd7221027ca3d4c78eb08ca","ref":"refs/heads/main","pushedAt":"2024-04-27T23:49:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix TSAN data race in ThreadLocalDetailTest.MultiThreadedTest\n\nSummary:\nThreadLocalDetailTest.MultiThreadedTest had a data race on std::vector because multiple threads were accessing and modifying the std::vector without a mutex. I update the code to use indexes such that the vector is not updated concurrently.\n\nPrevious run failure that this fixes:\n\n```\nstderr:\n==================\nWARNING: ThreadSanitizer: data race (pid=1249005)\n  Write of size 8 at 0x7fff195936d0 by main thread:\n    #0 std::vector<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>, std::allocator<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>>>::pop_back() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1228 (thread_local_detail_test+0x116c28)\n    #1 folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody() fbcode/folly/detail/test/ThreadLocalDetailTest.cpp:121 (thread_local_detail_test+0x101aba)\n    #2 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) fbsource/src/gtest.cc:2675 (libthird-party_googletest_1.14.0_gtest.so+0xacf3c)\n    #3 testing::Test::Run() fbsource/src/gtest.cc:2692 (libthird-party_googletest_1.14.0_gtest.so+0xacb9c)\n    #4 testing::TestInfo::Run() fbsource/src/gtest.cc:2841 (libthird-party_googletest_1.14.0_gtest.so+0xafa4a)\n    #5 testing::TestSuite::Run() fbsource/src/gtest.cc:3020 (libthird-party_googletest_1.14.0_gtest.so+0xb4303)\n    #6 testing::internal::UnitTestImpl::RunAllTests() fbsource/src/gtest.cc:5925 (libthird-party_googletest_1.14.0_gtest.so+0xd105e)\n    #7 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) fbsource/src/gtest.cc:2675 (libthird-party_googletest_1.14.0_gtest.so+0xd08f1)\n    #8 testing::UnitTest::Run() fbsource/src/gtest.cc:5489 (libthird-party_googletest_1.14.0_gtest.so+0xd037e)\n    #9 RUN_ALL_TESTS() fbsource/gtest/gtest.h:2317 (libcommon_gtest_light_main.so+0x22a7)\n    #10 main fbcode/common/gtest/LightMain.cpp:20 (libcommon_gtest_light_main.so+0x2131)\n\n  Previous read of size 8 at 0x7fff195936d0 by thread T123:\n    #0 std::vector<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>, std::allocator<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>>>::size() const fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:919 (thread_local_detail_test+0x11b0bd)\n    #1 std::vector<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>, std::allocator<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>>>::operator[](unsigned long) fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1045 (thread_local_detail_test+0x11d101)\n    #2 folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0::operator()() const fbcode/folly/detail/test/ThreadLocalDetailTest.cpp:97 (thread_local_detail_test+0x11d08c)\n    #3 void std::__invoke_impl<void, folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0>(std::__invoke_other, folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0&&) fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/invoke.h:61 (thread_local_detail_test+0x11cf95)\n    #4 std::__invoke_result<folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0>::type std::__invoke<folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0>(folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0&&) fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/invoke.h:96 (thread_local_detail_test+0x11cf05)\n    #5 void std::thread::_Invoker<std::tuple<folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0>>::_M_invoke<0ul>(std::_Index_tuple<0ul>) fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/std_thread.h:253 (thread_local_detail_test+0x11cebd)\n    #6 std::thread::_Invoker<std::tuple<folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0>>::operator()() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/std_thread.h:260 (thread_local_detail_test+0x11ce65)\n    #7 std::thread::_State_impl<std::thread::_Invoker<std::tuple<folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody()::$_0>>>::_M_run() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/std_thread.h:211 (thread_local_detail_test+0x11cd79)\n    #8 execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 (libstdc++.so.6+0xdf4e4) (BuildId: 452d1cdae868baeeb2fdf1ab140f1c219bf50c6e)\n\n  Location is stack of main thread.\n\n  Location is global '??' at 0x7fff19575000 ([stack]+0x1e6d0)\n\n  Thread T123 (tid=1249233, running) created by main thread at:\n    #0 pthread_create <null> (thread_local_detail_test+0x156bef)\n    #1 __gthread_create /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/include/x86_64-facebook-linux/bits/gthr-default.h:663:35 (libstdc++.so.6+0xdf80e) (BuildId: 452d1cdae868baeeb2fdf1ab140f1c219bf50c6e)\n    #2 std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State>>, void (*)()) /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:147:37 (libstdc++.so.6+0xdf80e)\n    #3 folly::threadlocal_detail::ThreadLocalDetailTest_MultiThreadedTest_Test::TestBody() fbcode/folly/detail/test/ThreadLocalDetailTest.cpp:93 (thread_local_detail_test+0x1015cd)\n    #4 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) fbsource/src/gtest.cc:2675 (libthird-party_googletest_1.14.0_gtest.so+0xacf3c)\n    #5 testing::Test::Run() fbsource/src/gtest.cc:2692 (libthird-party_googletest_1.14.0_gtest.so+0xacb9c)\n    #6 testing::TestInfo::Run() fbsource/src/gtest.cc:2841 (libthird-party_googletest_1.14.0_gtest.so+0xafa4a)\n    #7 testing::TestSuite::Run() fbsource/src/gtest.cc:3020 (libthird-party_googletest_1.14.0_gtest.so+0xb4303)\n    #8 testing::internal::UnitTestImpl::RunAllTests() fbsource/src/gtest.cc:5925 (libthird-party_googletest_1.14.0_gtest.so+0xd105e)\n    #9 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) fbsource/src/gtest.cc:2675 (libthird-party_googletest_1.14.0_gtest.so+0xd08f1)\n    #10 testing::UnitTest::Run() fbsource/src/gtest.cc:5489 (libthird-party_googletest_1.14.0_gtest.so+0xd037e)\n    #11 RUN_ALL_TESTS() fbsource/gtest/gtest.h:2317 (libcommon_gtest_light_main.so+0x22a7)\n    #12 main fbcode/common/gtest/LightMain.cpp:20 (libcommon_gtest_light_main.so+0x2131)\n\nThreadSanitizer: data race fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:1228 in std::vector<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>, std::allocator<std::unique_ptr<folly::test::Barrier, std::default_delete<folly::test::Barrier>>>>::pop_back()\n==================\nThreadSanitizer: reported 1 warnings\n```\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56643303\n\nfbshipit-source-id: cc364817ae79bc6418cc07faa35e1bcd21830c66","shortMessageHtmlLink":"Fix TSAN data race in ThreadLocalDetailTest.MultiThreadedTest"}},{"before":null,"after":"8572afe82a144a2ff7aa934ea31609f40016ab19","ref":"refs/heads/export-D56654418","pushedAt":"2024-04-26T22:02:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bigfootjon","name":"Jon Janzen","path":"/bigfootjon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6403568?s=80&v=4"},"commit":{"message":"Start rollout to folly\n\nSummary: This enables buck2 for folly. This will presumably be very broken, but we'll iterate from here.\n\nDifferential Revision: D56654418","shortMessageHtmlLink":"Start rollout to folly"}},{"before":"59fcf30c8c056f55be6e1405d06541e5a4ddbec3","after":null,"ref":"refs/heads/fixup-T186965472-main","pushedAt":"2024-04-26T17:55:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bigfootjon","name":"Jon Janzen","path":"/bigfootjon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6403568?s=80&v=4"}},{"before":"ebd05bf0d47af895e0d1b8a495318571ed8345f7","after":"83cad68ea9bc51835926658b8816c5bde7043eab","ref":"refs/heads/main","pushedAt":"2024-04-26T17:55:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bigfootjon","name":"Jon Janzen","path":"/bigfootjon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6403568?s=80&v=4"},"commit":{"message":"Re-sync with internal repository (#2180)\n\nThe internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.\r\n\r\nCo-authored-by: Facebook Community Bot <6422482+facebook-github-bot@users.noreply.github.com>","shortMessageHtmlLink":"Re-sync with internal repository (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2266243768\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/2180\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/2180/hovercard\" href=\"https://github.com/facebook/folly/pull/2180\">#2180</a>)"}},{"before":null,"after":"59fcf30c8c056f55be6e1405d06541e5a4ddbec3","ref":"refs/heads/fixup-T186965472-main","pushedAt":"2024-04-26T17:52:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-sync with internal repository\n\nThe internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.","shortMessageHtmlLink":"Re-sync with internal repository"}},{"before":"47c7d9ad14a2e6e00ddab284916490b601b6cfa9","after":"ebd05bf0d47af895e0d1b8a495318571ed8345f7","ref":"refs/heads/main","pushedAt":"2024-04-26T16:44:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add libdwarf manifest for folly to use\n\nSummary: Give folly depends on and picks up libdwarf, add a manifest for libdwarf to make it explicit and stop it being found via other means\n\nReviewed By: markbt\n\nDifferential Revision: D56630711\n\nfbshipit-source-id: 7b9386b4b93788e7efda13e51e35c9fec4fd6df2","shortMessageHtmlLink":"add libdwarf manifest for folly to use"}},{"before":"6e096ada868ee1ea7cca84ac6367714dcf52f06b","after":"47c7d9ad14a2e6e00ddab284916490b601b6cfa9","ref":"refs/heads/main","pushedAt":"2024-04-26T00:07:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Switch #if to #ifdef for bextr in folly::Bits\n\nSummary: Syntax change to compile cleanly with `[-Werror,-Wundef]`\n\nReviewed By: Orvid\n\nDifferential Revision: D56586926\n\nfbshipit-source-id: 1d32f23e32e2f9d5ee159c53bff7de69bc07aff1","shortMessageHtmlLink":"Switch #if to #ifdef for bextr in folly::Bits"}},{"before":"99c679bd8fc69bfb73d38a6e7fed29daff8894e5","after":"6e096ada868ee1ea7cca84ac6367714dcf52f06b","ref":"refs/heads/main","pushedAt":"2024-04-25T22:59:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Import IOBuf::unshare() to cython\n\nSummary: Unshare helps unbind the folly::IOBuf from an underlying Python bytes object, which prevents a memory leak when not running inside `asyncio` (https://www.internalfb.com/code/fbsource/[51ecc51cc058]/fbcode/folly/python/iobuf_ext.cpp?lines=63)\n\nDifferential Revision: D56528840\n\nfbshipit-source-id: 5a4313c0b822351a0131391bab02d910da148e5c","shortMessageHtmlLink":"Import IOBuf::unshare() to cython"}},{"before":"e08f6ee4ab9006013c98842a18e027a6ed7ee24c","after":"99c679bd8fc69bfb73d38a6e7fed29daff8894e5","ref":"refs/heads/main","pushedAt":"2024-04-25T18:56:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor ThreadWheelTimekeeper to allow use of an existing EventBase thread\n\nSummary: Introduce EventBaseThreadTimekeeper, which schedules timeouts on the EventBase's HHWheelTimer.  ThreadWheelTimekeeper inherits from this, supplying a thread and EventBase, but code running inside an existing EventBase thread can use EventBaseThreadTimekeeper to schedule timeouts without creating another thread.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56168034\n\nfbshipit-source-id: e1961ed3b5f241892d9fbacea669684037a8f0e7","shortMessageHtmlLink":"Refactor ThreadWheelTimekeeper to allow use of an existing EventBase …"}},{"before":"a615f664d59ecbd317817a2c045cf25fb8389b08","after":"e08f6ee4ab9006013c98842a18e027a6ed7ee24c","ref":"refs/heads/main","pushedAt":"2024-04-25T16:12:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix constant float-> int conversion error in folly/experimental/coro/Retry.h\n\nSummary:\nThe current code fails when its target is compiled with\n```\nbuck2 build --config cxx.extra_cxxflags=-Wimplicit-const-int-float-conversion <TARGET>\n```\nbecause of an floating-point to integer conversion overflow error.\n\n**THIS IS A BUG.**\n\nThis diff fixes the situation.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: yfeldblum\n\nDifferential Revision: D54119901\n\nfbshipit-source-id: 2787a0154df624e9ae5f05cd8dcd37e590af6ea0","shortMessageHtmlLink":"Fix constant float-&gt; int conversion error in folly/experimental/coro/…"}},{"before":"325e97b32a48ce20257f2a02ba287d95e51af17f","after":"a615f664d59ecbd317817a2c045cf25fb8389b08","ref":"refs/heads/main","pushedAt":"2024-04-25T11:35:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix darwin boost break on std::piecewise_construct\n\nSummary:\nSince Xcode 15.3 std::piecewise_construct is only visible in c++17 and later modes\n\nstd::piecewise_construct used to be visible in c++03 and later as extensions, see\nhttps://developer.apple.com/documentation/xcode-release-notes/xcode-15_3-release-notes#Deprecations\n\nReviewed By: lebentle\n\nDifferential Revision: D56539492\n\nfbshipit-source-id: 25706bec5aa5a4343a8429eb3d3eeeae9d9a0469","shortMessageHtmlLink":"fix darwin boost break on std::piecewise_construct"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQF8hrwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/folly"}