{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":11131631,"defaultBranch":"main","name":"fbthrift","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-07-02T18:15:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715612599.0","currentOid":""},"activityList":{"items":[{"before":"2c16059cf776b1eea5c003176ccd48ffcb73e8ed","after":"08b6019909d3202353a9c2faa72f10cb3f2f3f1d","ref":"refs/heads/main","pushedAt":"2024-05-16T20:16:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update test fixtures\n\nSummary:\n```\nbuck2 run fbcode//thrift/compiler/test:build_fixtures -- --fixture-root=fbcode/\n```\n\nReviewed By: yoney, praihan\n\nDifferential Revision: D57455236\n\nfbshipit-source-id: 406ab84e6b512535e749e2b50a2fe72fc96bbc67","shortMessageHtmlLink":"Update test fixtures"}},{"before":"0f273aadceb5ea1177220a9b26ebdb3f36f1f929","after":"2c16059cf776b1eea5c003176ccd48ffcb73e8ed","ref":"refs/heads/main","pushedAt":"2024-05-16T19:39:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add folly::doNotOptimizeAway to ProtocolBenchmark\n\nReviewed By: vitaut\n\nDifferential Revision: D57394998\n\nfbshipit-source-id: 6a912da7a1153d0668f1606bcffc93f0af10dc9f","shortMessageHtmlLink":"Add folly::doNotOptimizeAway to ProtocolBenchmark"}},{"before":"bde6e51a7b8d25adb7d273e8c2ef4b0e689f2a0f","after":"0f273aadceb5ea1177220a9b26ebdb3f36f1f929","ref":"refs/heads/main","pushedAt":"2024-05-16T19:31:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Log Effective Ticket Seeds Policy\n\nSummary:\n- Adding a new field effective_ticket_seed_strategy to Server Event Logging to log what was the ticket seeds strategy used for the server.\n- Adding a new enum EffectiveTicketSeedStrategy to differentiate between 3 different types of ticket seeds strategies: FILE, IN_MEMORY, and IN_MEMORY_WITH_ROTATION, and changing `shouldScheduleInMemoryTicketSeeds` to `getEffectiveTicketSeedStrategy`\n\nReviewed By: frqiu\n\nDifferential Revision: D57361329\n\nfbshipit-source-id: 52002421c721c1bd0269f90ff7b6738f4618cc55","shortMessageHtmlLink":"Log Effective Ticket Seeds Policy"}},{"before":"1b15c884f58cf5cc88a880032b6a58c37a3a7c6f","after":"bde6e51a7b8d25adb7d273e8c2ef4b0e689f2a0f","ref":"refs/heads/main","pushedAt":"2024-05-16T18:06:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Soft-inline Thrift (de)serialization functions\n\nSummary:\n**TL;DR Inlining Thrift (de)serialization functions significantly improves observed wall clock latencies for almost all workloads with only minimal impact to binary size but a measurable impact to build times.**\n\nIf this proposal sounds familiar, it's because it's an updated version of [this one](https://fb.workplace.com/groups/rust.libraries.wg/posts/2267253036959522/) and this diff D57312501 :)\n\nFull RFC and discussion in [this post](https://fb.workplace.com/groups/rust.libraries.wg/permalink/2268674973483995/).\n\nIn local tests, using the Thrift loadgen framework to attempt a consistent QPS for reproducibility, results were overall positive in reducing observed latency.\n\nOverall, in numbers:\n* 49.63% improvement for P50\n* 49.95% improvement for AVG\n* 62.41% improvement for P99\n\nAutomated build time regression analysis found that there was a 30%-40% increase in build times for the NodeAPI compiler (P1364121390 - wall clock, 1m-4m regression). This is actually an improvement over the previous regression of 400%-500% (P1364124026) for the `#[inline(always)]` version.\n\nReviewed By: jsgf, shayne-fletcher\n\nDifferential Revision: D57419887\n\nfbshipit-source-id: 5ed0b3056c2a3dc5c17cb95b4982aa9d862fbcf2","shortMessageHtmlLink":"Soft-inline Thrift (de)serialization functions"}},{"before":"8ebb3a56d93b3fb884cc1a87c5cb884c65a93e5b","after":"1b15c884f58cf5cc88a880032b6a58c37a3a7c6f","ref":"refs/heads/main","pushedAt":"2024-05-16T16:37:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/2753451d68b7ffcdbd5bcb8f6ff6719e705e303a\nhttps://github.com/facebook/fb303/commit/e54973885c3b543b41f2167a0cf0325363c36421\nhttps://github.com/facebook/fbthrift/commit/8ebb3a56d93b3fb884cc1a87c5cb884c65a93e5b\nhttps://github.com/facebook/folly/commit/021cb16f2231355126f665b6bb2d65ad4487ae6d\nhttps://github.com/facebook/mvfst/commit/9d16a6ebea6a6b03ebeff9db4355c840bf19104d\nhttps://github.com/facebook/proxygen/commit/98d508843a6aadf42237d381f6d468d0de6b2920\nhttps://github.com/facebook/wangle/commit/8935b00b4b09ed709d360de847a7c55dd133fa21\nhttps://github.com/facebookexperimental/edencommon/commit/ec32ad7108b48c9541186a010bcdb86516a72e50\nhttps://github.com/facebookexperimental/rust-shed/commit/e9517e776ecbe0065ed808f367846ccf3afafd8e\nhttps://github.com/facebookexternal/plc-code/commit/12e9c56e378f3ae1e2617887b7b92a1b4caeb2a8\nhttps://github.com/facebookincubator/fizz/commit/3b3c3f043f811abcb50f7579ffdac1269f85e8e2\n\nReviewed By: ajb85\n\nfbshipit-source-id: f5f8c926ed497e5dd24ca56b1564926dfb495d51","shortMessageHtmlLink":"Updating submodules"}},{"before":"5691838becac25c0f60d8858a9e1041684d9e575","after":"8ebb3a56d93b3fb884cc1a87c5cb884c65a93e5b","ref":"refs/heads/main","pushedAt":"2024-05-16T11:04:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D57404528: Multisect successfully blamed \"D57404528: Reland \"Merge thrift py3 and thrift python client request channel definitions into a single file\" ... again\" for one test failure\n\nSummary:\nThis diff reverts D57404528\nDepends on D57430549\nD57404528: Reland \"Merge thrift py3 and thrift python client request channel definitions into a single file\" ... again by Filip-F causes the following test failure:\n\nTests affected:\n- [cogwheel:cogwheel_conductor#main](https://www.internalfb.com/intern/test/844425041013411/)\n\nHere's the Multisect link:\nhttps://www.internalfb.com/multisect/5102759\nHere are the tasks that are relevant to this breakage:\n\nThe backout may land if someone accepts it.\n\nIf this diff has been generated in error, you can Commandeer and Abandon it.\n\nReviewed By: fejese\n\nDifferential Revision: D57430590\n\nfbshipit-source-id: a673e2fd29b21d0043493713c151b7198e7a88ad","shortMessageHtmlLink":"Revert D57404528: Multisect successfully blamed \"D57404528: Reland \"M…"}},{"before":"9ac1c71cb2da9d2dabc5fe0e19097b849a22c615","after":"5691838becac25c0f60d8858a9e1041684d9e575","ref":"refs/heads/main","pushedAt":"2024-05-16T07:12:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Eliminate builders (thrift)\n\nSummary: Builders are going away. Replace with `New` and setters.\n\nReviewed By: awalterschulze\n\nDifferential Revision: D57420167\n\nfbshipit-source-id: 2e90db09c103da15ccfc7d9ee83687f9fae0d1ff","shortMessageHtmlLink":"Eliminate builders (thrift)"}},{"before":"c7ba3c50980dc2bb997dee1fe9455eadb63b6aa9","after":"9ac1c71cb2da9d2dabc5fe0e19097b849a22c615","ref":"refs/heads/main","pushedAt":"2024-05-16T07:03:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Eliminate builders (conformance)\n\nSummary: Builders are going away. Replace with `New` and setters.\n\nReviewed By: awalterschulze\n\nDifferential Revision: D57419811\n\nfbshipit-source-id: 7211edf23d01e8cb5c4f535ed8ec1efbf78dae02","shortMessageHtmlLink":"Eliminate builders (conformance)"}},{"before":"68e899ebbeba4c378638019b9121d0956100a441","after":"c7ba3c50980dc2bb997dee1fe9455eadb63b6aa9","ref":"refs/heads/main","pushedAt":"2024-05-16T04:21:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reland \"Merge thrift py3 and thrift python client request channel definitions into a single file\" ... again\n\nSummary: Landing this again again D57133616\n\nReviewed By: ahilger\n\nDifferential Revision: D57404528\n\nfbshipit-source-id: b1d8562fb28b28b3a5f69f398457fe16de8d6859","shortMessageHtmlLink":"Reland \"Merge thrift py3 and thrift python client request channel def…"}},{"before":"d3c098454b8f12f5629f2bba7639347c80ce788c","after":"68e899ebbeba4c378638019b9121d0956100a441","ref":"refs/heads/main","pushedAt":"2024-05-16T00:43:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add union_test, to prepare for mutable Union support\n\nReviewed By: yoney\n\nDifferential Revision: D57395267\n\nfbshipit-source-id: d1b0053c1fbf54ade8d68683784916eda403e7e1","shortMessageHtmlLink":"Add union_test, to prepare for mutable Union support"}},{"before":"5dc09b54aefa4eb77a39f80e4f7592cf172c4eaa","after":"d3c098454b8f12f5629f2bba7639347c80ce788c","ref":"refs/heads/main","pushedAt":"2024-05-16T00:31:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't crash when serialize_with_header throws\n\nSummary: This method can throw exceptions, but wasn't marked with except + so it could crash the whole program if serialize_with_header threw.\n\nReviewed By: yoney, ahilger\n\nDifferential Revision: D57363854\n\nfbshipit-source-id: 7464553a34d6f24cb8c1a3789f0df9995c9d3e0a","shortMessageHtmlLink":"Don't crash when serialize_with_header throws"}},{"before":"7d01e33f17aaa5b6b318a53f54984e636ad17505","after":"5dc09b54aefa4eb77a39f80e4f7592cf172c4eaa","ref":"refs/heads/main","pushedAt":"2024-05-16T00:25:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim VirtualExecutor in thrift\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly:virtual_executor -> //folly/executors:virtual_executor\n```\n\nThe following headers were deshimmed:\n```\nfolly/VirtualExecutor.h -> folly/executors/VirtualExecutor.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: vitaut\n\nDifferential Revision: D57217657\n\nfbshipit-source-id: f02efff8358461fb61b469b4160059ef0e65447e","shortMessageHtmlLink":"Deshim VirtualExecutor in thrift"}},{"before":"aaae943847e0af36a37bee745e659cb9fb4c6e7e","after":"7d01e33f17aaa5b6b318a53f54984e636ad17505","ref":"refs/heads/main","pushedAt":"2024-05-16T00:15:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make __fromShape codegen cheaper to typecheck\n\nSummary:\nIn Hack Thrift codegen, `__fromShape` codegen generates code of the following form:\n\n```\nShapes::idx($shape, 'key') === null ? null : (Foo::__fromShape($shape['key']))\n```\n\nIt'll generate one of these per constructor parameter which can get quite big in case of compiling large unions.\n\nEach of these refine the type of `$shape` in branches of the ternary expression. In one branch, it'll definitely have the key `'key'` and in the other it'll be optional. On the exist these two types need to be consolidated to obtain what we started with. This can get very expensive.\n\nThis diff changes the code generator for this pattern slightly to avoid the definement on `$shape` and consequently the expensive type consolidation.\n\nThe new code generated looks as follows:\n```\nShapes::idx($shape, 'key') |> $$ === null ? null : (Foo::__fromShape($$))\n```\n\nReviewed By: rmakheja\n\nDifferential Revision: D56428792\n\nfbshipit-source-id: 937f8a954df4cf9a4065b4f7a5729d813a6ae07c","shortMessageHtmlLink":"Make __fromShape codegen cheaper to typecheck"}},{"before":"d3018b5f2999cf2fc6615a9858d792fb2106e9fe","after":"aaae943847e0af36a37bee745e659cb9fb4c6e7e","ref":"refs/heads/main","pushedAt":"2024-05-15T23:44:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ensure wangle::TransportInfo securityType is correct for StopTLS\n\nSummary:\n`wangle::TransportInfo` `securityType` should be a copy of the handshake layer's\nsecurity protocol by the time the application `onNewConnection` method is invoke.\n\nThis is the case for the normal OpenSSL handshake and FizzAcceptorHandshakeHelper.\n\nThrift adds another step for StopTLS handshakes, and StopTLS is implemented as a\nseparate transport with a unique security type, so this diff ensures that\n`securityType` is still accurate.\n\nReviewed By: stuclar\n\nDifferential Revision: D57394275\n\nfbshipit-source-id: f8051de3598a8d8e8f84bce5ea58c6e6c66eeb0a","shortMessageHtmlLink":"Ensure wangle::TransportInfo securityType is correct for StopTLS"}},{"before":"b825e35a2c2a0cbe692d9fdb87297298e44d2758","after":"d3018b5f2999cf2fc6615a9858d792fb2106e9fe","ref":"refs/heads/main","pushedAt":"2024-05-15T23:25:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"support thrift compiler rust 'any' codegen option\n\nSummary: extend the rust thrift generator options to include `any` (same meaning as the equivalent cpp2 generator option).\n\nReviewed By: dtolnay\n\nDifferential Revision: D57387655\n\nfbshipit-source-id: c3c712ad54666cb3ae2ccad7baf3f5e0625164c0","shortMessageHtmlLink":"support thrift compiler rust 'any' codegen option"}},{"before":"fc536052f4cc73d50cf57c1ada0af4336e0dad23","after":"b825e35a2c2a0cbe692d9fdb87297298e44d2758","ref":"refs/heads/main","pushedAt":"2024-05-15T23:05:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Initial implementation for `MutableSet`\n\nSummary:\nThis is an initial implementation for the Thrift `MutableSet`. It implements `MutableSet` from the [collections abstract base classes](https://docs.python.org/3.10/library/collections.abc.html#collections-abstract-base-classes). However, not all abstract methods are implemented; these can be completed later.\nWhile the implementation could be optimized, especially for integral types, it is not within the scope of this diff.\n\nReviewed By: aristidisp\n\nDifferential Revision: D57265231\n\nfbshipit-source-id: bcc49f9c5b2f493f12e307539969accd583c383e","shortMessageHtmlLink":"Initial implementation for MutableSet"}},{"before":"f7c075d5bb8fce3a21f2887125cbeeba97b8f8ad","after":"fc536052f4cc73d50cf57c1ada0af4336e0dad23","ref":"refs/heads/main","pushedAt":"2024-05-15T22:23:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Implement `same_as()` for `TypeInfo` classes\n\nSummary: Implement the `same_as()` method for `TypeInfo` classes. This is necessary for comparing `TypeInfo` classes when determining if two containers are of the same type.\n\nReviewed By: aristidisp\n\nDifferential Revision: D57261013\n\nfbshipit-source-id: 50ef6b1a8851f8c6a24c101f135a931bc2c83d13","shortMessageHtmlLink":"Implement same_as() for TypeInfo classes"}},{"before":"e91797e1350fe6c4029a1b0c5619ddfbc5c34286","after":"f7c075d5bb8fce3a21f2887125cbeeba97b8f8ad","ref":"refs/heads/main","pushedAt":"2024-05-15T21:08:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix: suppress clang -Wc99-extensions on flexible array members (#602)\n\nSummary: Pull Request resolved: https://github.com/facebook/fbthrift/pull/602\n\nReviewed By: iahs\n\nDifferential Revision: D57380642\n\nPulled By: yfeldblum\n\nfbshipit-source-id: b6358c3772bbf99dc6b4d2d05b17a70c00d140b6","shortMessageHtmlLink":"fix: suppress clang -Wc99-extensions on flexible array members (#602)"}},{"before":"b87fa9b166e3f8eb16d70b1ed82d6b2921164d6f","after":"e91797e1350fe6c4029a1b0c5619ddfbc5c34286","ref":"refs/heads/main","pushedAt":"2024-05-15T18:33:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Disable builders by default\n\nSummary:\nDisable builders by default.\nThey will soon be deprecated and removed completely.\n\nReviewed By: awalterschulze\n\nDifferential Revision: D57360149\n\nfbshipit-source-id: c2ee00c45c92b1a36828cd11396d850a6ed1611b","shortMessageHtmlLink":"Disable builders by default"}},{"before":"1b373c9a4078ecf7f5a379a73d4fed293a7d20ab","after":"b87fa9b166e3f8eb16d70b1ed82d6b2921164d6f","ref":"refs/heads/main","pushedAt":"2024-05-15T17:52:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix for a -Wshorten-64-to-32 warning\n\nSummary: Fix for a -Wshorten-64-to-32 warning\n\nReviewed By: r-barnes\n\nDifferential Revision: D57366684\n\nfbshipit-source-id: d58bbb1099d46a38013b0462f0ac315962e1a126","shortMessageHtmlLink":"Fix for a -Wshorten-64-to-32 warning"}},{"before":"087cb84a1430d02bc633f5de69466b9141ca09d0","after":"1b373c9a4078ecf7f5a379a73d4fed293a7d20ab","ref":"refs/heads/main","pushedAt":"2024-05-15T16:36:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/a7518185c17baca7a7cea7ff6578aa6859ef703f\nhttps://github.com/facebook/fb303/commit/03f8a8d3b60eb7ef2e0eb5395398777f87c92a6c\nhttps://github.com/facebook/fbthrift/commit/087cb84a1430d02bc633f5de69466b9141ca09d0\nhttps://github.com/facebook/folly/commit/8fa9517b3ae1a399024184539f5545f74986106f\nhttps://github.com/facebook/mvfst/commit/d73e56102780ef84b735dc196bb1adee8ab7ffd9\nhttps://github.com/facebook/proxygen/commit/ce4dfee0e3466efc5a77d661d2befde8f997086c\nhttps://github.com/facebook/wangle/commit/67ad5d06fe8b4251fb78475211ee9ff818294bed\nhttps://github.com/facebookexperimental/edencommon/commit/bd83b9dc6facd8e5401a4f66d9708c1eb4355907\nhttps://github.com/facebookexperimental/rust-shed/commit/9d0090c5959fba95b557a390c98522a1c5b9efa8\nhttps://github.com/facebookincubator/fizz/commit/6515c394dcc483db71a762d347c3d7821685ac7e\n\nReviewed By: ajb85\n\nfbshipit-source-id: 2b82420d45555856c763ef71a1b7332b3eb4213b","shortMessageHtmlLink":"Updating submodules"}},{"before":"faf057e03ff6875d51bca155ca1ec37137436d43","after":"087cb84a1430d02bc633f5de69466b9141ca09d0","ref":"refs/heads/main","pushedAt":"2024-05-15T13:10:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D57133618: Move common and std_libcpp from thrift/lib/py3 to thrift/lib/python\n\nDifferential Revision:\nD57133618\n\nOriginal commit changeset: 154fa00c6c5e\n\nOriginal Phabricator Diff: D57133618\n\nfbshipit-source-id: 2827d614a04fdc6d959007e93f3de6e4b7574ed0","shortMessageHtmlLink":"Revert D57133618: Move common and std_libcpp from thrift/lib/py3 to t…"}},{"before":"32aaddc83b2ff400eaef1cb1fb7fdff22e1c432e","after":"faf057e03ff6875d51bca155ca1ec37137436d43","ref":"refs/heads/main","pushedAt":"2024-05-15T12:18:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reland \"Merge thrift py3 and thrift python client request channel definitions into a single file\"\n\nSummary:\nThe original diff broke when it landed due to dependency graph issues (that I really don't understand why they weren't caught by sandcastle tests), so relanding now after fixing that.\n\nOriginal Phabricator Diff: D56998443\n\nReviewed By: ahilger\n\nDifferential Revision: D57133616\n\nfbshipit-source-id: 32c6f53dc96afadc2e5351e67c88056144e5e739","shortMessageHtmlLink":"Reland \"Merge thrift py3 and thrift python client request channel def…"}},{"before":"5dc82eedb1ff41fcca7f45ae7c57252e20934e8e","after":"32aaddc83b2ff400eaef1cb1fb7fdff22e1c432e","ref":"refs/heads/main","pushedAt":"2024-05-15T00:19:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move patch documentations out of public folder\n\nReviewed By: thedavekwon\n\nDifferential Revision: D57340450\n\nfbshipit-source-id: b096f96e76b7e995bf2cd24f34c9dc36d03e5a16","shortMessageHtmlLink":"Move patch documentations out of public folder"}},{"before":"d0129bca475fed3f5b6ac8eafd00be44c144d0da","after":"5dc82eedb1ff41fcca7f45ae7c57252e20934e8e","ref":"refs/heads/main","pushedAt":"2024-05-14T21:30:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"deprecated_any: remove dead code\n\nSummary: the key contribution of this diff is to remove 'fbcode/icsp/rust/deprecated_any/src/any.rs' since it's no longer used. incidentally fold 'fbcode/thrift/lib/rust/conformance/src/tests/any_registry.rs' into 'fbcode/thrift/lib/rust/conformance/src/any_registry.rs' and remove that file and 'fbcode/thrift/lib/rust/conformance/src/tests/TARGETS' too.\n\nReviewed By: diliop\n\nDifferential Revision: D57344788\n\nfbshipit-source-id: 6287817acba5c0db0d5b8d3900ade04578c53732","shortMessageHtmlLink":"deprecated_any: remove dead code"}},{"before":"25ea871489988eb4233fcb9fce003ea2af28d094","after":"d0129bca475fed3f5b6ac8eafd00be44c144d0da","ref":"refs/heads/main","pushedAt":"2024-05-14T21:07:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Templatize the `SetTypeInfo` for internal data container type\n\nSummary: Templatize the `SetTypeInfo` and rename it to `SetTypeInfoTemplate`. The template parameter `T` provides `create()` and `reset()` methods for the internal data container. For immutable Thrift structs, the internal data container is a Python `Frozenset`.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D57338687\n\nfbshipit-source-id: faf232a7cc079176a461ed6501d6716033ae2fa3","shortMessageHtmlLink":"Templatize the SetTypeInfo for internal data container type"}},{"before":"aed24276c4ac53b8984389bc836be5c77c4c7ba9","after":"25ea871489988eb4233fcb9fce003ea2af28d094","ref":"refs/heads/main","pushedAt":"2024-05-14T20:10:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"conformance: first cut at extending registry with serializers to/from std::any::Any\n\nSummary: extend the any registry with functions that provide serialization through `std::any::Any`.\n\nReviewed By: dtolnay\n\nDifferential Revision: D57338182\n\nfbshipit-source-id: efdcad307a17ef3231f4065ca67844992eda3108","shortMessageHtmlLink":"conformance: first cut at extending registry with serializers to/from…"}},{"before":"d1fdfe38debe97d50a9fff3f1197b0db8924372c","after":"aed24276c4ac53b8984389bc836be5c77c4c7ba9","ref":"refs/heads/main","pushedAt":"2024-05-14T19:50:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not use a getter to access field internally\n\nSummary: Accessing struct fields directly (as opposed to using a getter method) simplifies escape analysis and speeds up the build.\n\nDifferential Revision: D57303310\n\nfbshipit-source-id: 6779a40f89998c96c7770fedfea048411206f236","shortMessageHtmlLink":"Do not use a getter to access field internally"}},{"before":"033bccf01c8ab58c534a625e3476be8b3dfd34cf","after":"d1fdfe38debe97d50a9fff3f1197b0db8924372c","ref":"refs/heads/main","pushedAt":"2024-05-14T17:37:02.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Introduce protocol::asObject\n\nSummary: Introduce `protocol::asObject` to reduce DRY\n\nReviewed By: Mizuchi\n\nDifferential Revision: D57227629\n\nfbshipit-source-id: d1faa3c4c096a0b0ab56d28d3de0b80d12012cd1","shortMessageHtmlLink":"Introduce protocol::asObject"}},{"before":"ff014ba47ecaf40a87034db05cf0835dd9c7e765","after":"033bccf01c8ab58c534a625e3476be8b3dfd34cf","ref":"refs/heads/main","pushedAt":"2024-05-14T16:42:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/dcc43407e0018062b8ba4e69d26c028da4e43014\nhttps://github.com/facebook/fb303/commit/2a8ffe3a4048f3b71e9c315036a8f46248f14ecd\nhttps://github.com/facebook/fbthrift/commit/3117fe09259309c8d04dc9e39ea1d5bdc0625460\nhttps://github.com/facebook/folly/commit/99767aa88e8fd77823c870491d639723cf570b9d\nhttps://github.com/facebook/mvfst/commit/d3d25ecaad1b7f83cfb71b2403dadecd9c4142ac\nhttps://github.com/facebook/proxygen/commit/b5b54c64fe0174e9783af064b7f0e604653e5cdf\nhttps://github.com/facebook/wangle/commit/f5a06feda8309c30e83b8c90ff9e3c3f756a36d1\nhttps://github.com/facebookexperimental/edencommon/commit/c5554eefc8589415c56057fd47eae67678841947\nhttps://github.com/facebookexperimental/rust-shed/commit/5a39427e0989f9fd058bb9f49a8c886855b4676b\nhttps://github.com/facebookincubator/fizz/commit/e5bee2e59f7986a6a5be554a9750848dfedd55cf\n\nReviewed By: ajb85\n\nfbshipit-source-id: 335cacfd249d5dc0444dd4ce73f53a77f4e6ca2f","shortMessageHtmlLink":"Updating submodules"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETAkQGQA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fbthrift"}