Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleNotFoundError: No module named 'fboss.fb_thrift_clients' #110

Open
pettershao-ragilenetworks opened this issue Nov 10, 2021 · 1 comment
Open

ModuleNotFoundError: No module named 'fboss.fb_thrift_clients' #110

pettershao-ragilenetworks opened this issue Nov 10, 2021 · 1 comment

Comments

@pettershao-ragilenetworks
Copy link

seems miss fb_thrift_clients.py, please help check, thanks!

[root@bogon fboss-py]# ./fboss/cli/cli.py --help
Traceback (most recent call last):
  File "./fboss/cli/cli.py", line 34, in <module>
    from fboss.fb_thrift_clients import FbossAgentClient
ModuleNotFoundError: No module named 'fboss.fb_thrift_clients'
@pettershao-ragilenetworks
Copy link
Author

@shri-khare
Hi Shrikrishna Khare,
I am doing some fboss experiment locally, but when I do py cli show, it remind me that can’t find fb_thrift_clients.py, could help share me this file(also I am using fboss2 to show, but you know it support only a little commands), thanks!

facebook-github-bot pushed a commit that referenced this issue Feb 16, 2022
@ahornby @facebook-github-bot
improve crate vendoring (#110)
a3a7cf2 
Summary:
Pull Request resolved: facebook/sapling#110

Pull Request resolved: facebookexperimental/rust-shed#27

Make it so that changes to rust-shed or other common rust source are used locally vendored, so they don't need to be pushed to github before they are visible in a build.

There was already some support for cargo vendoring in getdeps, but it was limited to dependencies between manifests built with cargo builder.  This wasn't enough to build something like eden (cmake is main entry point, with later calls cargo) or eden_scm (make is main entry point, with later calls to cargo), so this diff adds a cargo prepare step for getdeps other primary build systems.

The cargo vendoring is done by using a cargo config file to point to the source files used by getdeps.  It has two modes:

1. per crate, existing mode which is already automatic for cargo to cargo manifest dependencies.  To use it for a non cargo build manifest, add crate.pathmap
2. per git url, existing mode which was only use for crates.io third-party crates, now can be enabled by setting cargo.cargo_config_file

Reviewed By: yancouto

Differential Revision: D33895469

fbshipit-source-id: 7b13c0b679532492a336ce217de875c25fe1be90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pettershao-ragilenetworks