{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":540915415,"defaultBranch":"main","name":"buck2-prelude","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-09-24T17:42:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1699867592.0","currentOid":""},"activityList":{"items":[{"before":"805c3cc31bd1731ff58786ffccdfcc85a2008164","after":"d9fba1f232ba6528d9f107a01d7feb11dd50264e","ref":"refs/heads/main","pushedAt":"2024-05-20T10:48:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Compile kernels with standard buck2 c++ rules\"\n\nSummary:\nOriginal commit changeset: cc647ba0ade7\n\nOriginal Phabricator Diff: D54912072\n\n# Related broken test and build posts:\nhttps://fb.workplace.com/groups/mtiadev/posts/1164191554625364/\nhttps://fb.workplace.com/groups/mtiadev/posts/1162808128097040/\n\n# Fix Backward/Forward\nWe will back out original diff first to unblock developers if there's no quick fix for raised issues.\n\nReviewed By: openrichardfb\n\nDifferential Revision: D57546417\n\nfbshipit-source-id: 9a3a9231f9ba713abc9a8375aaf075d543acfc01","shortMessageHtmlLink":"Back out \"Compile kernels with standard buck2 c++ rules\""}},{"before":"fae65cad8333db0ebc3d20fa24629e961bba5616","after":"805c3cc31bd1731ff58786ffccdfcc85a2008164","ref":"refs/heads/main","pushedAt":"2024-05-20T02:32:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support native libraries for instrumentation_test_listener\n\nSummary: As title, this is needed to get rsys service working\n\nReviewed By: IanChilds\n\nDifferential Revision: D57396815\n\nfbshipit-source-id: 569a207f9764627d18e72d7c07678384845f199f","shortMessageHtmlLink":"Support native libraries for instrumentation_test_listener"}},{"before":"0d55ff5aff56b9103126975239ec5715e83cbac6","after":"fae65cad8333db0ebc3d20fa24629e961bba5616","ref":"refs/heads/main","pushedAt":"2024-05-18T17:21:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make sure to default to K1\n\nSummary:\nHonestly the `kotlin.use_k2` property is a bit misleading right now, since if you set it to true, then **maybe** you will use k2.\n\nI'm replacing it with something a bit more clear here, which I called `kotlin.language_version`\n```\nforce_k1:\n Use K1 for all targets\n\nforce_k2:\n Use K2 for all targets\n\nfrom_kotlin_version:\n K2 if on Kotlin 2.0+ (default of Kotlin)\n\ndefined_by_target (default):\n Current state of things. The target `k2` param defines what frontend compiler to use, where `k2 == true` means to use K2\n```\n\n## Kotln 2.0\nWhile Kotlin 2.0 has K2 as the default, this change will keep K1 as the default, which is what we want for now\n\nReviewed By: pengj\n\nDifferential Revision: D56069029\n\nfbshipit-source-id: 0a701ce51899b4abf411aedb7ec3aee6fa820b4b","shortMessageHtmlLink":"Make sure to default to K1"}},{"before":"199e4dca9917c6f1385dd18919567e9cf70bfed3","after":"0d55ff5aff56b9103126975239ec5715e83cbac6","ref":"refs/heads/main","pushedAt":"2024-05-17T22:47:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move linker_wrapper out of prelude\n\nSummary: Title\n\nReviewed By: chatura-atapattu\n\nDifferential Revision: D57341446\n\nfbshipit-source-id: e495183e22f3a3f4b4d8af1c228c88ea8d914731","shortMessageHtmlLink":"Move linker_wrapper out of prelude"}},{"before":"386fdd5f73c0f2bc0ba4e734edbdc6e2d2a3ab30","after":"199e4dca9917c6f1385dd18919567e9cf70bfed3","ref":"refs/heads/main","pushedAt":"2024-05-17T21:53:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"ide bxl script takes absolute paths\n\nSummary:\nthere's no need to query for root in the sourcedb bxl script if the bxl owners query will do it. this change makes calling the script easier as it now just takes absolute path as an input.\n\nnote: this will temporarily break the pyright buck integration as this changes goes out in fbsource version control and the corresponding language server change (next diff) goes out in the extension). this is ok as it hasn't been released yet.\n\nReviewed By: ljw1004\n\nDifferential Revision: D57382833\n\nfbshipit-source-id: 68dc8615548631a8f35939aa11f345dccadf29cc","shortMessageHtmlLink":"ide bxl script takes absolute paths"}},{"before":"bdac71ca0fe8be7d73e36b5cf97e219977a43845","after":"386fdd5f73c0f2bc0ba4e734edbdc6e2d2a3ab30","ref":"refs/heads/main","pushedAt":"2024-05-17T20:49:23.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add sources.jar for android_aar\n\nSummary: We just get all the `sources_jar` artifacts from our packaging deps and combine them all together using `jar_builder`.\n\nReviewed By: navidqar\n\nDifferential Revision: D57491326\n\nfbshipit-source-id: ad56b74a1342c7a97acb3d96f1f1b7a902c37a0c","shortMessageHtmlLink":"Add sources.jar for android_aar"}},{"before":"2430a6708954aed757b9ef1854694f0f9aee2bd1","after":"bdac71ca0fe8be7d73e36b5cf97e219977a43845","ref":"refs/heads/main","pushedAt":"2024-05-17T20:31:36.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Set link options correctly for dist_lto + apple_library\n\nSummary:\nThe enable_distributed_thinlto attribute on apple_library was not respected. Specify\nlink options when building a cxx_library according to the attribute.\n\nReviewed By: rmaz\n\nDifferential Revision: D57338289\n\nfbshipit-source-id: b60cbc4e1e62cf21d90af7d241649aec3c068359","shortMessageHtmlLink":"Set link options correctly for dist_lto + apple_library"}},{"before":"5df4ec0b8d475cccf4b67181c9f3b33da736033b","after":"2430a6708954aed757b9ef1854694f0f9aee2bd1","ref":"refs/heads/main","pushedAt":"2024-05-17T18:56:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove extraNonSourceOnlyAbiKotlincArguments\n\nSummary:\nIntroduced on D44060005 by natestedman\n\nKosabi needs to run with K1 while we don't support K2.\n\nKotlin 2.0 makes K2 the default, unless we supply `-language-version=1.9` as a param, which we now do for all Kosabi builds.\n\n### Protobuf\nRegenerated following instructions from [this doc](https://docs.google.com/document/d/1dYW8o8TncXyIe6Y_xjjUYXud8aTjfO1x7i9rNRNFxq0/edit#heading=h.br7720p9xya)\n\nReviewed By: nghuiqin\n\nDifferential Revision: D56357671\n\nfbshipit-source-id: dda5813fa682ee5cd80e4a1617cba641077516cd","shortMessageHtmlLink":"Remove extraNonSourceOnlyAbiKotlincArguments"}},{"before":"9ce200ebdaecf0a5906adaa8aa8cbf128c57c3a3","after":"5df4ec0b8d475cccf4b67181c9f3b33da736033b","ref":"refs/heads/main","pushedAt":"2024-05-17T17:06:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"buck2 | xcframework | Optionally copy -Swift.h\n\nSummary:\n## What this diff does:\nIt copies any generated -Swift.h header for the single dependency that is given as the `binary` field in the `apple_bundle` for a framework iff `copy_public_framework_headers` is set to `True`.\n\n## What this diff does not do:\nGenerate and include a -Swift.h header that reflects all public/open Swift entities in the full dependency graph.\n1) This seems hard to do\n2) This might be counter-productive as the pattern for Swift+Buck seems to be to make each buck target correspond to a module. With this pattern the right thing to do would be to create a separate [xc]framework per module.\n\nReviewed By: milend\n\nDifferential Revision: D57215035\n\nfbshipit-source-id: 2e4823cf75e182c8ddabf1a87c87aaacb2f94d83","shortMessageHtmlLink":"buck2 | xcframework | Optionally copy -Swift.h"}},{"before":"2309a8c63594d9a5d85ccbf660c7882f8ed13826","after":"9ce200ebdaecf0a5906adaa8aa8cbf128c57c3a3","ref":"refs/heads/main","pushedAt":"2024-05-17T15:38:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add target_sdk_version attributes to cxx_toolchain\n\nSummary: cxx_binary rules building on Darwin need to be able to handle deployment target specification. Add some attributes to cxx_toolchain and CxxToolchainInfo so we can support that.\n\nReviewed By: milend\n\nDifferential Revision: D57441943\n\nfbshipit-source-id: 1224196affb176520d108a8cc413e56d7e6b0526","shortMessageHtmlLink":"add target_sdk_version attributes to cxx_toolchain"}},{"before":"eb84a30b1ab99557a8682a79396cb3b8a9065b0e","after":"2309a8c63594d9a5d85ccbf660c7882f8ed13826","ref":"refs/heads/main","pushedAt":"2024-05-17T14:29:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"return absolute paths in elp.bxl\n\nSummary:\nAs title.\nAlso drop off trailing file name from includes directory and dedup what remains\n\nReviewed By: TheGeorge\n\nDifferential Revision: D57489513\n\nfbshipit-source-id: b00381d510966c169cc6c3a865fa4b237a0746fe","shortMessageHtmlLink":"return absolute paths in elp.bxl"}},{"before":"5b8fbffe24105918c08ac08310c6e6f13cf8dab6","after":"eb84a30b1ab99557a8682a79396cb3b8a9065b0e","ref":"refs/heads/main","pushedAt":"2024-05-17T10:57:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add elp.bxl to erlang prelude\n\nSummary:\nCurrently [ELP](https://github.com/WhatsApp/erlang-language-platform) uses a hard-coded buck2 query to retrieve the project model when loading a buck2 project.\nThis mostly works, but does not always resolve include paths correctly, and so reports spurious unresolved include file errors for files that compile with buck2\nThis script is an evolution of that hard-coded query. If used without the `--deps_includes true` flag it provides equivalent information.\nIf the flag is set, it includes extended include path information.\nThe extended information is done this way to allow a controlled rollout, with a fallback position if there is a problem. In time it may be discarded.\n\nReviewed By: TheGeorge\n\nDifferential Revision: D57279431\n\nfbshipit-source-id: 5bd085e6cbd6b57ffe15cfe15d39912b63b7e3f5","shortMessageHtmlLink":"Add elp.bxl to erlang prelude"}},{"before":"0e67e38a0d7181367fd2b1f57ba23581a32bb996","after":"5b8fbffe24105918c08ac08310c6e6f13cf8dab6","ref":"refs/heads/main","pushedAt":"2024-05-16T22:33:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Compile kernels with standard buck2 c++ rules\n\nSummary:\nPreviously, RuntimeSupport was built using genrules in order to use the correct version of the toolchain.\n\nWe have buck2-native toolchain definitions for all the asic flavors, as well as transition functions that let us depend on a RISCV library from an x86 binary (such as predictor)\n\nThis diff migrates these genrules to use `fb_native.cxx_library` instead with the proper toolchain. This will open the door in the future to better organizing individual kernels to maximize caching and minimize rebuilds.\n\nCurrent WIP status:\n - Artemis kernels build\n - Athena kernels have some header ordering issues that I'm sorting through\n - Freya kernels are failing due to a missing builtin\n\nReviewed By: fenypatel99\n\nDifferential Revision: D54912072\n\nfbshipit-source-id: cc647ba0ade7c55ffcafede5dd68fc1281da226f","shortMessageHtmlLink":"Compile kernels with standard buck2 c++ rules"}},{"before":"2753451d68b7ffcdbd5bcb8f6ff6719e705e303a","after":"0e67e38a0d7181367fd2b1f57ba23581a32bb996","ref":"refs/heads/main","pushedAt":"2024-05-16T17:25:52.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Couple force_rlib to advanced_unstable_linking\n\nSummary:\nOriginally, I had intended to try landing `advanced_unstable_linking` without disabling `force_rlib`. However, that caused ODR violations in fbcode mode/dev which were necessitating a change.\n\n`force_rlib` and `advanced_unstable_linking` are not necessary contradictory, but there's no reason (in my mind) that we would want to support the full mix of combinations; we really only want `force_rlib` + \"regular old linking\" and \"don't `force_rlib` + `advanced_unstable_linking`.\n\nThis diff removes the flag I added and fixes up existing checks to be the negative of `advanced_unstable_linking`, similar to how we had this implemented in buck1.\n\nReviewed By: dtolnay\n\nDifferential Revision: D57418748\n\nfbshipit-source-id: 463136c89a18743722273b4411ce3e493af35fe4","shortMessageHtmlLink":"Couple force_rlib to advanced_unstable_linking"}},{"before":"d3d9790a24d59bb054cdb770d2874b5121e051b1","after":"2753451d68b7ffcdbd5bcb8f6ff6719e705e303a","ref":"refs/heads/main","pushedAt":"2024-05-16T16:06:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add 'manifest' subtarget to android_binary\n\nReviewed By: navidqar\n\nDifferential Revision: D57434360\n\nfbshipit-source-id: 332aff35710870d80833541d2a4dbe37fa4d02c0","shortMessageHtmlLink":"Add 'manifest' subtarget to android_binary"}},{"before":"92d4d2f4395e0e3ab455e49980f40deea905d00a","after":"d3d9790a24d59bb054cdb770d2874b5121e051b1","ref":"refs/heads/main","pushedAt":"2024-05-16T15:31:45.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use versioned target triple when linking\n\nSummary: Use a versioned target triple when linking. This will be passed through as the `-platform_version` flag to the linker.\n\nReviewed By: milend\n\nDifferential Revision: D57404917\n\nfbshipit-source-id: e676b288367e1bedd5f6e6f2af5bb39588ae664b","shortMessageHtmlLink":"use versioned target triple when linking"}},{"before":"07f53dd616fd400f6703e119d4552b7f6cf625fd","after":"92d4d2f4395e0e3ab455e49980f40deea905d00a","ref":"refs/heads/main","pushedAt":"2024-05-16T13:15:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"prelude: `sh_binary` resources as an associated artifact\n\nSummary: This is needed to get the next diff working. Putting it in `other_outputs` isn't good enough, since there's a whole lot of stuff that doesn't pick that up (for example, if you pass this thing as a resource to another `sh_binary`)\n\nReviewed By: IanChilds\n\nDifferential Revision: D57426036\n\nfbshipit-source-id: 95b57935ae95eeb0ea561acffbe45fb37550e8ee","shortMessageHtmlLink":"prelude: sh_binary resources as an associated artifact"}},{"before":"2350b44df3174ccc26065968b9d1f27b0108d2c3","after":"07f53dd616fd400f6703e119d4552b7f6cf625fd","ref":"refs/heads/main","pushedAt":"2024-05-16T13:00:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Guard .deps with a hasattr\n\nSummary: `apple_xcuitest()` rule doesn't have `deps` attribute.\n\nReviewed By: constantine-fry\n\nDifferential Revision: D57437504\n\nfbshipit-source-id: 81a0d8892ac782fea6a4192c06d29fa22e224253","shortMessageHtmlLink":"Guard .deps with a hasattr"}},{"before":"9927bb8781520d62e1298b0231a133a99582d80d","after":"2350b44df3174ccc26065968b9d1f27b0108d2c3","ref":"refs/heads/main","pushedAt":"2024-05-16T12:35:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Generate additional platforms when cxx.default_platform is overridden on the command line\n\nReviewed By: milend\n\nDifferential Revision: D57406561\n\nfbshipit-source-id: 88eaa471273095ed5817fe0ac76b196cbae8036b","shortMessageHtmlLink":"Generate additional platforms when cxx.default_platform is overridden…"}},{"before":"956990f2f7ddddea95389fb6b82b624fdaa109a9","after":"9927bb8781520d62e1298b0231a133a99582d80d","ref":"refs/heads/main","pushedAt":"2024-05-16T10:59:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add \"driver\" extension to the allowlist of code-signing types.\n\nSummary: Add \"driver\" extension to the allowlist of code-signing types. Without this, the provisioningprofile was not added as part of \".driver\" files adhoc code-signing.\n\nReviewed By: blackm00n\n\nDifferential Revision: D57329251\n\nfbshipit-source-id: 193286b56500d1a188f2e7061ce62f0ef387edc9","shortMessageHtmlLink":"Add \"driver\" extension to the allowlist of code-signing types."}},{"before":"069fde9e90cdac643b72b0060f7cc90a6439afe1","after":"956990f2f7ddddea95389fb6b82b624fdaa109a9","ref":"refs/heads/main","pushedAt":"2024-05-16T10:18:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Collect recursive bundle manifests\n\nSummary: Adds support for collecting recursive bundle manifests.\n\nReviewed By: benb\n\nDifferential Revision: D57376366\n\nfbshipit-source-id: 3bc145f872078eb2d9b908a3f909ef55c9477ecc","shortMessageHtmlLink":"Collect recursive bundle manifests"}},{"before":"fa1f3c37eb9ad4d0b7e58a23837f0a12c5a498fc","after":"069fde9e90cdac643b72b0060f7cc90a6439afe1","ref":"refs/heads/main","pushedAt":"2024-05-16T06:42:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support embedding `Requires-Dist` entries\n\nSummary:\nThis adds a new `requires` parameter for users to pass in deps that\n`pip` should install along with the wheel.\n\nLonger-term, we should look into ways to express this via the buck2\nbuild graph (e.g. other `python_wheel`s rules and third-party pypi deps\nshould propagate this info implicitly).\n\nReviewed By: manav-a\n\nDifferential Revision: D57415741\n\nfbshipit-source-id: 5b9c748ed3e5d9ac14e3ae9a46dbe031f7c043cf","shortMessageHtmlLink":"Support embedding Requires-Dist entries"}},{"before":"a31f764797e34288d68625c9c42e25650ea7c5c0","after":"fa1f3c37eb9ad4d0b7e58a23837f0a12c5a498fc","ref":"refs/heads/main","pushedAt":"2024-05-16T04:24:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"owners bxl query\n\nSummary:\nThis diff introduces a new owners query. This query determines owning python targets and root, providing other files within target.\n\n It takes a file path, returning an object of format\n `{'owning_targets': List, 'root': string, 'files': List}`\n - Owning targets is the list of python target labels that own the file.\n - Root is the buck project root.\n - Files is the list of files within the first owning target, if any.\n\nNOTE: it must always be run from within fbsource.\n\n*why?*\n[`ctx.cell_root`](https://dev.buck.build/command/root.html) simply provides the [root relative to the location of the bxl script](https://fb.workplace.com/groups/617497306123691/posts/26201052376183363/?comment_id=26212409261714341), not relative to the cwd the script is run from. similarly, I imagine `buck.root` works the same way. I wasn't able to get a separate buck project set up I don't think this script will work there. if we want to support other repos, we will probably need additional setup (the easiest way seems like it would be to copy this bxl script into their project at the same path).\n\nReviewed By: grievejia\n\nDifferential Revision: D57218173\n\nfbshipit-source-id: 070b6bb9a5b879bcdc2fff4d7d116fea7b2d17b7","shortMessageHtmlLink":"owners bxl query"}},{"before":"5d0ddb9a2bf84748310d3fe81c0670f4ff9316f9","after":"a31f764797e34288d68625c9c42e25650ea7c5c0","ref":"refs/heads/main","pushedAt":"2024-05-16T03:50:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable allow_dep_file_cache_upload for cxx\n\nSummary: Same as earlier diffs for cxx\n\nReviewed By: IanChilds\n\nDifferential Revision: D57019862\n\nfbshipit-source-id: a8d516212bd31a45cf1c37d6a71923649104cc83","shortMessageHtmlLink":"Enable allow_dep_file_cache_upload for cxx"}},{"before":"3ab7a8a0aee9628ae45b63a7f92cf42284539ac8","after":"5d0ddb9a2bf84748310d3fe81c0670f4ff9316f9","ref":"refs/heads/main","pushedAt":"2024-05-15T21:54:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Explicitly define fbsource and waios build modes\n\nSummary:\nPreviously, we were attempting to be dynamic in the build modes defined for FBSource/WAIPhone/OSS. However, in the current world of configuration (buck config, constraints, target platforms and config modifiers), this became awfully complex to get right in every situation.\n\nEspecially when attempting to define selects that are shared in different repositories (simple example in the next diff).\n\nThus, lets explicitly define the build modes used in fbsource and whatsapp. The open source ones were deleted in D55526692.\n\nFBSource:\n- local\n- master\n- profile\n- rc\n- production\n\nWhatsapp:\n- debug\n- profile\n- beta\n- release\n\nReviewed By: rmaz\n\nDifferential Revision: D57397477\n\nfbshipit-source-id: 10099c92aa95924321ae20bf5e6489f24475bb8e","shortMessageHtmlLink":"Explicitly define fbsource and waios build modes"}},{"before":"fc73d6b7524567457d96063cca361cc068bdfe84","after":"3ab7a8a0aee9628ae45b63a7f92cf42284539ac8","ref":"refs/heads/main","pushedAt":"2024-05-15T21:49:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Return `AppleBundleManifestInfo` provider from bundles\n\nSummary: Return `AppleBundleManifestInfo` from bundle-like rules.\n\nReviewed By: rmaz\n\nDifferential Revision: D57375998\n\nfbshipit-source-id: 0c28ba0fe81e37bc1e7289be32b39cbd8fbb6e22","shortMessageHtmlLink":"Return AppleBundleManifestInfo provider from bundles"}},{"before":"56855bef6a682fc21900fe66e9ab0cbffbee0465","after":"fc73d6b7524567457d96063cca361cc068bdfe84","ref":"refs/heads/main","pushedAt":"2024-05-15T20:17:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"guard k2 for release builds in kotlin_toolchain\n\nSummary:\nWe had k2 leaked to release builds because we are guarding the attribute in fb_android_library, but we have some android libraries defined using more low level macroses. S417756\n\nThe guard is going to work only for Buck2.\n\nReviewed By: navidqar\n\nDifferential Revision: D57382321\n\nfbshipit-source-id: d9130c5c7c509626470e43eee20d03504c1a9062","shortMessageHtmlLink":"guard k2 for release builds in kotlin_toolchain"}},{"before":"a7518185c17baca7a7cea7ff6578aa6859ef703f","after":"56855bef6a682fc21900fe66e9ab0cbffbee0465","ref":"refs/heads/main","pushedAt":"2024-05-15T17:04:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Introduce record types for bundle manifest\n\nSummary: Introduce `AppleBundleManifest` which will be used to carry the bundling manifest in a provider in a follow-up diff.\n\nReviewed By: rmaz\n\nDifferential Revision: D57375141\n\nfbshipit-source-id: d89bc2850e904bc73425ec029680e4fca4b683e9","shortMessageHtmlLink":"Introduce record types for bundle manifest"}},{"before":"972b0564ba6806025b65e98ef3a0a26433ce8916","after":"a7518185c17baca7a7cea7ff6578aa6859ef703f","ref":"refs/heads/main","pushedAt":"2024-05-15T13:13:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"buck2 | apple | Clamp to minimum toolchain version\n\nSummary:\nWhen building across the split_transition that underlies apple_xcframework, all platforms will end up with the same minimum deployment version for their target platform.\n\nWAFlipperKit is currently built with a script that builds iOS-arm64 for version 12.0 (so that it can be deployed back to older iPhones), and macCatalyst builds set to version 14.0. Porting this to apple_xcframework is blocked becase the minimum version for macCatalyst is 13.1 (the oldest version of Catalyst) - it can't support back to 12.0, but we need 12.0 for iPhones.\n\nWhen setting a minimum target to 12.0 in Xcode and building for catalyst, I can see that it passes `-target x86_64-apple-ios13.1-macabi`, i.e. it clamps the minimum version to 13.1.\n\nCurrently, when setting the minimum target to 12.0 in Buck2 and building for catalyst, the version is missing and a nonsensical build flag is passed:\n`-target x86_64-apple-ios-macabi`. (i.e. missing '13.1')\n\nThis diff clamps versions for all platforms at the `toolchain_min_version`.\n\nReviewed By: milend\n\nDifferential Revision: D57328419\n\nfbshipit-source-id: 0fa2d2360d0beb2427d93c7e4868d51015aeb8a2","shortMessageHtmlLink":"buck2 | apple | Clamp to minimum toolchain version"}},{"before":"4e9e6d50b8b461564a7e351ff60b87fe59d7e53b","after":"972b0564ba6806025b65e98ef3a0a26433ce8916","ref":"refs/heads/main","pushedAt":"2024-05-15T09:23:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix AppleEntitlementsInfo check\n\nReviewed By: IanChilds\n\nDifferential Revision: D57333438\n\nfbshipit-source-id: 530a08452fbd942867285bead82785d66fbcd9d2","shortMessageHtmlLink":"fix AppleEntitlementsInfo check"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETq_9bgA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/buck2-prelude"}