Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py-tx] Deprecate SignalExchangeAPI.fetch_value_merge #1218

Open
Dcallies opened this issue Nov 22, 2022 · 0 comments
Open

[py-tx] Deprecate SignalExchangeAPI.fetch_value_merge #1218

Dcallies opened this issue Nov 22, 2022 · 0 comments
Labels
python-threatexchange Items related to the threatexchange python tool / library

Comments

@Dcallies
Copy link
Contributor

Dcallies commented Nov 22, 2022

This API was intended to support a fancy data storage model that we don't actually need if we split up downloading from the API and converting to signals, like we eventually did.

https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/exchanges/signal_exchange_api.py#L127

Next steps:

  1. Should be marked as deprecated in the comments and marked for removal in 2.x.x
  2. Existing callsites should be removed

Any existing implementations that convert records into None to signal a deletion should instead be moved into the fetch() method instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-threatexchange Items related to the threatexchange python tool / library
Projects
None yet
Development

No branches or pull requests

1 participant